- lint only changes previous diff picked up out of data files, when the branch was out of date.
- full limit on merge forward to pick up changes in the lint checks between versions.
- update CODEOWNERS for .ci/*
And also fix a couple of bugs found when writing tests for the matching used
by tamarack bot. This expands the files that the core team will be requested for
on pull request reviews.
Due to the many merge conflicts created from #47106 against the 2017.7 branch
and #46002 against the 2018.3 branch, the changes from #47106 have been largely
removed from this merge forward and the HEAD of 2018.3 was taken.
A separate fix for Tornado 5.0 support will need to be made directly against the
2018.3 branch.
Conflicts:
- doc/topics/development/conventions/formulas.rst
- salt/master.py
- salt/minion.py
- salt/netapi/rest_tornado/saltnado.py
- salt/states/zfs.py
- salt/transport/ipc.py
- salt/transport/tcp.py
- salt/transport/zeromq.py
- salt/utils/async.py
- tests/support/helpers.py
- tests/support/parser/cover.py
- tests/unit/grains/test_core.py
- tests/unit/modules/test_ssh.py
- tests/unit/test_minion.py
- tests/unit/utils/test_safe_walk.py
`team-windows` should be requested for reviews whenever a windows test file
or the reg.py execution module and accompanying reg.py state file are edited.
The CODEOWNERS file documentation for GitHub says they use a .gitignore-style
file matching pattern. However, since [tamarack](https://github.com/rallytime/tamarack)
is doing the actual team review requesting work, it uses Python's fnmatch lib.
This PR updates some of the file matching patterns to use fnmatch more specifically
and will improve the review requests to be more accurate and increase the number
of automatic team review requests.
We're still within the 3 years and 2 months range. I opted to only
reduce this number by 15 instead of 25 because this change will mark
18 issues as stale rather than about 35.
We need to keep reducing this number, but we also don't want to flood
this process too much.
This config file enables the [probot-stale](https://github.com/probot/stale/)
bot to comment on stale issues. We're starting off with issues
that have become stale after approximately 3 years and 6 months.
This value is configured in the `daysUntilStale` setting.
