Fedora releases are integers, and Arch's osrelease is simply `rolling`,
so https://github.com/saltstack/salt/pull/45636 caused these tests to
regress. This fixes them by moving the osrelease check until after the
MacOS check.
It also fixes the windows check, which would _always_ evaluate to `True`
since it was not calling the function. Therefore, the `if` would just be
a simple boolean which would resolve to `True` since it was just checking
a function reference.
yum is no longer installed by default on fedora. apparently it has been
removed from the base installs, and only dnf is available. Stop depending on
the pkg manager, and just use bash.
Fixes the test failure happening on the SUSE Leap build in the nitrogen
branch.
Version can be an empty dictionary and pass the check, but then we hit
a key error on the next line. Let's avoid that.
This failure was caused by the changes in #41086.
Fixes https://github.com/saltstack/salt-jenkins/issues/332