Commit Graph

17 Commits

Author SHA1 Message Date
Stefan Schweer
a6c9f2b120 added missing whitespaces 2016-05-25 19:56:00 +02:00
Stefan Schweer
169dec76b7 improved tests 2016-05-25 10:23:14 +02:00
Stefan Schweer
f84740957a rebased on develop 2016-05-25 10:22:10 +02:00
Mike Place
a4abcc3d03 Remove rabbitmq unit tests (#33451)
* Remove completely pointless RabbitMQ unit test

Why would we even write tests to check to see if a mocked object
returns a string and then assert against that string?! This is absurd.

* Spurious print
2016-05-23 13:57:22 -07:00
rallytime
34300847ec Fix test failures 2016-03-24 09:48:54 -06:00
Stefan Schweer
bac08b24ec replaced ',' for whitespace as split seperator for rabbitmq tags
- fixed unit tests
2016-03-22 18:00:33 +01:00
Scott Walton
e9b84b35b4 Resolved merge conflict with upstream. 2015-11-11 16:38:31 +00:00
Scott Walton
e46d31d446 Amended the tests to remove the tab-check and still keep #28608 fixed 2015-11-11 16:32:56 +00:00
Colton Myers
c90431eddc Rip out unit test that doesn't apply anymore
We now use -q with the command so we don't have to test our ability to
strip "Listing vhosts" out of the test
2015-11-09 15:22:01 -07:00
Scott Walton
540305dc99 Added test and fix for #28608. 2015-11-06 09:06:07 +00:00
Erik Johnson
a44c8d8dab Merge pull request #28270 from rallytime/refactor_rabbitmq_plugin_state
Refactor RabbitMQ Plugin State to correctly use test=true and format errors
2015-10-27 11:18:34 -06:00
rallytime
9e40c3a6a6 Fine tuning and fix tests 2015-10-27 10:30:00 -04:00
rallytime
19b8b868a3 Clean-up/fixes to rabbitmq_user state and test adjustments 2015-10-26 13:48:50 -04:00
Jeff Quast
a154280b34 bugfix: trailing "...done" in rabbitmq output
Problem
-----------

Some versions of rabbitmq (v3.4.1) does not output any final
"...done" line in output of listings, but the given salt code
unconditionally removed the final line of output, which may
often result in inconsistent behavior of dependent state
functions, where the final line has a value that is significant.

Solution
-----------

This bugfix changes this output manipulation to be conditional,
matching only lines of ``"Listing ..."`` as the first, and
``"...done"`` as the last.

Details
---------

In my environment::

    [rabbitmq@db01 ~]$ rabbitmqctl list_vhosts
    Listing vhosts ...
    /

This causes issues in, for example, a vhost is attempted to
be created for '/' that already exists, if that vhost happens
to be the last one listed in command output, it is thought
non-existent, resulting in state failure::

    Failure: rabbitmq_vhost_|-rabbitmq-vhost_|-/_|-present: Creating vhost "/" ...
    Error: vhost_already_exists: /
2015-06-09 17:30:40 -07:00
Colton Myers
90cb448910 Fix rest of rabbitmq tests 2015-05-29 15:11:25 -06:00
Colton Myers
7736509c6b Fix rabbitmq test 2015-05-29 15:11:19 -06:00
Jayesh Kariya
a6f867630f adding rabbitmq unit test 2015-03-16 10:28:13 +05:30