21 Commits

Author	SHA1	Message	Date
Erik Johnson	3184168365	Use explicit unicode strings + break up salt.utils ... This PR is part of what will be an ongoing effort to use explicit unicode strings in Salt. Because Python 3 does not suport Python 2's raw unicode string syntax (i.e. `ur'\d+'`), we must use `salt.utils.locales.sdecode()` to ensure that the raw string is unicode. However, because of how `salt/utils/__init__.py` has evolved into the hulking monstrosity it is today, this means importing a large module in places where it is not needed, which could negatively impact performance. For this reason, this PR also breaks out some of the functions from `salt/utils/__init__.py` into new/existing modules under `salt/utils/`. The long term goal will be that the modules within this directory do not depend on importing `salt.utils`. A summary of the changes in this PR is as follows: * Moves the following functions from `salt.utils` to new locations (including a deprecation warning if invoked from `salt.utils`): `to_bytes`, `to_str`, `to_unicode`, `str_to_num`, `is_quoted`, `dequote`, `is_hex`, `is_bin_str`, `rand_string`, `contains_whitespace`, `clean_kwargs`, `invalid_kwargs`, `which`, `which_bin`, `path_join`, `shlex_split`, `rand_str`, `is_windows`, `is_proxy`, `is_linux`, `is_darwin`, `is_sunos`, `is_smartos`, `is_smartos_globalzone`, `is_smartos_zone`, `is_freebsd`, `is_netbsd`, `is_openbsd`, `is_aix` * Moves the functions already deprecated by @rallytime to the bottom of `salt/utils/__init__.py` for better organization, so we can keep the deprecated ones separate from the ones yet to be deprecated as we continue to break up `salt.utils` * Updates `salt/*.py` and all files under `salt/client/` to use explicit unicode string literals. * Gets rid of implicit imports of `salt.utils` (e.g. `from salt.utils import foo` becomes `import salt.utils.foo as foo`). * Renames the `test.rand_str` function to `test.random_hash` to more accurately reflect what it does * Modifies `salt.utils.stringutils.random()` (née `salt.utils.rand_string()`) such that it returns a string matching the passed size. Previously this function would get `size` bytes from `os.urandom()`, base64-encode it, and return the result, which would in most cases not be equal to the passed size.	2017-08-08 13:33:43 -05:00
rallytime	ccf790a83f	Update all references for moved functions to use "files" util ... - fopen - flopen - fpopen - safe_rm - is_empty - is_fcntl_available	2017-07-18 10:31:01 -06:00
rallytime	4a7073ac79	Add generate_random_name function to tests helpers ... This function is used identically in every cloud provider test file. Let's add it to a more central place and make it more DRY. Might be useful in other testing places as well.	2017-06-29 15:43:03 -06:00
Daniel Wallace	f309bae8b4	Make sure runtests_engine is ASCII text ... If this is has any unicode characters in it, it won't load on systems that do not default to a unicode locale. find . -type f | while read line; do ret=$(file $line); if [[ $ret == *UTF-8* && $line == *.py ]]; then echo $line; fi; done The above will list all files that have unicode characters in it and won't load with locale set to C or POSIX	2017-06-05 17:30:28 -06:00
Erik Johnson	3881b6e0f3	Prepare git_pillar test code for adding HTTP tests ... This further abstracts some of the setup and teardown code so it can be used for git-over-http tests. It also moves the code that was originally added to the archive state integration tests to create a local http server into salt.support.helpers so that it can be more easily and portably used.	2017-04-24 11:00:39 -05:00
Pedro Algarvio	c3417213d7	Make sure the socket's used are closed	2017-04-04 19:28:06 +01:00
Pedro Algarvio	61003bca0a	Take care of resource leakage on tests	2017-04-04 18:58:20 +01:00
Pedro Algarvio	42e35e13cc	Use mock to patch	2017-04-04 18:58:20 +01:00
Pedro Algarvio	9af2ca8823	No need to load all modules docs. ... This should reduce memory usage as well as speeding up the decorator	2017-04-04 18:04:38 +01:00
Pedro Algarvio	6fe53339ce	Gate class definitions	2017-03-11 19:46:23 +00:00
Pedro Algarvio	992a8c7294	Don't hardcode the webserver port number	2017-03-11 16:00:28 +00:00
Pedro Algarvio	df942bc082	Add a repeat decorator to retry passing tests N times until it fails	2017-03-08 18:34:33 +00:00
Pedro Algarvio	07d0a5ed20	Cleanup after ourselves	2017-03-08 18:34:32 +00:00
Pedro Algarvio	ffec7dc299	Lint fixes	2017-03-06 14:35:16 +00:00
Pedro Algarvio	5e3309d5f8	Let's use the skip_if_not_root decorator instead	2017-03-02 19:58:10 +00:00
Pedro Algarvio	96bcaf5365	The order is shady under Py3 ... /cc @cachedout @rallytime	2017-03-02 19:56:05 +00:00
Pedro Algarvio	ab83cced63	Child processes termination cleanup	2017-03-01 01:33:07 +00:00
Pedro Algarvio	40a64191a1	Absolute imports and A LOT of code cleanup.	2017-03-01 01:33:07 +00:00
Pedro Algarvio	3beb3fb801	Move whatever we need from salttesting to salt. ... Let's drop the salttesting dependency cycle.	2017-02-28 22:52:49 +00:00
Pedro Algarvio	53eff91efa	Re-enable the test since we now have the flaky decorator	2017-02-28 22:52:48 +00:00
Pedro Algarvio	2a9d2beb02	The order is shady under Py3 ... /cc @cachedout @rallytime	2017-02-28 22:52:48 +00:00