There is a note about deprecating cmd.wait in the docs of the cmd state.
However, this function has not been put on an official deprecation path
and there are no plans to deprecate it. Therefore, we shouldn't have
this note in the docs.
See #44831 for more information.
Before this, multiple names would have the same stateid and module, so we need
the actual name to distinguish them
```
test:
pkg.latest:
- names:
- nginx
- cronie
file.touch:
- name: /tmp/test
service.running:
- names:
- nginx
- crond
- listen:
- file: test
```
Only one, nginx or crond would be restarted (should be the last one in the
list), because of how the ordered dict did the lookup.
Instantiating AppsV1beta1DeploymentSpec without specifying a template
will raise:
ValueError: Invalid value for `template`, must not be `None`
Therefore directly specifying the template when instantiating
AppsV1beta1DeploymentSpec and use '' as default template. This fixes the
test_create_deployments test case (fixes#46329).
Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
We had a similar check to ensure "foo: bar" isn't loaded as a dict, this
adds a check to ensure that we only load lists when there is a leading
bracket.
In some edge cases, the branch/directory paths used here could have
values loaded as int/float/etc., which is not a problem for
salt.utils.gitfs since it normalizes these values to strings. Therefore,
this commit removes them from VALID_OPTS so that we skip type-checking
to avoid spurious warnings in the log file.
Adds the `ignore_retcode` option to the _pshell helper function
The _pshell helper function will either return a dict or raise an error
When powershell returns an empty string, makes it an empty dict
Adds some `log.info` commands for easier debugging
Fixes some erroneous CLI Examples
Handles situations where _shell returns an empty dict
Handles situations where a powershell command completed successfully,
but returned invalid JSON
`dsc.get_config` returns a cleaner dict
Adds a `dsc.remove_config` function with the option to reset the dsc
environment entirely
Adds a `dsc.restore_config` function to rollback to a previous config
Fixes some issues with Py3 not building
Brings the 2 build_env files more in line with each other
Fixes some typos in the build_env scripts
Removes the need for seperate req files for Py2 and Py3
Setup.py uses the windows req file on Windows
Removes the need to install pycrypto and pyyaml in setup.py. They are
now handled in the req.txt
Uses pypi resources instead of downloading .whl files and .exes for
dependencies
Updates nssm version to address the issue in #46192
Removes nssm from buildenv and downloads 32 and 64 bit versions of nssm
in build_pkg.bat
Removes the AppNoConsole=1 setting from the nsis script since it is not
needed with the new version of nssm
Use `len()` to determine emptiness of a dictionary.
PR#44624 introduced a Python3 incompatible comparison where a dict is
compared against an integer, causing breakage on Ubuntu 18.04/bionic
which uses Python3 by default for SaltStack:
```
File "/usr/lib/python3/dist-packages/salt/modules/upstart.py", line 100, in _find_utmp
if result > 0:
TypeError: '>' not supported between instances of 'dict' and 'int'
```
