Nicole Thomas
f7411393e4
Merge pull request #41495 from isbm/bp-41405
...
Takeover from "rallytime:bp-41405"
2017-05-30 09:11:43 -06:00
Mike Place
491d4d941a
Merge pull request #41430 from DSRCorporation/bugs/py3_tests_nitrogen
...
One more bunch of tests fixes.
2017-05-26 16:53:37 -05:00
rallytime
9b84b751b2
Pylint fixes
2017-05-26 12:38:38 -06:00
Petr Michalec
6db8915021
Endpoint handling per region, fixes #35874
...
- extend tests for multiple regions
- region arg by default set to None
- print verbose changes to be exec.
2017-05-26 11:15:29 -06:00
Bo Maryniuk
fa5c2c1672
Add UT for unsupported operators
2017-05-25 12:55:46 -06:00
Bo Maryniuk
157b83c05a
Lintfixes
2017-05-25 12:55:46 -06:00
Bo Maryniuk
43abd345b2
Add UT for operator conditions
2017-05-25 12:55:46 -06:00
Bo Maryniuk
1053daf2d0
Add UT for typecheck on the output data
2017-05-25 12:55:46 -06:00
Bo Maryniuk
5c1259834f
Add UT for None type verification if version has been not passed
2017-05-25 12:55:46 -06:00
Bo Maryniuk
0dd27380b1
Add UT for wildcard finder usage
2017-05-25 12:55:46 -06:00
Bo Maryniuk
5e836a2543
Test the exact methods for matcher
2017-05-25 12:55:46 -06:00
Bo Maryniuk
2af4160a1a
Add UT for exact match of the pattern at the beginning
2017-05-25 12:55:46 -06:00
Bo Maryniuk
5a2248d254
Add UT for exact match of the pattern at the end
2017-05-25 12:55:46 -06:00
Bo Maryniuk
334c634826
Add UT to match multiple asterisks
2017-05-25 12:55:46 -06:00
Bo Maryniuk
f73b39fd3c
Add UT for matching all versions
2017-05-25 12:55:46 -06:00
Bo Maryniuk
a9c3c8bf03
Fix a docstring
2017-05-25 12:55:46 -06:00
Bo Maryniuk
344295666b
Rename UT to a proper name
2017-05-25 12:55:46 -06:00
Bo Maryniuk
369b4bf127
Add unit test scaffold for wildcard support
2017-05-25 12:55:46 -06:00
rallytime
ff0def408b
Whitespace fix
2017-05-25 10:26:06 -06:00
Dmitry Kuzmenko
7a9b4a92af
Fixed syslog-ng test: it passes command as list, not as a string.
2017-05-25 14:33:43 +03:00
Dmitry Kuzmenko
6b0921e5ba
Py3 tests fixes: don't mock non-callable objects with return_value.
...
mock = MagicMock(return_value='') works for functions: here mock() will
return the value (empty string). But mock returns the MagicMock object.
Not sure why but it worked in Py2, but in Py3 os.path.join(mock,
'something'), for instance, returns an error.
Fixed the issues by avoiding of using mocks where we can use simple
strings.
2017-05-25 12:33:43 +03:00
rallytime
9ff2694155
Merge branch '2016.11' into 'nitrogen'
...
Conflicts:
- pkg/salt-minion.service
- salt/modules/junos.py
- salt/modules/localemod.py
- salt/modules/win_system.py
- salt/states/junos.py
- tests/unit/modules/test_localemod.py
- tests/unit/modules/test_win_powercfg.py
- tests/unit/states/dockerng_test.py
2017-05-24 16:32:59 -06:00
Mike Place
88fd3c0ed9
Merge pull request #41336 from mcalmer/fix-locale-on-SUSE
...
fix setting and getting locale on SUSE systems
2017-05-24 12:46:07 -05:00
Benjamin Drung
33a7f8b2ec
Fix typos
...
lintian found several spelling errors.
Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
2017-05-24 12:50:29 +02:00
rallytime
616ac7289b
Merge branch '2016.11' into 'nitrogen'
...
Conflicts:
- salt/config/__init__.py
- salt/modules/elasticsearch.py
- tests/integration/__init__.py
2017-05-23 10:36:41 -06:00
Mike Place
1ba95684a9
Merge pull request #41113 from cro/proxy_auto_test2
...
Rescue proxy_auto_tests PR from git rebase hell
2017-05-22 12:05:07 -05:00
rallytime
c6c1d30c48
Merge branch '2016.11' into 'nitrogen'
...
Conflicts:
- salt/modules/yumpkg.py
- salt/spm/__init__.py
- tests/unit/modules/test_zypper.py
- tests/unit/utils/test_network.py
2017-05-20 17:07:34 -06:00
Michael Calmer
f30f5c8a25
fix unit tests
2017-05-19 13:28:52 +02:00
Mike Place
9f359d841f
Merge pull request #41208 from pkazmierczak/pkazmierczak-zypper-multiple-ver-pkgs
...
Fix: zypper handling of multiple version packages
2017-05-18 10:44:26 -05:00
Mike Place
1c1e092f56
Merge pull request #41269 from isbm/isbm-minion-id-127-name
...
Bugfix: Unable to use "127" as hostname for the Minion ID
2017-05-17 13:31:15 -05:00
Mike Place
fe38c7cf5e
Merge pull request #41282 from mcdermj/bp-41247
...
JunOS: Change os_install to use get_file instead of get_template
2017-05-17 13:25:26 -05:00
Piotr Kaźmierczak
d411a91676
Reverted back to cascading with statements for python 2.6 compat
2017-05-17 11:52:56 +02:00
rallytime
76714d116b
Mock calls to salt.utils.pkg.clear_rtag call in aptpkg unit tests
2017-05-16 16:00:37 -06:00
Piotr Kaźmierczak
7204013653
Compacted with statements in the unit test.
2017-05-16 22:48:09 +02:00
Piotr Kaźmierczak
6c4c08042c
Added unit tests and copied the behavior to
...
.upgrade method, too.
2017-05-16 20:47:04 +02:00
Jeremy McDermond
3e481cb764
JunOS: Fix whitespace for PEP compliance
2017-05-16 10:00:58 -07:00
Jeremy McDermond
f1751d135a
JunOS: Fix Unit Test
...
When adding the cp.get_file function, we need to add it into the list of
mock functions in the unit test along with get_template or the unit
tests will fail.
2017-05-16 10:00:50 -07:00
Bo Maryniuk
5168ef8959
Add unit test for hostname can be started from 127
2017-05-16 16:18:14 +02:00
Bo Maryniuk
d9c8324a6b
Unit test for accepting hosts names as 127
2017-05-16 12:07:32 +02:00
rallytime
d23010a114
Merge branch '2016.11' into 'nitrogen'
...
Conflicts:
- salt/modules/aptpkg.py
- salt/states/libcloud_dns.py
- salt/states/pkg.py
- tests/integration/modules/test_pkg.py
- tests/unit/modules/test_mac_brew.py
- tests/unit/modules/test_pkgutil.py
- tests/unit/modules/test_zypper.py
- tests/unit/states/libcloud_dns_test.py
2017-05-15 16:41:59 -06:00
Nicole Thomas
75942235f0
Merge pull request #41220 from rallytime/bp-40246
...
Back-port #40246 to 2016.11
2017-05-15 11:59:38 -06:00
Mike Place
50d8fde123
Merge pull request #41101 from terminalmage/issue40940
...
Fix "latest" keyword for version specification when used with aggregation
2017-05-15 11:52:35 -05:00
Dmitry Kuzmenko
b10730d8a1
Py3: Fixed timezone test.
2017-05-15 19:40:57 +03:00
Anthony Shaw
2f610680e5
remove unused imports
2017-05-12 16:38:30 -06:00
Anthony Shaw
9b7de2e7d7
fix unit tests
2017-05-12 16:37:26 -06:00
Anthony Shaw
49d94559ab
linting
2017-05-12 16:36:07 -06:00
Anthony Shaw
4b260a4594
linting
2017-05-12 16:36:07 -06:00
Anthony Shaw
41d1adab5f
fix up tests
2017-05-12 16:36:06 -06:00
C. R. Oldham
19db038b99
Fix test--use proxy_config instead of minion_config
2017-05-12 14:01:54 -06:00
Nicole Thomas
88eabbb57d
Merge pull request #41179 from rallytime/fix-jinja-template-test
...
Split up test asserts in jinja template unit test
2017-05-11 10:23:16 -06:00
rallytime
738681c20f
Pylint fix
2017-05-11 09:03:10 -06:00
rallytime
6729587d54
Spelling fix
2017-05-10 16:59:39 -06:00
rallytime
3a5419ba3f
Split up test asserts in jinja template unit test
...
Due to a bug in the equality handler, this test was failing on
CentOS 6 running Python 2.7.13. This PR splits up the test assertions
into several different pieces in order to cover all the possible
use cases, but also pass on CentOS 6.
2017-05-10 16:55:37 -06:00
rallytime
12a75c1108
Merge branch '2016.11' into 'nitrogen'
...
No conflicts.
2017-05-10 15:32:23 -06:00
Nicole Thomas
496fa3accd
Merge pull request #41156 from rallytime/merge-nitrogen
...
[nitrogen] Merge forward from 2016.11 to nitrogen
2017-05-10 15:29:54 -06:00
rallytime
9014033726
Use LoaderModuleMockMixin for setting up default grains/salt dunders
2017-05-10 13:49:43 -06:00
rallytime
c282533612
Use with patch.dict for timezone.__grains__ dictionaries
2017-05-10 10:32:24 -06:00
lomeroe
2af89f2165
update mock data
2017-05-10 10:33:34 -05:00
lomeroe
b7fa115a59
update win_dns_client tests with correct module names
2017-05-10 10:33:33 -05:00
rallytime
baa8e3f5a6
Move new timezone_test.py tests over to test_timezone.py tests
2017-05-09 16:33:18 -06:00
twangboy
bc827ad8a7
Fix unit test
2017-05-09 16:00:24 -06:00
rallytime
ef0df4a954
Merge branch '2016.11' into 'nitrogen'
...
Conflicts:
- salt/modules/win_network.py
- salt/modules/win_pkg.py
- salt/utils/gitfs.py
- tests/unit/modules/test_win_network.py
- tests/unit/states/test_file.py
2017-05-09 14:32:49 -06:00
Mike Place
a2f359fa13
Merge pull request #40852 from isbm/isbm-fix-coregrains-constants-bsc#1032931
...
Isbm fix coregrains constants bsc#1032931
2017-05-09 12:35:45 -06:00
Bo Maryniuk
f3b12a3f5b
Do not use multiple variables in "with" statement as of lint issues
2017-05-09 10:17:49 +02:00
Theophile Meneau
d8766562c9
fix incorrect service.running success response
...
when enable=None and init script returns 0,
but service failed to start.
Fixes #41125
2017-05-08 10:25:21 -04:00
Bo Maryniuk
35a8d99934
Disable the test for a while
2017-05-08 13:49:54 +02:00
Bo Maryniuk
76cb1b7150
Rewrite test case for using no patch decorators
2017-05-08 10:41:50 +02:00
Erik Johnson
ffe4bc3d5c
update unit test to reflect new behavior
2017-05-06 01:29:49 -05:00
Erik Johnson
2af89beb53
Merge pull request #41103 from lorengordon/win.get_route
...
Adds a get_route() function to win_network.py
2017-05-06 01:19:41 -05:00
Erik Johnson
92011dbe5f
Fix "latest" keyword for version specification when used with aggregation
...
The "latest" keyword was only implemented when both "name" and "version"
were used, and not for "pkgs". But mod_aggregate puts all packages into
a single low chunk, within "pkgs". This means that using aggregation in
conjuntion with the "latest" keyword no longer resolves the latest
version and thus breaks these states.
This fixes the problem by moving the logic for resolving the "latest"
keyword into _find_install_targets(). It also makes some improvements to
the logic we use to ensure only one package DB refresh is performed per
Salt run, by making the pkg.refresh_db functions handle removing the
rtag file, instead of requiring a call to a helper function everywhere
in the pkg state where we might be calling a function that refreshes the
package DB.
2017-05-06 00:46:06 -05:00
Loren Gordon
93ce5644ea
Adds test for win_network.get_route
2017-05-05 17:32:50 -04:00
rallytime
6e857681d4
Add calls to salt.client.get_local_client to patches list in auth unit tests
...
We need to mock the calls to `salt.client.get_local_client` in the
tests.unit.test_auth.py file. Without these mocks, there are many tests
that fail when the entire set of unit tests runs. (Specifically, these fail
with both the module and state boto_apigateway unit tests run.)
This mocked patch is similar to the change in PR #41082 and fixes all 16 test
failures reported in https://github.com/saltstack/salt-jenkins/issues/326 .
2017-05-05 14:26:54 -06:00
rallytime
891e174f71
Patch calls to salt.client.Caller and salt.client.get_local_client in spm unit tests
...
Fixes the spm unit test failures in CentOS 6. These calls to the client need to be
patched so they don't interact with other unit tests.
2017-05-04 14:30:49 -06:00
Mike Place
044e0b2063
Merge pull request #40860 from twangboy/change_broadcast
...
Remove dependency on win32gui
2017-05-02 10:45:51 -06:00
Erik Johnson
26d2f4a52a
Do not automatically unmask services to start/restart/etc. them
2017-05-01 16:01:35 -05:00
Mike Place
9d12a614b7
Fix failing test
2017-05-01 11:50:39 -06:00
Pedro Algarvio
fc90c8ec06
Switch how IOLoop's are run on these tests
2017-04-28 13:36:45 +01:00
Pedro Algarvio
e6ee82e7be
The expected error message is different on py2 and py3
2017-04-28 13:36:45 +01:00
Pedro Algarvio
d65742c066
Delete attributes
2017-04-28 13:36:44 +01:00
Pedro Algarvio
abe608d739
Drop @patch
usage
2017-04-28 13:36:42 +01:00
Pedro Algarvio
4b59c351e4
This branch no longer targets py 2.6
2017-04-28 13:33:37 +01:00
Pedro Algarvio
9a3f6d1350
Properly handle non native strings under py2 and py3
2017-04-28 13:33:36 +01:00
Pedro Algarvio
5ed3d8d98c
Don't error out because of bad file descriptor errors
2017-04-28 13:33:36 +01:00
Pedro Algarvio
102d63e238
Use self.addCleanup
instead
2017-04-28 13:33:36 +01:00
Pedro Algarvio
ef3dbb10de
Lint fixes
2017-04-28 13:33:35 +01:00
Pedro Algarvio
9ffc79ca67
Use tornado HTTPClient directly.
2017-04-28 13:33:35 +01:00
Pedro Algarvio
80b80e5416
Fix cherrypy memory leakage
...
* Clean its event/signal bus since our tests don't rely on those.
* No test class level dictionaries
2017-04-28 13:33:35 +01:00
Pedro Algarvio
3bf84e2a4e
Rename classes in order not to be collected up by pytest
2017-04-28 13:33:34 +01:00
Pedro Algarvio
7480a8e5fb
Check status on setUp
not on the module level @skipIf
decorator
2017-04-28 13:33:34 +01:00
Pedro Algarvio
6eac0ee132
Call tearDown
and not setUp
...
@cachedout with this change, the FD's still attached code will always
fail, so, for now, that's just commented out.
When you wrote this, did tornado eventually cleaned these FD's?
2017-04-28 13:33:34 +01:00
Pedro Algarvio
6364128ad3
Fix tornado test cases
2017-04-28 13:33:34 +01:00
Pedro Algarvio
701280ae18
Cleanup
2017-04-28 13:33:33 +01:00
Pedro Algarvio
75569c8e99
unittest.TestCase
does not have a skip()
method. It's skipTest
.
2017-04-28 13:33:33 +01:00
Pedro Algarvio
1d8f02f635
Drop @patch
usage. Py3 Compat.
2017-04-28 13:33:32 +01:00
twangboy
e8d440b543
Mock win32api instead of win32gui
2017-04-26 12:41:13 -06:00
rallytime
2f1998ac00
Pylint extra space
2017-04-25 16:41:39 -06:00
rallytime
ad9914353b
Pylint fixes
2017-04-25 14:18:50 -06:00
rallytime
c3f4874c21
Pylint fixes and rework new test in dimensiondata cloud unit tests
2017-04-25 11:06:55 -06:00
rallytime
8e24b3a8b2
Pylint fixes for some cloud unit tests
2017-04-25 11:06:39 -06:00
twangboy
fa8f9b55d8
Fix unit test, still mocking SendMessageTimout
2017-04-25 10:13:55 -06:00