ex_list_projects is introduced in version 0.15 of libcloud. I'm simply
cathing the AttributeError here to return False, just like there would
be not project.
Fixes#31729
This should have been changed when we altered the default value in
16a3938. It caused a missing pillar_opts minion config value to
incorrectly assume that master config should have been added to the
pillar data.
`EXPOSE` and `VOLUME` declaration of a Dockerfile are exactly like
user declaration those parameters in their sls for dockerng.running
Considering Dockerfile containing this line:
```
EXPOSE 80
```
Those 2 sls are now considered strictly equivalent.
```yaml
container:
dockerng.running:
image: alpine
ports:
- 80/tcp
```
```yaml
container:
dockerng.running:
image: alpine
```
Some events just contain a timestamp and a minion list, but no jid.
These can safely be ignored, lest they cause supurious log messages.
Also, pass the syndic's id so that it can be stored in a unique file in
the job cache (in the local_cache returner).
using module.run to check if port 53 is opened on localhost, using module network.connect
example state:
~~~
network.connect:
module.run:
- host: {{ salt['network.ipaddrs']()|join }}
- port: 53
- port: 1234
- proto: udp
unexpected behavior:
module.run will always succeed,
even If network.connect returns result: False
example output (before the change):
----------
ID: network.connect
Function: module.run
Result: True
Comment: Module function network.connect executed
Started: 22:28:29.475623
Duration: 0.001 ms
Changes:
----------
ret:
----------
comment:
Unable to connect to 10.0.0.50 (10.0.0.50) on tcp port 1234
result:
False
Proposal:
Proposing to check changes_ret.result and return it as a result before trying to check changes_ret.retcode
tested expected behavior:
~~~
----------
ID: network.connect
Function: module.run
Result: False
Comment: Module function network.connect executed
Started: 22:50:25.149832
Duration: 9.964 ms
Changes:
----------
ret:
----------
comment:
Unable to connect to 10.0.0.50 (10.0.0.50) on tcp port 1234
result:
False
----------
ID: network.connect
Function: module.run
Result: True
Comment: Module function network.connect executed
Started: 22:50:07.129629
Duration: 0.205 ms
Changes:
----------
ret:
----------
comment:
Successfully connected to 10.0.0.50 (10.0.0.50) on tcp port 53
result:
True
This is a frequent stumbling block for users unaccustomed to the older
`mod.setting` configuration syntax. Often they will interpret the list
of settings as needing to be underneat a top-level `smtp` dictionary.
This has been on my todo list for a looong time. :-P
YAML doesn't make sense here since we're just rendering a text email.
The user can still override in the smtp renderer settings if the user
has complex needs.
