Commit Graph

5 Commits

Author SHA1 Message Date
rallytime
4e87557748 --local is not available in older versions of git
Also adjust the tests:
    subprocess.check_output is only available in python 2.7
2015-01-07 11:56:43 -07:00
Pedro Algarvio
a802d8f7f5 Use the skip_if_binaries_missing_helper 2014-11-20 16:40:38 +00:00
rallytime
e70537eb2c Fix missing cls variable and add some docstring info 2014-11-20 09:15:56 -07:00
Jonathan Ballet
a6c3499749 Please pylint
My patch #18221 yesterday introduced new Pylint warnings/errors.

This fixes these warnings.
2014-11-19 19:28:28 +01:00
Jonathan Ballet
38bb70d398 Fix Git's config set with values containing white spaces.
The Salt function 'git.config_set' and the state 'git.config' (which relies
on the former) don't escape the value to be set in the configuration file
passed by Salt. For example, this doesn't work:

  mylocalrepo:
    git.config:
      - name: user.name
      - value: "Jonathan Ballet"
      - repo: file://my/path/to/repo

This set the 'user.name' configuration value to "Jonathan" only.
(Additionally, the state discovers that the value set is not the one
specified, and keeps trying to set the right value, which ends up with lot
of "name = Jonathan" into the "[user]" section of Git's config file.)

This commit fixes the problem and adds some unit tests to verify it's
working properly.
2014-11-18 20:02:24 +01:00