Commit Graph

357 Commits

Author SHA1 Message Date
Pedro Algarvio
ea717d2422 Switch open() for salt.utils.fopen() 2014-11-26 17:59:52 +00:00
Thomas S Hatch
873d1c1803 Merge pull request #18221 from multani/fix/git-config-set-shell-escape
Fix Git's config set with values containing white spaces.
2014-11-18 17:14:43 -07:00
Jonathan Ballet
38bb70d398 Fix Git's config set with values containing white spaces.
The Salt function 'git.config_set' and the state 'git.config' (which relies
on the former) don't escape the value to be set in the configuration file
passed by Salt. For example, this doesn't work:

  mylocalrepo:
    git.config:
      - name: user.name
      - value: "Jonathan Ballet"
      - repo: file://my/path/to/repo

This set the 'user.name' configuration value to "Jonathan" only.
(Additionally, the state discovers that the value set is not the one
specified, and keeps trying to set the right value, which ends up with lot
of "name = Jonathan" into the "[user]" section of Git's config file.)

This commit fixes the problem and adds some unit tests to verify it's
working properly.
2014-11-18 20:02:24 +01:00
Mike Place
c1c9245e89 Fixup test failures 2014-10-28 11:29:59 -06:00
Mike Place
e18190bc04 remove sed test 2014-10-27 18:22:18 -06:00
Erik Johnson
ff6a228746 Remove reference to nonexistant function in pkg tests
This fixes a ref that was missed in 7984a8c.
2014-08-27 13:52:36 -05:00
Seth House
11f4e20bd8 Fix incorrect call to state.single in npm pkgs test 2014-08-11 11:03:00 -04:00
Seth House
ed4bb5119e Added pkgs support to the npm module/state 2014-08-07 12:36:39 -04:00
rallytime
6be33dcdc9 Change install package to help Arch tests pass 2014-08-05 14:35:32 -06:00
C. R. Oldham
253de7a995 PyLint fix. 2014-07-25 12:48:07 -06:00
C. R. Oldham
f53e477735 Merge commit, resolve conflict 2014-07-25 11:16:22 -06:00
C. R. Oldham
c94808689d Extend dot-in-pkg test to RHEL 5 as well 2014-07-25 10:57:18 -06:00
Thomas S Hatch
288e9bba29 TABS?!?!? Really @cro ?? 2014-07-25 10:39:19 -06:00
C. R. Oldham
b6f70ac80f Make this test check for diff packages on RHEL/Centos 6 vs 7 2014-07-24 19:09:52 -04:00
Erik Johnson
2939eaec15 Clean up filehandle usage in file state tests
This does a few things:

1. Change calls to open() to use salt.utils.fopen()

2. Use with blocks where applicable
2014-07-14 21:23:06 -05:00
Erik Johnson
f847bae5a2 Add tests for templating local files 2014-07-14 21:23:06 -05:00
Mike Place
a08849c270 Remove old-style env= tests. 2014-07-14 11:03:03 -06:00
Pedro Algarvio
5283fa661e Adapt tests to behaviour introduced in #13333 2014-06-10 03:00:19 +01:00
Pedro Algarvio
0b6776ad81 Maintain old test behaviour(no new lines added) 2014-06-10 02:32:22 +01:00
Pedro Algarvio
df3e06ddd7 Test needs root perms 2014-06-10 01:56:24 +01:00
Pedro Algarvio
c6aa49c325 Fix PEP8 E713 - test for membership should be "not in" 2014-06-06 11:26:40 +01:00
Pedro Algarvio
7bd8b1360f Remove remaining exsel code 2014-05-29 01:32:54 +01:00
Thomas S Hatch
b20462ad3f Merge pull request #13037 from terminalmage/npm-test
add test for npm.installed/removed
2014-05-27 10:11:27 -06:00
Pedro Algarvio
4d7ca91424 Remove unnecessary ©️ and :license: from file headers 2014-05-26 19:26:15 +01:00
Erik Johnson
da0546c6f4 add test for npm.installed/removed 2014-05-26 06:19:49 -05:00
Pedro Algarvio
5a8575dbb9 The helper method is now released 2014-05-20 10:53:47 +01:00
Pedro Algarvio
e096df9016 Replace string substitution with string formatting 2014-05-01 13:29:38 +01:00
Erik Johnson
b78e558296 Remove unnecessary except 2014-04-25 18:00:04 -05:00
Erik Johnson
cb81b69abc Fix import 2014-04-25 17:58:41 -05:00
Erik Johnson
bffb9b5d43 Add skipIf and destructiveTest
These tests must be run as root, and create and destroy a user and
group, so this adds the proper decorators.

Additionally, this wraps the assertions from these tests in a try/except
block that ensures that the temp directory created for this test is
cleaned up.
2014-04-25 17:17:34 -05:00
Erik Johnson
d9fa7c5203 Use new decorators for issue 12209 tests 2014-04-25 17:17:34 -05:00
Erik Johnson
8574d9a19e Use custom user/group for integration tests for #12209
Not all platforms have a "nobody" user, this commit changes these tests
to use a "test12209" user/group for these tests.
2014-04-25 17:17:34 -05:00
Erik Johnson
f73a193c6b Add tests for #12209 2014-04-25 17:17:33 -05:00
Erik Johnson
ad53983a16 Fix refs to with_system_account decorator
This renames this decorator to with_system_user, to go along with
changes in https://github.com/saltstack/salt-testing/pull/14.
2014-04-25 14:03:41 -05:00
Mike Place
637c372aae Fix bug with mod_watch in supervisor modules
* Also adds __virtual__ support to supervisord exec module

* Closes #6692

Remove uneeded module.

Don't run supervisord tests without supervisord

Fix state test.

Pulled in an old pylint breakage.

Conflicts:
	salt/modules/saltutil.py
2014-04-23 16:14:12 -06:00
Mike Place
9ac6e8e150 Remove test.
Also pass makedirs correctly.
2014-04-21 10:30:27 -06:00
Mike Place
f717aa6004 Write test for ownership of file.managed with makedirs=True 2014-04-17 15:36:08 -06:00
Thomas S Hatch
09769d6fa2 lint tests 2014-04-02 11:16:24 -06:00
Pedro Algarvio
6f1337b4c8 Remove extra white-space 2014-03-29 13:20:47 +00:00
Pedro Algarvio
596b38e494 Provide env to templates.
Map `env` to the same value of `saltenv` in the templating context until
`env` is fully deprecated in favor of `saltenv`.

Fixes #11480.
2014-03-29 13:03:36 +00:00
Thomas S Hatch
43de620730 Merge pull request #11413 from s0undt3ch/hotfix/immutable-lists-sum
Simpler immutable types
2014-03-21 11:40:09 -06:00
C. R. Oldham
6c60f17751 Add two tests for checking file permissions when file is already existing 2014-03-17 14:25:17 -06:00
Erik Johnson
37bf8ee768 Change package used for opensuse integration pkg tests 2014-03-14 11:50:32 -05:00
Colton Myers
ea800935d7 Switch git clones to saltstack/salt-test-repo (super small repo)
Was previously cloning bootstrap a few times, and our salt repo once
(which is a large repo).  Should speed up the git tests substantially.
2014-03-14 09:45:17 -06:00
Pedro Algarvio
2f3d7bd6cc Merge branch 'develop' of github.com:saltstack/salt into hotfix/immutable-lists-sum 2014-03-13 16:03:50 +00:00
Mathieu Le Marec - Pasquet
ab0b465d3e Yet another fix for ImmutableProxyList
This is related to #11088, #11035, #11003, #11190.
2014-03-13 10:53:55 +01:00
Pedro Algarvio
e1c33dcad6 Revert "Stop running the test while it's failing"
This reverts commit a084303c91.
2014-03-12 21:52:08 +00:00
Pedro Algarvio
a084303c91 Stop running the test while it's failing 2014-03-10 23:52:38 +00:00
Pedro Algarvio
fd1bab0d8d Add test case which triggers #11003. 2014-03-10 17:47:22 +00:00
Erik Johnson
98bcd26139 Fix pkg test with dots in filename
The package here is much smaller and should install quicker than the old
one.
2014-02-11 11:22:34 -06:00
Thomas S Hatch
8ce74e0378 disable dot test, need to find another package 2014-02-11 09:41:10 -07:00
Pedro Algarvio
3fceb028eb Ignore and remove unused imports 2014-02-08 07:46:50 +00:00
Pedro Algarvio
fd306ea0b0 We need a bigger timeout, salt's repo is pretty big now. 2014-02-08 03:07:30 +00:00
Pedro Algarvio
b66418e263 Provide tests cases for #10197 and #10198 2014-02-05 21:56:08 +00:00
Thomas S Hatch
94a6b01522 Merge pull request #10011 from makinacorpus/fix10010
display full jinja traceback when applicable
2014-01-29 07:41:29 -08:00
Mathieu Le Marec - Pasquet
688abda402 display full jinja traceback when applicable
This fixes #10010
2014-01-29 02:04:12 +01:00
Mathieu Le Marec - Pasquet
165b5e4af2 Handle better state errors
This fixes #9983.
2014-01-28 16:01:34 +01:00
FELD Boris
43889c7d79 Add a test for git states support of numeric revision 2014-01-15 17:20:08 +01:00
Pedro Algarvio
106c44587e Merge pull request #9701 from s0undt3ch/hotfix/ssh-binaries
Skip the tests if binaries are missing.
2014-01-11 14:47:14 -08:00
Pedro Algarvio
2bb11d24b9 Skip the tests if binaries are missing. 2014-01-11 14:38:17 -07:00
Pedro Algarvio
c8038d87b1 Use KNOWN_BINARY_NAMES from salt.modules.virtualenv 2014-01-11 12:19:29 -07:00
Thomas S Hatch
b90b4a0db8 Set tests to refresh fs list cace with every check 2014-01-09 15:10:42 -07:00
Pedro Algarvio
2cab3227fd The virtualenv binary can have multiple CLI names. 2014-01-02 20:27:18 +00:00
Mike Place
ca57a864b8 Increase timeout for pkg tests.
* Since we started running a refresh_db in pkgrepo (7c3d0cc80d), we may be checking an exit code prematurely. This increases the timeouts to 120 seconds to see if Jenkins will calm itself.
2013-12-30 11:08:32 -07:00
Pedro Algarvio
27a32c5849 Catch the proper exception. White-space fixes. 2013-12-13 08:12:00 +00:00
Thomas S Hatch
781bfe2455 remove reduntant faulty test 2013-12-12 15:18:36 -07:00
Thomas S Hatch
7957455ff9 some pylint fixes for mysql tests 2013-12-12 14:56:45 -07:00
regilero
f1b6b4af55 MySQL tests: add a localhost target on mysqladmin test to check for MySQL server presence 2013-12-12 21:23:52 +01:00
regilero
9195f8e5f7 Lint fix 2013-12-11 14:40:42 +01:00
regilero
3b14cd7cb4 Merge remote-tracking branch 'upstream/develop' into mysql_additions 2013-12-11 00:56:56 +01:00
regilero
82c1cb8e64 MySQL states, grants integration tests 2013-12-11 00:54:05 +01:00
regilero
f980c64bc4 MySQL Module: remove use_unicode connection attribute, not needed for charset managment and would create new bugs with unicode() strings 2013-12-10 23:07:13 +01:00
Pedro Algarvio
2648ed90ba Fix lint issues. 2013-12-09 20:02:25 +00:00
Thomas S Hatch
8408c1a583 Merge pull request #9053 from regilero/utf8-sls
Proposal for utf-8 support in sls files
2013-12-09 10:41:15 -08:00
regilero
6c0b53547d MySQl: fix states integration tests 2013-12-08 17:10:37 +01:00
Erik Johnson
e618befaf8 Add test case for numeric GECOS data 2013-12-06 16:16:38 -06:00
regilero
3769474d9d One more test,to be sure 2013-12-05 18:50:31 +01:00
regilero
bd9a0394ae Integration tests for issue #8947 utf-8 in sls 2013-12-05 18:18:20 +01:00
regilero
b376d1a82b MySQL States integration module with db tests 2013-12-04 22:33:33 +01:00
Erik Johnson
093065b130 add test for #8614 2013-11-30 22:00:05 -06:00
Pedro Algarvio
8d3e3d3402 Skip the test if python-apt is not installed for Debian like systems. 2013-11-28 19:26:21 +00:00
Pedro Algarvio
d02a2bc224 Include the python encoding file header on tests. 2013-11-27 11:19:24 +00:00
Thomas S Hatch
eb9ba6fda0 Merge pull request #8756 from s0undt3ch/issues/8343-require_in-KeyError
Fix accomulator issues
2013-11-26 13:18:49 -08:00
Erik Johnson
05de056df0 Add an assert to ensure that the state.sls return dict isn't empty 2013-11-25 17:41:03 -06:00
Erik Johnson
1c9f2fc224 Remove grains requirement
I had this code here in an early draft of this test, but the grains are
no longer needed here as the stuff that requires grains has been moved
out of the test function and into the SLS files that are run by the
test.
2013-11-25 17:30:18 -06:00
Erik Johnson
a77357f01d Fix pkgrepo tests when python file is run by itself on CLI 2013-11-25 17:27:26 -06:00
Erik Johnson
c2e346835c Add pkgrepo tests for CentOS
Ubuntu ones will follow soon.
2013-11-25 17:20:32 -06:00
Pedro Algarvio
f0bf78cdc0 Correct the state test case and respective expected output. 2013-11-24 12:15:20 +00:00
Pedro Algarvio
a752421b87 Expose a copy of the state dictionary to state functions.
Fixes #8343 since `__sls__` is now available in `__state__` and not on `kwargs`.
Closes #8709 since it's not the right approach.
Fixes #8710 and closes #8711 since I've cherry-picked the fix for #8710 in from #8711.
2013-11-24 11:08:33 +00:00
Pedro Algarvio
54fc502de0 Some more saltenv related tests. 2013-11-12 06:29:55 +00:00
Pedro Algarvio
d88d34ca24 The GitHub IP changed. 2013-11-11 07:45:10 +00:00
Pedro Algarvio
77101231f2 Install a smaller and with less dependencies package. 2013-11-07 22:09:36 +00:00
Colton Myers
78662d270b Merge pull request #8325 from cachedout/#7860
Add a dir_mode to file.managed
2013-11-07 09:35:54 -08:00
Mike Place
2e6bf21635 Integration testing for file.managed dir_mode argument.
Added documentation for dir_mode to file.managed.
2013-11-07 10:19:16 -07:00
Pedro Algarvio
ec0a4bca8e URL environment selection should also be using saltenv. 2013-11-06 23:36:40 +00:00
Pedro Algarvio
962f8d4149 Support adding files to the testing prod state env. 2013-11-06 20:18:47 +00:00
Pedro Algarvio
c170d1e572 Updated test cases to include environment selection in states using __env__. 2013-11-06 20:04:54 +00:00
Henrik Holmboe
77fd1acb7f Change assertEquals to assertEqual
According to
http://docs.python.org/2/library/unittest.html#deprecated-aliases
assertEquals is a deprecated alias of assertEqual.
2013-10-24 11:39:04 +02:00
Erik Johnson
95efdad8ba Remove ubuntu 32-bit target 2013-10-20 21:47:05 -05:00
Erik Johnson
7984a8c2cf Apparently the test framework doesn't like private member functions 2013-10-20 21:46:06 -05:00