Commit Graph

8472 Commits

Author SHA1 Message Date
Denys Havrysh
d1ab98b459 cp.get_url: update usage doc and add tests for file:// URL with dest=None 2016-10-18 13:39:55 +03:00
twangboy
b3b688e298 Fix tests 2016-10-17 13:31:55 -06:00
Denys Havrysh
c7cf79e959 cp.get_url: add note and test for https:// URL with `dest=None` 2016-10-17 17:39:52 +03:00
Denys Havrysh
ff55f77179 cp.get_url: write more verbose docstring 2016-10-17 16:01:02 +03:00
Denys Havrysh
94a34a08ba cp.get_url: add integration tests 2016-10-17 15:46:49 +03:00
rallytime
112dc5d9c1 Merge branch '2016.3' into 'carbon'
Conflicts:
  - salt/cli/salt.py
  - salt/client/__init__.py
  - salt/modules/archive.py
  - tests/integration/modules/pkg.py
2016-10-14 12:03:08 -06:00
C. R. Oldham
c7595b84a7 Merge pull request #36981 from rallytime/upgrades-test-fix
Skip pkg.upgrades test on distros other that Suse in 2016.3
2016-10-13 15:29:36 -06:00
C. R. Oldham
0b11f05d07 Merge pull request #36980 from rallytime/fedora-upgrades-test-fix
Skip pkg.upgrade test if pkg install/upgrade has problems
2016-10-13 15:29:29 -06:00
Thomas S Hatch
6b782c15e1 Merge pull request #36755 from terminalmage/issue36671
systemd.py: check retcode for service availability in systemd >= 231
2016-10-13 13:41:50 -06:00
rallytime
a5ae737057 Skip pkg.upgrades test on distros other that Suse in 2016.3
Refs #36450 and #36980
2016-10-13 12:02:22 -06:00
rallytime
21921af9a7 Skip pkg.upgrade test if pkg install/upgrade has problems
Refs #36450
2016-10-13 11:57:27 -06:00
rallytime
1e7f56c4bb Merge branch '2016.3' into 'carbon'
No conflicts.
2016-10-13 10:38:19 -06:00
Nicole Thomas
a8eee6e90b Update the ip to test against in unit.utils.network_test.NetworkTestCase.test_host_to_ip (#36975) 2016-10-13 10:25:58 -06:00
Nicole Thomas
3ac9ced202 Merge pull request #36241 from hrumph/cert_problem
Fixes #36240
2016-10-12 17:28:35 -06:00
rallytime
1d3aaf8097 Merge branch '2016.3' into 'carbon'
Conflicts:
  - doc/ref/configuration/minion.rst
2016-10-12 15:26:27 -06:00
Andrew Pashkin
337119c113 Fix integration tests launching - remove redundant "config_dir" argument in call to ShellTestCase.run_run from SaltDaemonScriptBase._wait_until_running 2016-10-12 13:21:40 -06:00
rallytime
32846794c8 Update mocks for failing tests in win_certutil_test 2016-10-12 11:31:58 -06:00
Justin Findlay
4d8fb03b79 return opennebula errors to user (#36930)
* cloud.clouds.opennebula: return errors to user

* cloud.clouds.opennebula._get_xml: add unit test
2016-10-12 10:19:11 -06:00
rallytime
32829b9474 [yumpkg] Skip test_pkg_upgrade_has_pending_upgrades if there are no upgrades
yumpkg.list_upgrades returns an empty dictionary when no upgrades are available.
We need to check for this situation and skip the test if no upgrades are present.

Fixes the test failure on Fedora 24 on Jenkins currently, but also protects against
any potential failures for other RHEL-based distros that aren't currently failing
because "ret" is populated with a dictionary of upgrades.
2016-10-11 16:50:50 -06:00
Erik Johnson
e5425f3e8c Revert change in default value for top_file_merging_strategy (#36922)
This causes problems when a Carbon master tries to run states on a
non-Carbon minion.
2016-10-11 16:33:23 -06:00
rallytime
b196c9336a Merge branch '2016.3' into 'carbon'
No conflicts.
2016-10-11 13:54:09 -06:00
Thomas S Hatch
7e2eba9cc7 Merge pull request #36776 from cro/prox_min_mgr
Adapt MinionManager for Proxy Minions.
2016-10-11 11:12:01 -06:00
rallytime
c09b9d6e6a Merge branch '2015.8' into '2016.3'
No conflicts.
2016-10-10 10:21:04 -06:00
Erik Johnson
7c78d6f419 Add unit tests for systemd scope usage 2016-10-07 17:35:09 -05:00
rallytime
2e34277b65 Add '--no-psqlrc' option to new-to-carbon postgres unit test 2016-10-07 16:10:57 -06:00
rallytime
f73bdf55c2 Merge branch '2016.3' into 'carbon'
Conflicts:
  - salt/cloud/clouds/vultrpy.py
  - salt/modules/ini_manage.py
  - salt/states/glance.py
2016-10-07 09:51:21 -06:00
C. R. Oldham
b7f9eb7864 Fix test. 2016-10-06 14:20:29 -06:00
Mike Place
1284de27fc Merge pull request #36789 from maximeguillet/fix-psqlrc-pg9.6
Fix behavior of psql -c option with postgresql 9.6
2016-10-06 20:24:51 +09:00
Maxime Guillet
b59c23bef1 Fix one remaining postgresql tests linked to #36787. 2016-10-05 17:05:10 +02:00
Maxime Guillet
8b92ae2061 Fix postgresql tests using position in the argument list of psql.
Some tests use position number in the argument list of psql command
to check their results. As #36787 add one element, next position
in the list must be used.
2016-10-05 16:08:42 +02:00
Maxime Guillet
21f2a17a07 Fix postgresql tests by adding --no-psqlrc option introduced by #36787. 2016-10-05 14:43:02 +02:00
Mike Place
4bdb997dae Merge pull request #36785 from cachedout/pr-36728
Fixup merge forward #36728
2016-10-05 20:02:16 +09:00
Mike Place
bd712bb0ff
Fix test suite hanging on shutdown 2016-10-05 17:14:27 +09:00
Erik Johnson
d916c2b49c Handle cases where retcode/output feature is backported
This will handle the case of RHEL 7.3, which maintains an older version
of systemd with the retcode/output changes from "systemctl status" in
systemd 231 backported.
2016-10-04 09:55:56 -05:00
Mike Place
8ff69bf0c7 Merge pull request #36764 from cachedout/more_pip_test_fixing
Another bit of detection for failed pip tests
2016-10-04 22:05:29 +09:00
Mike Place
b9f5343449
Another bit of detection for failed pip tests
Don't bail out if the download failed for some reason on the remote end
2016-10-04 21:09:47 +09:00
Erik Johnson
b3364646ad Update systemd module unit tests
The _systemctl_status() function has changed its return data, this
commit updates the affected tests to reflect this.
2016-10-03 22:51:43 -05:00
Justin Findlay
b5fcca9983 modules.archive int tests: check for gzip, rar
Similar to 8733586.
2016-10-03 11:14:05 -06:00
Mike Place
93f1daa4ce Merge pull request #36744 from cachedout/fix_test_shutdown
Fix issue where test suite could hang on shutdown
2016-10-04 00:37:00 +09:00
Mike Place
cdf2a56564
Fix issue where test suite could hang on shutdown
This is most common in the develop branch but could occur here as well.
2016-10-03 23:37:05 +09:00
C. R. Oldham
e6897da166 Skip test if we can't get an earlier package. 2016-09-30 17:30:21 -06:00
C. R. Oldham
8e68058877 Handle cases where the return dict from a pkg.upgrade might have a "changes" key. 2016-09-30 16:33:56 -06:00
rallytime
24b8bba145 Merge branch '2015.8' into '2016.3'
No conflicts.
2016-09-30 16:13:08 -06:00
rallytime
5904cc04c6 Skip cmd_unzip test if salt.utils.which('zip') isn't available
This test relies on running archive.cmd_zip in order to have something
to test running archive.cmd_unzip against. Some distros will have the
unzip binary available, but not the zip binary. We need to protect this
test against both so we don't have a false failure on trying to run
archive.cmd_zip.
2016-09-30 16:02:42 -06:00
Nicole Thomas
52276d37a1 Skip cmd_unzip test if salt.utils.which('zip') isn't available (#36722)
This test relies on running archive.cmd_zip in order to have something
to test running archive.cmd_unzip against. Some distros will have the
unzip binary available, but not the zip binary. We need to protect this
test against both so we don't have a false failure on trying to run
archive.cmd_zip.
2016-09-30 14:30:09 -06:00
rallytime
555ae9aa9b Merge branch '2016.3' into 'carbon'
No conflicts.
2016-09-30 10:13:39 -06:00
Mike Place
16f5bb70ec
Remove line that checks against unordered keys 2016-09-30 20:24:49 +09:00
Mike Place
0e9148293a
Fix error in test
Introduced in #36616

cc: @cro
2016-09-30 11:38:03 +09:00
rallytime
616aafa398 Merge branch '2016.3' into 'carbon'
No conflicts.
2016-09-29 11:47:48 -06:00
rallytime
7a03c4df8c Fix merge conflict resolution error
The original conflict resolution adjusted the wrong line. This puts
the test changes on the correct line and restores the original line.
2016-09-29 11:26:50 -06:00
rallytime
6bc3221f7b Update test to not use the nested context (for Py3 compat) 2016-09-29 11:25:46 -06:00
rallytime
112903ad7e Merge branch '2016.3' into 'carbon'
Conflicts:
  - conf/master
  - doc/ref/configuration/master.rst
  - salt/cli/daemons.py
  - salt/client/ssh/__init__.py
  - salt/config/__init__.py
  - salt/modules/archive.py
  - salt/modules/cmdmod.py
  - tests/unit/states/service_test.py
2016-09-29 09:56:43 -06:00
rallytime
3e4ac617d3 Merge branch '2015.8' into '2016.3'
Conflicts:
  - tests/integration/cli/grains.py
  - tests/integration/files/file/base/issue-2068-template-str-no-dot.sls
  - tests/integration/files/file/base/issue-2068-template-str.sls
  - tests/integration/modules/pip.py
2016-09-29 09:15:26 -06:00
Denys Havrysh
bba9d0d105 alternatives.install state: detect alternatives command failed 2016-09-29 18:09:16 +03:00
Mike Place
3d098c64ef
Remove possible race between grains dumps in test
It's not always reasonable assume that grains will be the same byte-for-byte
between invocations. Remove that assumption since it isn't related to the what's under test here anyhow.
2016-09-29 15:34:50 +09:00
Mike Place
8cfe371a5a Merge pull request #36663 from cachedout/skip_pip_tests_on_download_fail
Fix error in pip test
2016-09-29 15:15:52 +09:00
Mike Place
0c7fb91dc5
Fix error 2016-09-29 15:14:37 +09:00
Mike Place
e3f8618982 Merge pull request #36662 from cachedout/skip_pip_tests_on_download_fail
Skip over tests where upstream pip isn't there
2016-09-29 15:12:26 +09:00
Mike Place
0bbc60ccd7
Skip over tests where upstream pip isn't there 2016-09-29 15:11:38 +09:00
Mike Place
3249a11e71 Merge pull request #36661 from cachedout/fix_grain_test_race
Fix race between minion job timeout and cli test timeout
2016-09-29 13:42:23 +09:00
Mike Place
2dcb92134d
Fix race between minion job timeout and cli test timeout 2016-09-29 13:23:26 +09:00
Mike Place
f4906fe771
Fix test not to rely on external resources
We can still model the original issue without needing to call all the way out to pypi to do it.
2016-09-29 12:35:02 +09:00
Mike Place
d8a61eb9f6 Merge pull request #36616 from cro/zypper_fix_test
Zypper fix test
2016-09-29 11:26:22 +09:00
Mike Place
ccd92d22d2 Merge pull request #36621 from terminalmage/fix-shadowed-builtins
Fix shadowed builtins
2016-09-29 11:25:54 +09:00
Justin Findlay
cc4d958557 modules.archive: add integration tests 2016-09-28 17:14:52 -06:00
C. R. Oldham
b618a5c07d Remove debugging 2016-09-28 16:26:56 -06:00
Justin Findlay
74c518668b tests.integration.__init__: except psutil error
Related to d0f44c9.
2016-09-28 15:58:33 -06:00
Erik Johnson
62729eff8d Update tests to include fix for renamed function 2016-09-28 11:00:33 -05:00
Mike Place
83da81cdfd Merge pull request #36620 from rallytime/fix-36553
Don't allow mercurial states to return True with errors
2016-09-28 14:50:50 +09:00
Erik Johnson
283aca8f2a Update test to reflect new function signature 2016-09-27 23:13:19 -05:00
rallytime
90c66ef756 Merge branch '2015.8' into '2016.3'
Conflicts:
  - salt/modules/aptpkg.py
  - salt/states/service.py
2016-09-27 21:34:10 -06:00
rallytime
a828bdd0b8 Update test mocks for cmd.run_all dicts 2016-09-27 20:55:39 -06:00
Mike Place
4ab52ae0f6 Merge pull request #36607 from vutny/detect-service-fail
`salt.states.service`: detect that service failed to start/stop
2016-09-28 11:39:51 +09:00
C. R. Oldham
3870589462 Test for pkg.upgrade. Most robust on Suse but better than nothing elsewhere 2016-09-27 14:50:44 -06:00
C. R. Oldham
867638ff48 Test for pkg.upgrade. Most robust on Suse but better than nothing elsewhere 2016-09-27 14:49:23 -06:00
Jonathan Ballet
79fdc12395 jinja: fix YAML terminator removal in Jinja's "yaml" filter 2016-09-27 18:52:49 +02:00
Denys Havrysh
c4f899b3b3 salt.states.service: detect that service failed to start/stop 2016-09-27 18:24:37 +03:00
Mike Place
7b43d4322c
Merge branch '2016.3' into 2016_3_carbon 2016-09-27 16:44:42 +09:00
Mike Place
3a83b0bd16
Remove tests which no longer apply
The point of these tests originally was to verify the proper location
of a log file. Checking return codes is just spurious and ties the test
too closely with the shutdown behavior of the daemons which are tracked and tested
in other places more closely and with more accuracy.
2016-09-27 16:36:24 +09:00
rallytime
d5bbd91c14 Merge branch '2016.3' into 'carbon'
Conflicts:
  - conf/master
2016-09-23 17:01:17 -06:00
rallytime
861a001749 Merge branch '2015.8' into '2016.3'
No conflicts.
2016-09-23 15:06:28 -06:00
Nicole Thomas
07c9d040c0 Fixup the rabbitmq_user state test failure (#36541) 2016-09-23 15:05:40 -06:00
Nicole Thomas
fcc50c93fc Wrap the entire GrainsAppendTestCase class with destructiveTest (#36537)
Since all pieces of the GrainsAppendTestCase are destructive, let's
just wrap the whole class test case.

Because the tests themselves as well as the `tearDown` function were
wrapped in a @destructiveTest decorator, some test errors were printing
in the test output when --run-destructive isn't passed at the CLI.

This fixes those test errors.
2016-09-23 13:35:05 -06:00
rallytime
d0ec4ead2a Merge branch '2016.3' into 'carbon'
No conflicts.
2016-09-23 08:32:17 -06:00
Mike Place
654fa8d770 Merge pull request #36280 from jwplayer/feature/2016.3-better-postgresql-grants
Feature/2016.3 better postgresql grants
2016-09-23 16:55:32 +09:00
rallytime
1755f22de1 Merge branch '2016.3' into 'carbon'
No conflicts.
2016-09-22 10:01:17 -06:00
Mike Place
90ef5ce499 Merge pull request #36492 from rallytime/test-fixes-carbon
The "assert_called_once" mock testing function is only available in mock 2.0.0 or greater
2016-09-23 00:56:59 +09:00
Mike Place
761ee8b3f6 Merge pull request #36476 from cro/vmware_fix2
Allow VMware salt-cloud driver to list objects again
2016-09-22 13:16:40 +09:00
Mike Place
9d032e0a1b Merge pull request #36481 from terminalmage/fix-mac-non-string-arg-handling
Fix mac non-string arg handling
2016-09-22 13:14:18 +09:00
Mike Place
85907ef008 Merge pull request #36485 from gtmanfred/carbon
clean up keystone tests
2016-09-22 13:12:36 +09:00
C. R. Oldham
755c069fb9 Align tests for new calls 2016-09-21 16:08:28 -06:00
rallytime
18c6a736cf The "assert_called_once" mock testing function is only available in mock 2.0.0 or greater
We have a couple of tests using the "assert_called_once" function, however, our salt-jenkins
states pin the version of mock at 1.0.1 (This is the last version that is compatible with
Python 2.6). We either need to use something else that works for all versions of mock or gate
the test.

In the pacman tests, it is possible to use "assert_called_with" instead of "assert_called_once"

In the dimension_data and gce unit tests, we need to gate the assertion behind a mock version check.
This way the tests won't fail if the version of mock installed is less than 2.0.0.
2016-09-21 14:46:50 -06:00
Daniel Wallace
8deb342488 clean up keystone tests
Don't want to overwrite the stuff for the glance tests
2016-09-21 14:43:42 -05:00
Erik Johnson
1c585b0ef6 Leave arguments as integers
This should be supported, and helped catch a bug in the extraneous
re-implementation of cmd.run_all that exists in salt.utils.mac_utils.
2016-09-21 11:46:54 -05:00
rallytime
77f8120395 Merge branch '2016.3' into 'carbon'
Conflicts:
  - doc/topics/installation/windows.rst
  - salt/engines/sqs_events.py
  - salt/grains/core.py
2016-09-21 10:43:38 -06:00
C. R. Oldham
3c62ceb3b4 Fix salt-cloud breakage--local traversal was skipping what we needed. Fixes #36301
Align tests for new calls
More specific 'skip' selection for PropertyCollector depending on local_properties request.
2016-09-21 09:43:14 -06:00
rallytime
8805b57a1e Merge branch '2015.8' into '2016.3'
No conflicts.
2016-09-21 09:32:53 -06:00
Mike Place
41d3c09857 Merge pull request #35433 from terminalmage/issue34790
git.latest: Add a hint for possible rev changes resulting in non-fast-forward failures
2016-09-21 16:02:18 +09:00
Mike Place
3d23371ca2 Merge pull request #36459 from cachedout/pr-36426
Pr 36426
2016-09-21 15:34:28 +09:00
Mike Place
a41022efc3 Merge pull request #36447 from jfindlay/bp-36431
Backport #36431: Try/except psutil process access in OSX
2016-09-21 14:52:39 +09:00