As also noted in https://github.com/saltstack/salt/issues/33266, sometimes `dmidecode` will output additional commentary text in strings:
```
root@n01:~# dmidecode -s system-manufacturer
# SMBIOS implementations newer than version 2.8 are not
# fully supported by this version of dmidecode.
Supermicro
```
This PR filters those out.
Function is expecting two arguments. But after processing state only one
parameter (it contain two words) is pushed into list of options.
This patch reverts the parsing of "iptables --match-set" to the
behaviour of salt v2014.*.
This is a backport of https://github.com/saltstack/salt/pull/28325Closes#23643
As also noted in https://github.com/saltstack/salt/issues/33266, sometimes `dmidecode` will output additional commentary text in strings:
```
root@n01:~# dmidecode -s system-manufacturer
# SMBIOS implementations newer than version 2.8 are not
# fully supported by this version of dmidecode.
Supermicro
```
This PR filters those out.
* Added support for the agentv2
* Updated os field to match the SD API requirement
* filename is an absolute path on official installations
* Install script URL uses a redirect now, so we should instruct curl to follow them
* Added a missing import
* Updated the settings for the v2 agent
* Fixed pep8 issues
* select v2 agent for the test
Function is expecting two arguments. But after processing state only one
parameter (it contain two words) is pushed into list of options.
This patch reverts the parsing of "iptables --match-set" to the behaviour
of salt v2014.*.
This is a backport of https://github.com/saltstack/salt/pull/28325Closes#23643
* Pass an actual error message when raising exception
* debian_service.py: ignore retcode when checking service's status
This prevents spurious errors from being logged when a nonexistant
service is polled, or the service is not running.
* freebsdservice.py: ignore retcode when checking service's status
This prevents spurious errors from being logged when a nonexistant
service is polled, or the service is not running.
* netbsdservice.py: ignore retcode when checking service's status
This prevents spurious errors from being logged when a nonexistant
service is polled, or the service is not running.
* openbsdservice.py: ignore retcode when checking service's status
This prevents spurious errors from being logged when a nonexistant
service is polled, or the service is not running.
* Fix context clash.
boto_vpc uses both boto and boto3. Both utils for those use the same name for their connection context. If you used states that required both boto and boto3, the get_conn would return the object.
* Add a unit test to the boto context conflict problem
* Fix pylint errors and ensure new test to runs correctly
Merges #32985
* Fix typo
Docs were added for:
- master_tries
- mine_enabled
- mine_return_job
- syndic_failover
- auth_tries: this is an old setting, but docs were not found
in the minion.rst docs. This change should be added to older branches.
* better support for named images, locations, sizes
* better support for named images, locations, sizes
* Tests for Vultr driver
* Add sleep so test instance will be old enough to delete as part of the test
* Lint.
The SSH_PASSWORD_PROMPT_RE regexp used to detect if SSH is requesting a
password can be triggered if the shim is returning data to the server
with text that matches the regex, including inside JSON results. This
then results in the server unable to parse the JSON results. This
patch fixes this issue by looking for the shim delimiter in the output and
disabling the sending of passwords after the delimiter is found.
Fixes#29422.
* fix UnboundLocalError in 'container_resource.run' (issue #33267)
This happends when VT could not be created.
Because `proc` must exist in the `finally` block, we put it outside
the `try` block and let the code fails when the vt creation fails.
* fix UnboundLocalError in lxc runner (issue #30864)
`saved_kwargs` seems only useful inside the ``if saltcloud_mode:``
block. This name can not be called outside the block where it is
created.
* modules.postgres: fix handling of empty string in db_create
The code responsible for collecting the parameters used in the CREATE
DATABASE query works unexpectedly in case for values which are evaluated
to False as bool, but are not None.
This caused queries with missing rvalues like this one (lc_collate=""):
2016-05-13 16:04:05,243 [salt.loaded.int.module.cmdmod][ERROR ][2990]
stderr: ERROR: syntax error at or near "OWNER"
LINE 1: ..._production" WITH ENCODING = 'utf8' LC_COLLATE = OWNER =
"g...
Please note that proper escaping or a different approach would be needed
here.
* modules.postgres: handle trivial sqli in db_create
* modules.postgres: fix OrderedDict usage
* modules.postgres: quote TABLESPACE too in db_create
