From eb91af999ea84d6a4147ef3bcf0d1b3b25e7d49e Mon Sep 17 00:00:00 2001
From: rallytime <nicole@saltstack.com>
Date: Thu, 16 Nov 2017 15:36:53 -0500
Subject: [PATCH] Remove logging from top of napalm util file

Logging should not be done anywhere in a file before a module is
loaded. This includes the `__virtual__()` function as well. This
is because these messages will be logged on every call to the loader,
which muddies the logs when the function(s) being called do not
need to use that particular module.
---
 salt/utils/napalm.py | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/salt/utils/napalm.py b/salt/utils/napalm.py
index 0608589a6a..1f560fd280 100644
--- a/salt/utils/napalm.py
+++ b/salt/utils/napalm.py
@@ -15,18 +15,19 @@ Utils for the NAPALM modules and proxy.
 .. versionadded:: 2017.7.0
 '''
 
+# Import Python libs
 from __future__ import absolute_import
-
 import traceback
 import logging
 import importlib
 from functools import wraps
-log = logging.getLogger(__file__)
 
-import salt.utils
+# Import Salt libs
+from salt.ext import six as six
 import salt.output
+import salt.utils
 
-# Import third party lib
+# Import third party libs
 try:
     # will try to import NAPALM
     # https://github.com/napalm-automation/napalm
@@ -36,21 +37,16 @@ try:
     # pylint: enable=W0611
     HAS_NAPALM = True
     HAS_NAPALM_BASE = False  # doesn't matter anymore, but needed for the logic below
-    log.debug('napalm seems to be installed')
     try:
         NAPALM_MAJOR = int(napalm.__version__.split('.')[0])
-        log.debug('napalm version: %s', napalm.__version__)
     except AttributeError:
         NAPALM_MAJOR = 0
 except ImportError:
-    log.info('napalm doesnt seem to be installed, trying to import napalm_base')
     HAS_NAPALM = False
     try:
         import napalm_base
-        log.debug('napalm_base seems to be installed')
         HAS_NAPALM_BASE = True
     except ImportError:
-        log.info('napalm_base doesnt seem to be installed either')
         HAS_NAPALM_BASE = False
 
 try:
@@ -62,7 +58,7 @@ try:
 except ImportError:
     HAS_CONN_CLOSED_EXC_CLASS = False
 
-from salt.ext import six as six
+log = logging.getLogger(__file__)
 
 
 def is_proxy(opts):
@@ -98,8 +94,6 @@ def virtual(opts, virtualname, filename):
     Returns the __virtual__.
     '''
     if ((HAS_NAPALM and NAPALM_MAJOR >= 2) or HAS_NAPALM_BASE) and (is_proxy(opts) or is_minion(opts)):
-        if HAS_NAPALM_BASE:
-            log.info('You still seem to use napalm_base. Please consider upgrading to napalm >= 2.0.0')
         return virtualname
     else:
         return (