Added some unit tests for GCE and Dimension Data modules

salt/cloud/clouds/dimensiondata.py

@@ -89,7 +89,7 @@ __virtualname__ = 'dimensiondata'
 
 def __virtual__():
     '''
-    Set up the libcloud functions and check for GCE configurations.
+    Set up the libcloud functions and check for dimensiondata configurations.
     '''
     if get_configured_provider() is False:
         return False

tests/unit/cloud/clouds/dimensiondata_test.py

@@ -0,0 +1,150 @@
+# -*- coding: utf-8 -*-
+'''
+    :codeauthor: `Anthony Shaw <anthonyshaw@apache.org>`
+
+    tests.unit.cloud.clouds.dimensiondata_test
+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+'''
+
+# Import Python libs
+from __future__ import absolute_import
+
+# Import Salt Libs
+from salt.cloud.clouds import dimensiondata
+from salt.exceptions import SaltCloudSystemExit
+
+# Import Salt Testing Libs
+from salttesting import TestCase, skipIf
+from salttesting.mock import MagicMock, NO_MOCK, NO_MOCK_REASON, patch
+from salttesting.helpers import ensure_in_syspath
+
+ensure_in_syspath('../../../')
+
+# Global Variables
+dimensiondata.__active_provider_name__ = ''
+dimensiondata.__opts__ = {
+    'providers': {
+        'my-dimensiondata-cloud': {
+            'dimensiondata': {
+                'driver': 'dimensiondata',
+                'region': 'dd-au',
+                'user_id': 'jon_snow',
+                'key': 'IKnowNothing'
+            }
+        }
+    }
+}
+VM_NAME = 'winterfell'
+
+
+class ExtendedTestCase(TestCase):
+    '''
+    Extended TestCase class containing additional helper methods.
+    '''
+
+    def assertRaisesWithMessage(self, exc_type, exc_msg, func, *args, **kwargs):
+        try:
+            func(*args, **kwargs)
+            self.assertFail()
+        except Exception as exc:
+            self.assertEqual(type(exc), exc_type)
+            self.assertEqual(exc.message, exc_msg)
+
+
+@skipIf(NO_MOCK, NO_MOCK_REASON)
+@patch('salt.cloud.clouds.dimensiondata.__virtual__', MagicMock(return_value='dimensiondata'))
+class DimensionDataTestCase(ExtendedTestCase):
+    '''
+    Unit TestCase for salt.cloud.clouds.dimensiondata module.
+    '''
+
+    def test_avail_images_call(self):
+        '''
+        Tests that a SaltCloudSystemExit is raised when trying to call avail_images
+        with --action or -a.
+        '''
+        self.assertRaises(
+            SaltCloudSystemExit,
+            dimensiondata.avail_images,
+            call='action'
+        )
+
+    def test_avail_locations_call(self):
+        '''
+        Tests that a SaltCloudSystemExit is raised when trying to call avail_locations
+        with --action or -a.
+        '''
+        self.assertRaises(
+            SaltCloudSystemExit,
+            dimensiondata.avail_locations,
+            call='action'
+        )
+
+    def test_avail_sizes_call(self):
+        '''
+        Tests that a SaltCloudSystemExit is raised when trying to call avail_sizes
+        with --action or -a.
+        '''
+        self.assertRaises(
+            SaltCloudSystemExit,
+            dimensiondata.avail_sizes,
+            call='action'
+        )
+
+    def test_list_nodes_call(self):
+        '''
+        Tests that a SaltCloudSystemExit is raised when trying to call list_nodes
+        with --action or -a.
+        '''
+        self.assertRaises(
+            SaltCloudSystemExit,
+            dimensiondata.list_nodes,
+            call='action'
+        )
+
+    def test_destroy_call(self):
+        '''
+        Tests that a SaltCloudSystemExit is raised when trying to call destroy
+        with --function or -f.
+        '''
+        self.assertRaises(
+            SaltCloudSystemExit,
+            dimensiondata.destroy,
+            name=VM_NAME,
+            call='function'
+        )
+
+    def test_avail_sizes(self):
+        '''
+        Tests that avail_sizes returns an empty dictionary.
+        '''
+        sizes = dimensiondata.avail_sizes(call='foo')
+        self.assertEqual(
+            len(sizes),
+            1
+        )
+        self.assertEqual(
+            sizes['default']['name'],
+            'default'
+        )
+
+    @patch('libcloud.compute.drivers.dimensiondata.DimensionDataNodeDriver.list_nodes', MagicMock(return_value=[]))
+    def test_list_nodes(self):
+        nodes = dimensiondata.list_nodes()
+        self.assertEqual(
+            nodes,
+            {}
+        )
+
+    @patch('libcloud.compute.drivers.dimensiondata.DimensionDataNodeDriver.list_locations', MagicMock(return_value=[]))
+    def test_list_locations(self):
+        locations = dimensiondata.avail_locations()
+        self.assertEqual(
+            locations,
+            {}
+        )
+
+
+if __name__ == '__main__':
+    from integration import run_tests
+    run_tests(DimensionDataTestCase, needs_daemon=False)

tests/unit/cloud/clouds/gce_test.py

@@ -0,0 +1,113 @@
+# -*- coding: utf-8 -*-
+'''
+    :codeauthor: `Anthony Shaw <anthonyshaw@apache.org>`
+
+    tests.unit.cloud.clouds.gce_test
+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+'''
+
+# Import Python libs
+from __future__ import absolute_import
+
+# Import Salt Libs
+from salt.cloud.clouds import gce
+from salt.exceptions import SaltCloudSystemExit
+
+# Import Salt Testing Libs
+from salttesting import TestCase, skipIf
+from salttesting.mock import MagicMock, NO_MOCK, NO_MOCK_REASON, patch
+from salttesting.helpers import ensure_in_syspath
+
+ensure_in_syspath('../../../')
+
+# Global Variables
+gce.__active_provider_name__ = ''
+gce.__opts__ = {
+    'providers': {
+        'my-google-cloud': {
+            'gce': {
+                'project': 'daenerys-cloud',
+                'service_account_email_address': 'dany@targaryen.westeros.cloud',
+                'service_account_private_key': '/home/dany/PRIVKEY.pem',
+                'driver': 'gce',
+                'ssh_interface': 'public_ips'
+            }
+        }
+    }
+}
+VM_NAME = 'kings_landing'
+DUMMY_TOKEN = {
+    'refresh_token': None,
+    'client_id': 'dany123',
+    'client_secret': 'lalalalalalala',
+    'grant_type': 'refresh_token'
+}
+
+
+class ExtendedTestCase(TestCase):
+    '''
+    Extended TestCase class containing additional helper methods.
+    '''
+
+    def assertRaisesWithMessage(self, exc_type, exc_msg, func, *args, **kwargs):
+        try:
+            func(*args, **kwargs)
+            self.assertFail()
+        except Exception as exc:
+            self.assertEqual(type(exc), exc_type)
+            self.assertEqual(exc.message, exc_msg)
+
+
+@skipIf(NO_MOCK, NO_MOCK_REASON)
+@patch('salt.cloud.clouds.gce.__virtual__', MagicMock(return_value='gce'))
+@patch('libcloud.common.google.GoogleInstalledAppAuthConnection.get_new_token', MagicMock(return_value=DUMMY_TOKEN))
+@patch('libcloud.compute.drivers.gce.GCENodeDriver.ex_list_zones', MagicMock(return_value=[]))
+@patch('libcloud.compute.drivers.gce.GCENodeDriver.ex_list_regions', MagicMock(return_value=[]))
+class GCETestCase(ExtendedTestCase):
+    '''
+    Unit TestCase for salt.cloud.clouds.gce module.
+    '''
+
+    def test_destroy_call(self):
+        '''
+        Tests that a SaltCloudSystemExit is raised when trying to call destroy
+        with --function or -f.
+        '''
+        self.assertRaises(
+            SaltCloudSystemExit,
+            gce.destroy,
+            vm_name=VM_NAME,
+            call='function'
+        )
+
+    @patch('libcloud.compute.drivers.gce.GCENodeDriver.list_sizes', MagicMock(return_value=[]))
+    def test_avail_sizes(self):
+        '''
+        Tests that avail_sizes returns an empty dictionary.
+        '''
+        sizes = gce.avail_sizes()
+        self.assertEqual(
+            sizes,
+            []
+            )
+
+    @patch('libcloud.compute.drivers.gce.GCENodeDriver.list_nodes', MagicMock(return_value=[]))
+    def test_list_nodes(self):
+        nodes = gce.list_nodes()
+        self.assertEqual(
+            nodes,
+            {}
+        )
+
+    @patch('libcloud.compute.drivers.gce.GCENodeDriver.list_locations', MagicMock(return_value=[]))
+    def test_list_locations(self):
+        locations = gce.avail_locations()
+        self.assertEqual(
+            locations,
+            {}
+        )
+
+
+if __name__ == '__main__':
+    from integration import run_tests
+    run_tests(GCETestCase, needs_daemon=False)