Merge pull request #30726 from sjmh/fix/log4mongo

Fix improper use of yield in generator
This commit is contained in:
Mike Place 2016-02-01 11:13:24 -07:00
commit ce3be26e8f

View File

@ -69,33 +69,32 @@ class FormatterWithHost(logging.Formatter, NewStyleClassMixIn):
def setup_handlers():
handler_id = 'log4mongo_handler'
if handler_id not in __opts__:
yield False
if handler_id in __opts__:
config_fields = {
'host': 'host',
'port': 'port',
'database_name': 'database_name',
'collection': 'collection',
'username': 'username',
'password': 'password',
'write_concern': 'w'
}
config_fields = {
'host': 'host',
'port': 'port',
'database_name': 'database_name',
'collection': 'collection',
'username': 'username',
'password': 'password',
'write_concern': 'w'
}
config_opts = {}
for config_opt, arg_name in config_fields.iteritems():
config_opts[arg_name] = __opts__[handler_id].get(config_opt)
config_opts = {}
for config_opt, arg_name in config_fields.iteritems():
config_opts[arg_name] = __opts__[handler_id].get(config_opt)
config_opts['level'] = LOG_LEVELS[
__opts__[handler_id].get(
'log_level',
__opts__.get('log_level', 'error')
)
]
config_opts['level'] = LOG_LEVELS[
__opts__[handler_id].get(
'log_level',
__opts__.get('log_level', 'error')
handler = MongoHandler(
formatter=FormatterWithHost(),
**config_opts
)
]
handler = MongoHandler(
formatter=FormatterWithHost(),
**config_opts
)
yield handler
yield handler
else:
yield False