From 8976d00bbea3df24ada51104698b8b3338550b82 Mon Sep 17 00:00:00 2001 From: Pedro Algarvio Date: Tue, 16 Dec 2014 11:55:37 +0000 Subject: [PATCH 1/2] Enable file permissions lint checker. This will allow us to confirm that no modules are added to salt with the wrong file permissions. Default file permissions is 0644. --- .pylintrc | 5 ++++- .testing.pylintrc | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.pylintrc b/.pylintrc index db3d02b3e1..836ca5b68f 100644 --- a/.pylintrc +++ b/.pylintrc @@ -27,7 +27,10 @@ persistent=yes # List of plugins (as comma separated values of python modules names) to load, # usually to register additional checkers. -load-plugins=salttesting.pylintplugins.pep8,salttesting.pylintplugins.pep263,salttesting.pylintplugins.strings +load-plugins=salttesting.pylintplugins.pep8, + salttesting.pylintplugins.pep263, + salttesting.pylintplugins.strings, + salttesting.pylintplugins.fileperms [MESSAGES CONTROL] diff --git a/.testing.pylintrc b/.testing.pylintrc index a98e6435b7..7fd1546b30 100644 --- a/.testing.pylintrc +++ b/.testing.pylintrc @@ -14,7 +14,10 @@ init-hook=" # Pickle collected data for later comparisons. persistent=no -load-plugins=salttesting.pylintplugins.pep8,salttesting.pylintplugins.pep263,salttesting.pylintplugins.strings +load-plugins=salttesting.pylintplugins.pep8, + salttesting.pylintplugins.pep263, + salttesting.pylintplugins.strings, + salttesting.pylintplugins.fileperms [MESSAGES CONTROL] From 10a7ead2df73c2738246b47574c52a958adf64f6 Mon Sep 17 00:00:00 2001 From: Pedro Algarvio Date: Tue, 16 Dec 2014 12:56:28 +0000 Subject: [PATCH 2/2] Add file perms pylint plugin specific settings --- .pylintrc | 4 ++++ .testing.pylintrc | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/.pylintrc b/.pylintrc index 836ca5b68f..b86d0fc153 100644 --- a/.pylintrc +++ b/.pylintrc @@ -33,6 +33,10 @@ load-plugins=salttesting.pylintplugins.pep8, salttesting.pylintplugins.fileperms +# Fileperms Lint Plugin Settings +fileperms-default=0644 +fileperms-ignore-paths=tests/runtests.py,tests/jenkins*.py,tests/saltsh.py,tests/buildpackage.py + [MESSAGES CONTROL] # Enable the message, report, category or checker with the given id(s). You can diff --git a/.testing.pylintrc b/.testing.pylintrc index 7fd1546b30..d787c2ed43 100644 --- a/.testing.pylintrc +++ b/.testing.pylintrc @@ -19,6 +19,10 @@ load-plugins=salttesting.pylintplugins.pep8, salttesting.pylintplugins.strings, salttesting.pylintplugins.fileperms +# Fileperms Lint Plugin Settings +fileperms-default=0644 +fileperms-ignore-paths=tests/runtests.py,tests/jenkins*.py,tests/saltsh.py,tests/buildpackage.py + [MESSAGES CONTROL] # Enable the message, report, category or checker with the given id(s). You can