From a5d8a6340ea42e0e723b1520abf011e871624d1b Mon Sep 17 00:00:00 2001 From: Daniel Wallace Date: Wed, 13 Dec 2017 09:44:36 -0700 Subject: [PATCH] check if VALUE is a string_type key should always be a stringtype, we want to exclude booleans in the value. --- salt/modules/yumpkg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/salt/modules/yumpkg.py b/salt/modules/yumpkg.py index 0a7b3575c6..a763d468d1 100644 --- a/salt/modules/yumpkg.py +++ b/salt/modules/yumpkg.py @@ -273,7 +273,7 @@ def _get_extra_options(**kwargs): ret = [] kwargs = salt.utils.clean_kwargs(**kwargs) for key, value in six.iteritems(kwargs): - if isinstance(key, six.string_types): + if isinstance(value, six.string_types): ret.append('--{0}=\'{1}\''.format(key, value)) elif value is True: ret.append('--{0}'.format(key))