From 994522e1fac7f6a60744405aaa8adc4603f5ec17 Mon Sep 17 00:00:00 2001 From: Severin Leonhardt Date: Thu, 15 Oct 2015 11:16:22 +0200 Subject: [PATCH] Fix firewalld.get_masquerade ['no'] == 'no' is never true. It must be checked if the list contains the string 'no'. --- salt/modules/firewalld.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/salt/modules/firewalld.py b/salt/modules/firewalld.py index a66ac5476f..58539a54a8 100644 --- a/salt/modules/firewalld.py +++ b/salt/modules/firewalld.py @@ -403,7 +403,7 @@ def get_masquerade(zone): ''' zone_info = list_all(zone) - if [zone_info[i]['masquerade'][0] for i in zone_info.keys()] == 'no': + if 'no' in [zone_info[i]['masquerade'][0] for i in zone_info.keys()]: return False return True