valitydev/salt
14
0
Fork 0
mirror of https://github.com/valitydev/salt.git synced 2024-11-07 00:55:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove references to pylint E8712

Browse Source 
E8712 is not a thing, at least not according to pylint's docs:

http://docs.pylint.org/search.html?q=E8712

Also, a couple other fixes:

1. Double quotes to single quotes to follow style conventions
2. "is Bool", not "== Bool".
This commit is contained in:
Erik Johnson 2014-06-14 22:16:26 -05:00
parent 01d6ec611c
commit 969a31ead7
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
salt/states/test.py
View File

@ -178,8 +178,7 @@ def configurable_test_state(name, changes=True, result=True, comment=''):
'comment': comment
}
# E8712 is disabled because this code is a LOT cleaner if we allow it.
if changes == "Random":
if changes == 'Random':
if random.choice([True, False]):
# Following the docs as written here
# http://docs.saltstack.com/ref/states/writing.html#return-data
@ -189,7 +188,7 @@ def configurable_test_state(name, changes=True, result=True, comment=''):
'new': 'Something pretended to change'
}
}
elif changes == True: # pylint: disable=E8712
elif changes is True:
# If changes is True we place our dummy change dictionary into it.
# Following the docs as written here
# http://docs.saltstack.com/ref/states/writing.html#return-data
@ -199,7 +198,7 @@ def configurable_test_state(name, changes=True, result=True, comment=''):
'new': 'Something pretended to change'
}
}
elif changes == False: # pylint: disable=E8712
elif changes is False:
ret['changes'] = {}
else:
err = ('You have specified the state option \'Changes\' with'
@ -210,9 +209,9 @@ def configurable_test_state(name, changes=True, result=True, comment=''):
if result == 'Random':
# since result is a boolean, if its random we just set it here,
ret['result'] = random.choice([True, False])
elif result == True: # pylint: disable=E8712
elif result is True:
ret['result'] = True
elif result == False: # pylint: disable=E8712
elif result is False:
ret['result'] = False
else:
raise SaltInvocationError('You have specified the state option '