valitydev/salt
14
0
Fork 0
mirror of https://github.com/valitydev/salt.git synced 2024-11-07 08:58:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove unit tests without logic

Browse Source
This commit is contained in:
twangboy 2016-03-21 17:47:34 -06:00
parent 5658753a5f
commit 7daf9d8277
1 changed files with 6 additions and 61 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
tests/unit/modules/mac_pkgutil_test.py
View File

@ -5,11 +5,10 @@ from __future__ import absolute_import
# Import salt module
from salt.modules import mac_pkgutil
import salt.utils.mac_utils
# Import Salt Testing libs
from salttesting import TestCase, skipIf
from salttesting.mock import NO_MOCK, NO_MOCK_REASON, MagicMock, patch
from salttesting.mock import NO_MOCK, NO_MOCK_REASON, patch
mac_pkgutil.__salt__ = {}
@ -17,58 +16,6 @@ mac_pkgutil.__salt__ = {}
@skipIf(NO_MOCK, NO_MOCK_REASON)
class MacPkgutilTestCase(TestCase):
def test_list(self):
# Given
r_output = "com.apple.pkg.iTunes"
# When
mock_cmd = MagicMock(return_value=r_output)
with patch.object(salt.utils.mac_utils,
'execute_return_result',
mock_cmd):
output = mac_pkgutil.list_()
# Then
self.assertEqual(
output,
[r_output]
)
mock_cmd.assert_called_with(
['pkgutil', '--pkgs'],
python_shell=False
)
def test_list_installed_output(self):
# Given
r_output = "com.apple.pkg.iTunes"
# When
mock_cmd = MagicMock(return_value=r_output)
with patch.dict(mac_pkgutil.__salt__, {'cmd.run_stdout': mock_cmd}):
output = mac_pkgutil.list_()
# Then
self.assertEqual(output, r_output)
def test_is_installed(self):
# Given
r_output = "com.apple.pkg.iTunes"
# When
mock_cmd = MagicMock(return_value=r_output)
with patch.dict(mac_pkgutil.__salt__, {'cmd.run_stdout': mock_cmd}):
ret = mac_pkgutil.is_installed("com.apple.pkg.iTunes")
# Then
self.assertTrue(ret)
# When
with patch.dict(mac_pkgutil.__salt__, {'cmd.run_stdout': mock_cmd}):
ret = mac_pkgutil.is_installed("com.apple.pkg.Safari")
# Then
self.assertFalse(ret)
def test_install(self):
# Given
@ -76,12 +23,11 @@ class MacPkgutilTestCase(TestCase):
package_id = "com.foo.fubar.pkg"
# When
mock_cmd = MagicMock(return_value=True)
with patch("salt.modules.mac_pkgutil.is_installed",
return_value=False) as is_installed:
return_value=False):
with patch("salt.modules.mac_pkgutil._install_from_path",
return_value=True) as _install_from_path:
ret = mac_pkgutil.install(source, package_id)
mac_pkgutil.install(source, package_id)
# Then
_install_from_path.assert_called_with(source)
@ -92,12 +38,11 @@ class MacPkgutilTestCase(TestCase):
package_id = "com.foo.fubar.pkg"
# When
mock_cmd = MagicMock(return_value=True)
with patch("salt.modules.mac_pkgutil.is_installed",
return_value=True) as is_installed:
return_value=True):
with patch("salt.modules.mac_pkgutil._install_from_path",
return_value=True) as _install_from_path:
ret = mac_pkgutil.install(source, package_id)
return_value=True) as _install_from_path:
mac_pkgutil.install(source, package_id)
# Then
self.assertEqual(_install_from_path.called, 0)