Merge pull request #42944 from Ch3LL/2016.11.6_follow_up

[2016.11] Add clean_id function to salt.utils.verify.py
This commit is contained in:
Nicole Thomas 2017-08-15 14:06:11 -04:00 committed by GitHub
commit 6366e05d0d

View File

@ -481,12 +481,21 @@ def clean_path(root, path, subdir=False):
return ''
def clean_id(id_):
'''
Returns if the passed id is clean.
'''
if re.search(r'\.\.{sep}'.format(sep=os.sep), id_):
return False
return True
def valid_id(opts, id_):
'''
Returns if the passed id is valid
'''
try:
return bool(clean_path(opts['pki_dir'], id_))
return bool(clean_path(opts['pki_dir'], id_)) and clean_id(id_)
except (AttributeError, KeyError) as e:
return False