valitydev/salt - salt - example

valitydev/salt

mirror of https://github.com/valitydev/salt.git synced 2024-11-08 17:33:54 +00:00

2 lines

24 B

Python

Raw Normal View History

Return a SaltInvocationError when passing incorrect function pattern When calling an incorrectly formatted wheel or runner function, we should be raising a SaltInvocationError with a hint to check function syntax rather that raising an Eauth authentication error. This PR does several things: - Adds a dictionary error return when the function syntax passed through to `utils.minions.CkMinions.spec_check` does not match the expected `module.function` syntax - Handles the return of this new dictionary error (instead of previous `False` return) wherever the spec_check function is called. This is handled up the stack in `master.py` and `masterapi.py`. - Reworks the runner and wheel functions in `master.py` and `masterapi.py` to help make those functions more DRY (see `salt.auth.check_authentication` function). - Adds tests for all of these changes (written before the runner and wheel functions were moved to use the new salt.auth.check_authentication function) to help prevent regressions. - Fixes a couple of places where unit tests exposed potential stacktraces. - Adjusts one previous unit test concerning the dictionary error change from spec_check

2017-08-25 19:43:34 +00:00

# -*- coding: utf-8 -*-