salt/tests/unit/modules/test_parted.py

338 lines
14 KiB
Python
Raw Normal View History

# -*- coding: utf-8 -*-
'''
:codeauthor: :email:`Dave Rawks (dave@pandora.com)`
tests.unit.modules.parted_test
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
'''
# Import Python libs
from __future__ import absolute_import, unicode_literals, print_function
# Import Salt Testing libs
2017-03-31 12:42:52 +00:00
from tests.support.mixins import LoaderModuleMockMixin
from tests.support.unit import skipIf, TestCase
from tests.support.mock import NO_MOCK, NO_MOCK_REASON, MagicMock, patch
Use explicit unicode strings + break up salt.utils This PR is part of what will be an ongoing effort to use explicit unicode strings in Salt. Because Python 3 does not suport Python 2's raw unicode string syntax (i.e. `ur'\d+'`), we must use `salt.utils.locales.sdecode()` to ensure that the raw string is unicode. However, because of how `salt/utils/__init__.py` has evolved into the hulking monstrosity it is today, this means importing a large module in places where it is not needed, which could negatively impact performance. For this reason, this PR also breaks out some of the functions from `salt/utils/__init__.py` into new/existing modules under `salt/utils/`. The long term goal will be that the modules within this directory do not depend on importing `salt.utils`. A summary of the changes in this PR is as follows: * Moves the following functions from `salt.utils` to new locations (including a deprecation warning if invoked from `salt.utils`): `to_bytes`, `to_str`, `to_unicode`, `str_to_num`, `is_quoted`, `dequote`, `is_hex`, `is_bin_str`, `rand_string`, `contains_whitespace`, `clean_kwargs`, `invalid_kwargs`, `which`, `which_bin`, `path_join`, `shlex_split`, `rand_str`, `is_windows`, `is_proxy`, `is_linux`, `is_darwin`, `is_sunos`, `is_smartos`, `is_smartos_globalzone`, `is_smartos_zone`, `is_freebsd`, `is_netbsd`, `is_openbsd`, `is_aix` * Moves the functions already deprecated by @rallytime to the bottom of `salt/utils/__init__.py` for better organization, so we can keep the deprecated ones separate from the ones yet to be deprecated as we continue to break up `salt.utils` * Updates `salt/*.py` and all files under `salt/client/` to use explicit unicode string literals. * Gets rid of implicit imports of `salt.utils` (e.g. `from salt.utils import foo` becomes `import salt.utils.foo as foo`). * Renames the `test.rand_str` function to `test.random_hash` to more accurately reflect what it does * Modifies `salt.utils.stringutils.random()` (née `salt.utils.rand_string()`) such that it returns a string matching the passed size. Previously this function would get `size` bytes from `os.urandom()`, base64-encode it, and return the result, which would in most cases not be equal to the passed size.
2017-07-25 01:47:15 +00:00
# Import Salt libs
from salt.exceptions import CommandExecutionError
import salt.modules.parted as parted
@skipIf(NO_MOCK, NO_MOCK_REASON)
2017-03-31 12:42:52 +00:00
class PartedTestCase(TestCase, LoaderModuleMockMixin):
def setup_loader_modules(self):
self.cmdrun = MagicMock()
self.cmdrun_stdout = MagicMock()
self.addCleanup(delattr, self, 'cmdrun')
self.addCleanup(delattr, self, 'cmdrun_stdout')
return {
parted: {
'__salt__': {
'cmd.run': self.cmdrun,
'cmd.run_stdout': self.cmdrun_stdout
}
}
2015-04-28 14:50:33 +00:00
}
# Test __virtual__ function for module registration
def test_virtual_bails_on_windows(self):
'''
If running windows, __virtual__ shouldn't register module
'''
Use explicit unicode strings + break up salt.utils This PR is part of what will be an ongoing effort to use explicit unicode strings in Salt. Because Python 3 does not suport Python 2's raw unicode string syntax (i.e. `ur'\d+'`), we must use `salt.utils.locales.sdecode()` to ensure that the raw string is unicode. However, because of how `salt/utils/__init__.py` has evolved into the hulking monstrosity it is today, this means importing a large module in places where it is not needed, which could negatively impact performance. For this reason, this PR also breaks out some of the functions from `salt/utils/__init__.py` into new/existing modules under `salt/utils/`. The long term goal will be that the modules within this directory do not depend on importing `salt.utils`. A summary of the changes in this PR is as follows: * Moves the following functions from `salt.utils` to new locations (including a deprecation warning if invoked from `salt.utils`): `to_bytes`, `to_str`, `to_unicode`, `str_to_num`, `is_quoted`, `dequote`, `is_hex`, `is_bin_str`, `rand_string`, `contains_whitespace`, `clean_kwargs`, `invalid_kwargs`, `which`, `which_bin`, `path_join`, `shlex_split`, `rand_str`, `is_windows`, `is_proxy`, `is_linux`, `is_darwin`, `is_sunos`, `is_smartos`, `is_smartos_globalzone`, `is_smartos_zone`, `is_freebsd`, `is_netbsd`, `is_openbsd`, `is_aix` * Moves the functions already deprecated by @rallytime to the bottom of `salt/utils/__init__.py` for better organization, so we can keep the deprecated ones separate from the ones yet to be deprecated as we continue to break up `salt.utils` * Updates `salt/*.py` and all files under `salt/client/` to use explicit unicode string literals. * Gets rid of implicit imports of `salt.utils` (e.g. `from salt.utils import foo` becomes `import salt.utils.foo as foo`). * Renames the `test.rand_str` function to `test.random_hash` to more accurately reflect what it does * Modifies `salt.utils.stringutils.random()` (née `salt.utils.rand_string()`) such that it returns a string matching the passed size. Previously this function would get `size` bytes from `os.urandom()`, base64-encode it, and return the result, which would in most cases not be equal to the passed size.
2017-07-25 01:47:15 +00:00
with patch('salt.utils.platform.is_windows', lambda: True):
2017-04-10 13:00:57 +00:00
ret = parted.__virtual__()
err = (False, 'The parted execution module failed to load Windows systems are not supported.')
self.assertEqual(err, ret)
def test_virtual_bails_without_parted(self):
'''
If parted not in PATH, __virtual__ shouldn't register module
'''
with patch('salt.utils.path.which', lambda exe: not exe == "parted"),\
patch('salt.utils.platform.is_windows', return_value=False):
2017-04-10 13:00:57 +00:00
ret = parted.__virtual__()
err = (False, 'The parted execution module failed to load parted binary is not in the path.')
self.assertEqual(err, ret)
def test_virtual_bails_without_lsblk(self):
'''
If lsblk not in PATH, __virtual__ shouldn't register module
'''
with patch('salt.utils.path.which', lambda exe: not exe == "lsblk"),\
patch('salt.utils.platform.is_windows', return_value=False):
2017-04-10 13:00:57 +00:00
ret = parted.__virtual__()
err = (False, 'The parted execution module failed to load lsblk binary is not in the path.')
self.assertEqual(err, ret)
def test_virtual_bails_without_partprobe(self):
'''
If partprobe not in PATH, __virtual__ shouldn't register module
'''
with patch('salt.utils.path.which', lambda exe: not exe == "partprobe"),\
patch('salt.utils.platform.is_windows', return_value=False):
2017-04-10 13:00:57 +00:00
ret = parted.__virtual__()
err = (False, 'The parted execution module failed to load partprobe binary is not in the path.')
self.assertEqual(err, ret)
def test_virtual(self):
'''
On expected platform with correct utils in PATH, register "partition" module
'''
Use explicit unicode strings + break up salt.utils This PR is part of what will be an ongoing effort to use explicit unicode strings in Salt. Because Python 3 does not suport Python 2's raw unicode string syntax (i.e. `ur'\d+'`), we must use `salt.utils.locales.sdecode()` to ensure that the raw string is unicode. However, because of how `salt/utils/__init__.py` has evolved into the hulking monstrosity it is today, this means importing a large module in places where it is not needed, which could negatively impact performance. For this reason, this PR also breaks out some of the functions from `salt/utils/__init__.py` into new/existing modules under `salt/utils/`. The long term goal will be that the modules within this directory do not depend on importing `salt.utils`. A summary of the changes in this PR is as follows: * Moves the following functions from `salt.utils` to new locations (including a deprecation warning if invoked from `salt.utils`): `to_bytes`, `to_str`, `to_unicode`, `str_to_num`, `is_quoted`, `dequote`, `is_hex`, `is_bin_str`, `rand_string`, `contains_whitespace`, `clean_kwargs`, `invalid_kwargs`, `which`, `which_bin`, `path_join`, `shlex_split`, `rand_str`, `is_windows`, `is_proxy`, `is_linux`, `is_darwin`, `is_sunos`, `is_smartos`, `is_smartos_globalzone`, `is_smartos_zone`, `is_freebsd`, `is_netbsd`, `is_openbsd`, `is_aix` * Moves the functions already deprecated by @rallytime to the bottom of `salt/utils/__init__.py` for better organization, so we can keep the deprecated ones separate from the ones yet to be deprecated as we continue to break up `salt.utils` * Updates `salt/*.py` and all files under `salt/client/` to use explicit unicode string literals. * Gets rid of implicit imports of `salt.utils` (e.g. `from salt.utils import foo` becomes `import salt.utils.foo as foo`). * Renames the `test.rand_str` function to `test.random_hash` to more accurately reflect what it does * Modifies `salt.utils.stringutils.random()` (née `salt.utils.rand_string()`) such that it returns a string matching the passed size. Previously this function would get `size` bytes from `os.urandom()`, base64-encode it, and return the result, which would in most cases not be equal to the passed size.
2017-07-25 01:47:15 +00:00
with patch('salt.utils.platform.is_windows', lambda: False), \
patch('salt.utils.path.which', lambda exe: exe in ('parted', 'lsblk', 'partprobe')):
2017-04-10 13:00:57 +00:00
ret = parted.__virtual__()
expect = 'partition'
self.assertEqual(ret, expect)
# Test probe function
def test_probe_wo_args(self):
parted.probe()
self.cmdrun.assert_called_once_with('partprobe -- ')
def test_probe_w_single_arg(self):
2017-04-10 13:00:57 +00:00
with patch('salt.modules.parted._validate_device', MagicMock()):
parted.probe('/dev/sda')
self.cmdrun.assert_called_once_with('partprobe -- /dev/sda')
def test_probe_w_multiple_args(self):
2017-04-10 13:00:57 +00:00
with patch('salt.modules.parted._validate_device', MagicMock()):
parted.probe('/dev/sda', '/dev/sdb')
self.cmdrun.assert_called_once_with('partprobe -- /dev/sda /dev/sdb')
# Test _list function
@staticmethod
def parted_print_output(k):
output = {
"valid": (
'''BYT;\n'''
'''/dev/sda:4000GB:scsi:512:512:gpt:AMCC 9650SE-24M DISK:;\n'''
'''1:17.4kB:150MB:150MB:ext3::boot;\n'''
'''2:3921GB:4000GB:79.3GB:linux-swap(v1)::;\n'''
),
"valid_legacy": (
'''BYT;\n'''
'''/dev/sda:4000GB:scsi:512:512:gpt:AMCC 9650SE-24M DISK;\n'''
'''1:17.4kB:150MB:150MB:ext3::boot;\n'''
'''2:3921GB:4000GB:79.3GB:linux-swap(v1)::;\n'''
),
"empty": '',
"bad_label_info": (
'''BYT;\n'''
'''badbadbadbad\n'''
'''1:17.4kB:150MB:150MB:ext3::boot;\n'''
'''2:3921GB:4000GB:79.3GB:linux-swap(v1)::;\n'''
),
"bad_header": (
'''badbadbadbad\n'''
'''/dev/sda:4000GB:scsi:512:512:gpt:AMCC 9650SE-24M DISK:;\n'''
'''1:17.4kB:150MB:150MB:ext3::boot;\n'''
'''2:3921GB:4000GB:79.3GB:linux-swap(v1)::;\n'''
),
"bad_partition": (
'''BYT;\n'''
'''/dev/sda:4000GB:scsi:512:512:gpt:AMCC 9650SE-24M DISK:;\n'''
'''badbadbadbad\n'''
'''2:3921GB:4000GB:79.3GB:linux-swap(v1)::;\n'''
),
}
return output[k]
def test_list__without_device(self):
self.assertRaises(TypeError, parted.list_)
def test_list__empty_cmd_output(self):
2017-04-10 13:00:57 +00:00
with patch('salt.modules.parted._validate_device', MagicMock()):
self.cmdrun_stdout.return_value = self.parted_print_output('empty')
output = parted.list_('/dev/sda')
self.cmdrun_stdout.assert_called_once_with('parted -m -s /dev/sda print')
expected = {'info': {}, 'partitions': {}}
self.assertEqual(output, expected)
def test_list__valid_unit_empty_cmd_output(self):
2017-04-10 13:00:57 +00:00
with patch('salt.modules.parted._validate_device', MagicMock()):
self.cmdrun_stdout.return_value = self.parted_print_output('empty')
output = parted.list_('/dev/sda', unit='s')
self.cmdrun_stdout.assert_called_once_with('parted -m -s /dev/sda unit s print')
expected = {'info': {}, 'partitions': {}}
self.assertEqual(output, expected)
def test_list__invalid_unit(self):
self.assertRaises(CommandExecutionError, parted.list_, '/dev/sda',
unit='badbadbad')
self.assertFalse(self.cmdrun.called)
def test_list__bad_header(self):
2017-04-10 13:00:57 +00:00
with patch('salt.modules.parted._validate_device', MagicMock()):
self.cmdrun_stdout.return_value = self.parted_print_output('bad_header')
self.assertRaises(CommandExecutionError, parted.list_, '/dev/sda')
self.cmdrun_stdout.assert_called_once_with('parted -m -s /dev/sda print')
def test_list__bad_label_info(self):
2017-04-10 13:00:57 +00:00
with patch('salt.modules.parted._validate_device', MagicMock()):
self.cmdrun_stdout.return_value = self.parted_print_output('bad_label_info')
self.assertRaises(CommandExecutionError, parted.list_, '/dev/sda')
self.cmdrun_stdout.assert_called_once_with('parted -m -s /dev/sda print')
def test_list__bad_partition(self):
2017-04-10 13:00:57 +00:00
with patch('salt.modules.parted._validate_device', MagicMock()):
self.cmdrun_stdout.return_value = self.parted_print_output('bad_partition')
self.assertRaises(CommandExecutionError, parted.list_, '/dev/sda')
self.cmdrun_stdout.assert_called_once_with('parted -m -s /dev/sda print')
def test_list__valid_cmd_output(self):
2017-04-10 13:00:57 +00:00
with patch('salt.modules.parted._validate_device', MagicMock()):
self.cmdrun_stdout.return_value = self.parted_print_output('valid')
output = parted.list_('/dev/sda')
self.cmdrun_stdout.assert_called_once_with('parted -m -s /dev/sda print')
expected = {
'info': {
'logical sector': '512',
'physical sector': '512',
'interface': 'scsi',
'model': 'AMCC 9650SE-24M DISK',
'disk': '/dev/sda',
'disk flags': '',
'partition table': 'gpt',
'size': '4000GB'
},
'partitions': {
'1': {
'end': '150MB',
'number': '1',
'start': '17.4kB',
'file system': '',
'flags': 'boot',
'type': 'ext3',
'size': '150MB'},
'2': {
'end': '4000GB',
'number': '2',
'start': '3921GB',
'file system': '',
'flags': '',
'type': 'linux-swap(v1)',
'size': '79.3GB'
}
}
}
2017-04-10 13:00:57 +00:00
self.assertEqual(output, expected)
def test_list__valid_unit_valid_cmd_output(self):
2017-04-10 13:00:57 +00:00
with patch('salt.modules.parted._validate_device', MagicMock()):
self.cmdrun_stdout.return_value = self.parted_print_output('valid')
output = parted.list_('/dev/sda', unit='s')
self.cmdrun_stdout.assert_called_once_with('parted -m -s /dev/sda unit s print')
expected = {
'info': {
'logical sector': '512',
'physical sector': '512',
'interface': 'scsi',
'model': 'AMCC 9650SE-24M DISK',
'disk': '/dev/sda',
'disk flags': '',
'partition table': 'gpt',
'size': '4000GB'
},
'partitions': {
'1': {
'end': '150MB',
'number': '1',
'start': '17.4kB',
'file system': '',
'flags': 'boot',
'type': 'ext3',
'size': '150MB'},
'2': {
'end': '4000GB',
'number': '2',
'start': '3921GB',
'file system': '',
'flags': '',
'type': 'linux-swap(v1)',
'size': '79.3GB'
}
}
}
2017-04-10 13:00:57 +00:00
self.assertEqual(output, expected)
def test_list__valid_legacy_cmd_output(self):
2017-04-10 13:00:57 +00:00
with patch('salt.modules.parted._validate_device', MagicMock()):
self.cmdrun_stdout.return_value = self.parted_print_output('valid_legacy')
output = parted.list_('/dev/sda')
self.cmdrun_stdout.assert_called_once_with('parted -m -s /dev/sda print')
expected = {
'info': {
'logical sector': '512',
'physical sector': '512',
'interface': 'scsi',
'model': 'AMCC 9650SE-24M DISK',
'disk': '/dev/sda',
'partition table': 'gpt',
'size': '4000GB'
},
'partitions': {
'1': {
'end': '150MB',
'number': '1',
'start': '17.4kB',
'file system': '',
'flags': 'boot',
'type': 'ext3',
'size': '150MB'},
'2': {
'end': '4000GB',
'number': '2',
'start': '3921GB',
'file system': '',
'flags': '',
'type': 'linux-swap(v1)',
'size': '79.3GB'
}
}
}
2017-04-10 13:00:57 +00:00
self.assertEqual(output, expected)
def test_list__valid_unit_valid_legacy_cmd_output(self):
2017-04-10 13:00:57 +00:00
with patch('salt.modules.parted._validate_device', MagicMock()):
self.cmdrun_stdout.return_value = self.parted_print_output('valid_legacy')
output = parted.list_('/dev/sda', unit='s')
self.cmdrun_stdout.assert_called_once_with('parted -m -s /dev/sda unit s print')
expected = {
'info': {
'logical sector': '512',
'physical sector': '512',
'interface': 'scsi',
'model': 'AMCC 9650SE-24M DISK',
'disk': '/dev/sda',
'partition table': 'gpt',
'size': '4000GB'
},
'partitions': {
'1': {
'end': '150MB',
'number': '1',
'start': '17.4kB',
'file system': '',
'flags': 'boot',
'type': 'ext3',
'size': '150MB'},
'2': {
'end': '4000GB',
'number': '2',
'start': '3921GB',
'file system': '',
'flags': '',
'type': 'linux-swap(v1)',
'size': '79.3GB'
}
}
}
2017-04-10 13:00:57 +00:00
self.assertEqual(output, expected)