valitydev/redash
14
0
Fork 0
mirror of https://github.com/valitydev/redash.git synced 2024-11-07 01:25:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests for find_missing_params (#3225)

Browse Source 
* stop testing `collect_query_parameters`, it's an implementation detail

* add tests for `missing_query_params`
This commit is contained in:
Omer Lachish 2018-12-31 12:34:57 +02:00 committed by Arik Fraimovich
parent 632fc5aace
commit d7edaa3ba2
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
tests/test_utils.py
View File

@ -2,7 +2,7 @@ from collections import namedtuple
from unittest import TestCase
from redash.utils import (build_url, collect_parameters_from_request,
collect_query_parameters, filter_none,
find_missing_params, filter_none,
json_dumps, generate_token)
DummyRequest = namedtuple('DummyRequest', ['host', 'scheme'])
@ -25,25 +25,31 @@ class TestBuildUrl(TestCase):
self.assertEqual("http://example.com:443/test", build_url(DummyRequest("example.com:443", "http"), "example.com", "/test"))
class TestCollectParametersFromQuery(TestCase):
class TestFindMissingParams(TestCase):
def test_returns_empty_list_for_regular_query(self):
query = u"SELECT 1"
self.assertEqual([], collect_query_parameters(query))
self.assertEqual(set([]), find_missing_params(query, {}))
def test_finds_all_params_when_missing(self):
query = u"SELECT {{param}} FROM {{table}}"
self.assertEqual(set(['param', 'table']), find_missing_params(query, {}))
def test_finds_all_params(self):
query = u"SELECT {{param}} FROM {{table}}"
params = ['param', 'table']
self.assertEqual(params, collect_query_parameters(query))
self.assertEqual(set([]), find_missing_params(query, {'param': 'value', 'table': 'value'}))
def test_deduplicates_params(self):
query = u"SELECT {{param}}, {{param}} FROM {{table}}"
params = ['param', 'table']
self.assertEqual(params, collect_query_parameters(query))
self.assertEqual(set([]), find_missing_params(query, {'param': 'value', 'table': 'value'}))
def test_handles_nested_params(self):
query = u"SELECT {{param}}, {{param}} FROM {{table}} -- {{#test}} {{nested_param}} {{/test}}"
params = ['param', 'table', 'test', 'nested_param']
self.assertEqual(params, collect_query_parameters(query))
self.assertEqual(set(['test', 'nested_param']),
find_missing_params(query, {'param': 'value', 'table': 'value'}))
def test_handles_objects(self):
query = u"SELECT * FROM USERS WHERE created_at between '{{ created_at.start }}' and '{{ created_at.end }}'"
self.assertEqual(set([]), find_missing_params(query, {'created_at': {'start': 1, 'end': 2}}))
class TestCollectParametersFromRequest(TestCase):