valitydev/redash
14
0
Fork 0
mirror of https://github.com/valitydev/redash.git synced 2024-11-07 01:25:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #2308 from getredash/fix_params

Browse Source 
Fix: parameters list was resetting when adding a new parameter
This commit is contained in:
Arik Fraimovich 2018-02-11 11:55:47 +02:00 committed by GitHub
commit 953efc472f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
client/app/services/query.js
View File

@ -102,6 +102,8 @@ class Parameters {
parameters = uniq(collectParams(parts));
} catch (e) {
logger('Failed parsing parameters: ', e);
// Return current parameters so we don't reset the list
parameters = pluck(this.query.options.parameters, 'name');
}
return parameters;
}
@ -123,13 +125,13 @@ class Parameters {
parameterNames.forEach((param) => {
if (!has(parametersMap, param)) {
this.query.options.parameters.push({
this.query.options.parameters.push(new Parameter({
title: param,
name: param,
type: 'text',
value: null,
global: false,
});
}));
}
});