valitydev/redash
14
0
Fork 0
mirror of https://github.com/valitydev/redash.git synced 2024-11-07 17:38:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix: visualization tab wasnt updating on add/delete.

Browse Source
This commit is contained in:
Arik Fraimovich 2017-01-05 11:39:25 +02:00
parent 07b6b16fda
commit 9213a18057
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client/app/pages/queries/source-view.js
View File

@ -92,7 +92,7 @@ function QuerySourceCtrl(Events, toastr, $controller, $scope, $location, $http,
Events.record('delete', 'visualization', vis.id);
Visualization.delete({ id: vis.id }, () => {
if ($scope.selectedTab === vis.id) {
if ($scope.selectedTab === String(vis.id)) {
$scope.selectedTab = DEFAULT_TAB;
$location.hash($scope.selectedTab);
}

3
redash/handlers/visualizations.py
View File

@ -19,10 +19,11 @@ class VisualizationListResource(BaseResource):
vis = models.Visualization(**kwargs)
models.db.session.add(vis)
d = vis.to_dict(with_query=False)
models.db.session.commit()
d = vis.to_dict(with_query=False)
return d
class VisualizationResource(BaseResource):
@require_permission('edit_query')
def post(self, visualization_id):