valitydev/redash
14
0
Fork 0
mirror of https://github.com/valitydev/redash.git synced 2024-11-07 17:38:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use bind(this) instead of creating that

Browse Source 
Signed-off-by: John Wu <webmaster@leapoahead.com>
This commit is contained in:
John Wu 2015-10-06 15:04:02 -07:00
parent 2e78ef0128
commit 2a6ed3ca52
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
rd_ui/app/scripts/services/resources.js
View File

@ -216,7 +216,6 @@
QueryResult.prototype.getChartData = function (mapping, dateRange) {
var series = {};
var that = this;
_.each(this.getData(), function (row) {
var point = {};
@ -258,8 +257,8 @@
if (seriesName === undefined) {
_.each(yValues, function (yValue, seriesName) {
that._addPointToSeries({'x': xValue, 'y': yValue}, series, seriesName);
});
this._addPointToSeries({'x': xValue, 'y': yValue}, series, seriesName);
}.bind(this));
} else if (dateRange && moment.isMoment(point.x)) {
// Check whether the x axis is of type datetime and whether the dateRange feature is enabled (by checking if dateRange object is provided). If so, we will want to filter points based on dateRange set.
this._addPointToSeriesIfInDateRange(point, series, seriesName, dateRange);
@ -267,7 +266,7 @@
else {
this._addPointToSeries(point, series, seriesName);
}
});
}.bind(this));
return _.values(series);
};