valitydev/redash
14
0
Fork 0
mirror of https://github.com/valitydev/redash.git synced 2024-11-07 01:25:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

rename safely_apply_parameters to apply_parameters

Browse Source
This commit is contained in:
Omer Lachish 2018-12-16 10:58:20 +02:00
parent 479247b60c
commit 1b4e0f5de7
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
redash/handlers/query_results.py
View File

@ -20,7 +20,7 @@ def error_response(message):
return {'job': {'status': 4, 'error': message}}, 400 return {'job': {'status': 4, 'error': message}}, 400
def safely_apply_parameters(template, parameters, data_source): def apply_parameters(template, parameters, data_source):
query = SQLQuery(template).apply(parameters) query = SQLQuery(template).apply(parameters)
# for now we only log `SQLInjectionError` to detect false positives # for now we only log `SQLInjectionError` to detect false positives
@ -53,7 +53,7 @@ def run_query_sync(data_source, parameter_values, query_text, max_age=0):
if missing_params: if missing_params:
raise Exception('Missing parameter value for: {}'.format(", ".join(missing_params))) raise Exception('Missing parameter value for: {}'.format(", ".join(missing_params)))
query_text = safely_apply_parameters(query_text, parameter_values, data_source) query_text = apply_parameters(query_text, parameter_values, data_source)
if max_age <= 0: if max_age <= 0:
query_result = None query_result = None
@ -103,7 +103,7 @@ def run_query(data_source, parameter_values, query_text, query_id, max_age=0):
return error_response(message) return error_response(message)
query_text = safely_apply_parameters(query_text, parameter_values, data_source) query_text = apply_parameters(query_text, parameter_values, data_source)
if max_age == 0: if max_age == 0:
query_result = None query_result = None