From 00b5aba88a04f3514e7c3a405dd87c785db23dce Mon Sep 17 00:00:00 2001 From: Arik Fraimovich Date: Sun, 16 Feb 2014 10:40:57 +0200 Subject: [PATCH] Remove the need to declare each visualization module in app dependencies. --- rd_ui/app/scripts/app.js | 3 --- rd_ui/app/scripts/visualizations/chart.js | 2 +- rd_ui/app/scripts/visualizations/cohort.js | 2 +- rd_ui/app/scripts/visualizations/table.js | 2 +- 4 files changed, 3 insertions(+), 6 deletions(-) diff --git a/rd_ui/app/scripts/app.js b/rd_ui/app/scripts/app.js index 09329ee3..52ac7029 100644 --- a/rd_ui/app/scripts/app.js +++ b/rd_ui/app/scripts/app.js @@ -6,9 +6,6 @@ angular.module('redash', [ 'redash.services', 'redash.renderers', 'redash.visualization', - 'redash.visualization.chart', - 'redash.visualization.cohort', - 'redash.visualization.table', 'ui.codemirror', 'highchart', 'angular-growl', diff --git a/rd_ui/app/scripts/visualizations/chart.js b/rd_ui/app/scripts/visualizations/chart.js index 78c73dc7..7be1d985 100644 --- a/rd_ui/app/scripts/visualizations/chart.js +++ b/rd_ui/app/scripts/visualizations/chart.js @@ -1,5 +1,5 @@ (function () { - var chartVisualization = angular.module('redash.visualization.chart', []); + var chartVisualization = angular.module('redash.visualization'); chartVisualization.config(['VisualizationProvider', function(VisualizationProvider) { var renderTemplate = ''; diff --git a/rd_ui/app/scripts/visualizations/cohort.js b/rd_ui/app/scripts/visualizations/cohort.js index fd72896f..07c6d24a 100644 --- a/rd_ui/app/scripts/visualizations/cohort.js +++ b/rd_ui/app/scripts/visualizations/cohort.js @@ -1,5 +1,5 @@ (function () { - var cohortVisualization = angular.module('redash.visualization.cohort', []); + var cohortVisualization = angular.module('redash.visualization'); cohortVisualization.config(['VisualizationProvider', function(VisualizationProvider) { VisualizationProvider.registerVisualization('COHORT', 'Cohort', '', null); diff --git a/rd_ui/app/scripts/visualizations/table.js b/rd_ui/app/scripts/visualizations/table.js index cf63fd53..1513ce1e 100644 --- a/rd_ui/app/scripts/visualizations/table.js +++ b/rd_ui/app/scripts/visualizations/table.js @@ -1,5 +1,5 @@ (function () { - var tableVisualization = angular.module('redash.visualization.table', []); + var tableVisualization = angular.module('redash.visualization'); tableVisualization.config(['VisualizationProvider', function(VisualizationProvider) { VisualizationProvider.registerVisualization('TABLE', 'Table', '', null, {}, true);