fix typo for residence_address /CP-9 (#3)

* fix typo for residence_address /CP-9

* add methods exceptions /CP-9

* fixes /CP-9

* fixes /CP-9

* fix damsel visibility in rebar /CP-9

pom.xml

@@ -7,7 +7,7 @@
     <parent>
         <groupId>dev.vality</groupId>
         <artifactId>library-parent-pom</artifactId>
-        <version>2.0.0</version>
+        <version>2.0.2</version>
     </parent>
 
     <artifactId>personal-data-storage-proto</artifactId>
@@ -51,6 +51,12 @@
             <version>1.0.5</version>
             <scope>provided</scope>
         </dependency>
+        <dependency>
+            <groupId>dev.vality</groupId>
+            <artifactId>damsel</artifactId>
+            <version>1.628-a711c8f</version>
+            <scope>provided</scope>
+        </dependency>
         <dependency>
             <groupId>javax.annotation</groupId>
             <artifactId>javax.annotation-api</artifactId>

proto/personal-data-storage-proto.thrift

@@ -1,3 +1,6 @@
+include "proto/base.thrift"
+include "proto/domain.thrift"
+
 namespace java com.empayre.transfer
 namespace erlang personal_data_storage.personal_data_storage
 
@@ -15,7 +18,7 @@ struct PersonPassport {
     5: required string citizenship
     6: required string birth_place
     7: required string number
-    8: required string residense_address
+    8: required string residence_address
     9: required string issued_by
     10: required string issued_at
     // only for russian domestic passports
@@ -73,7 +76,11 @@ union PersonalData {
     3: GenericPersonalData generic_personal_data
 }
 
+exception PersonalDataNotFound {}
+
 service PersonalDataStorageService {
-    SavePersonalDataResponse SavePersonalData(SavePersonalDataRequest save_personal_data_request)
-    GetPersonalDataResponse GetPersonalData(PersonalDataToken token)
+    SavePersonalDataResponse SavePersonalData(1: SavePersonalDataRequest save_personal_data_request)
+        throws (1: base.InvalidRequest ex)
+    GetPersonalDataResponse GetPersonalData(1: PersonalDataToken token)
+        throws (1: PersonalDataNotFound ex1, 2: base.InvalidRequest ex2)
 }

rebar.config

@@ -25,6 +25,11 @@
     warn_missing_spec_all
 ]}.
 
+{deps, [
+    {damsel, {git, "https://github.com/valitydev/damsel.git", {branch, "master"}}}
+]}.
+
+
 %% XRef checks
 {xref_checks, [
     undefined_function_calls,