From df8663516e701236f38f0d3d199acece58d2c65c Mon Sep 17 00:00:00 2001
From: Will Newton <will.newton@gmail.com>
Date: Mon, 21 Oct 2019 03:17:39 +0100
Subject: [PATCH] tests: Add sanity test for nvram (#5903)

Add a simple sanity test for macOS nvram.

Closes: #5019
---
 tests/integration/tables/nvram.cpp | 26 +++++++++-----------------
 1 file changed, 9 insertions(+), 17 deletions(-)

diff --git a/tests/integration/tables/nvram.cpp b/tests/integration/tables/nvram.cpp
index adfdc623..6ddf45cb 100644
--- a/tests/integration/tables/nvram.cpp
+++ b/tests/integration/tables/nvram.cpp
@@ -14,30 +14,22 @@
 namespace osquery {
 namespace table_tests {
 
-class nvram : public testing::Test {
+class NvramTest : public testing::Test {
  protected:
   void SetUp() override {
     setUpEnvironment();
   }
 };
 
-TEST_F(nvram, test_sanity) {
-  // 1. Query data
+TEST_F(NvramTest, test_sanity) {
   auto const data = execute_query("select * from nvram");
-  // 2. Check size before validation
-  // ASSERT_GE(data.size(), 0ul);
-  // ASSERT_EQ(data.size(), 1ul);
-  // ASSERT_EQ(data.size(), 0ul);
-  // 3. Build validation map
-  // See helper.h for avaialbe flags
-  // Or use custom DataCheck object
-  // ValidationMap row_map = {
-  //      {"name", NormalType}
-  //      {"type", NormalType}
-  //      {"value", NormalType}
-  //}
-  // 4. Perform validation
-  // validate_rows(data, row_map);
+  ASSERT_GT(data.size(), 0ul);
+  ValidationMap row_map = {
+      {"name", NonEmptyString},
+      {"type", NonEmptyString},
+      {"value", NonEmptyString},
+  };
+  validate_rows(data, row_map);
 }
 
 } // namespace table_tests