valitydev/osquery-1
14
0
Fork 0
mirror of https://github.com/valitydev/osquery-1.git synced 2024-11-07 01:55:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Mute signed-unsigned comparison warning for tests on macosx

Browse Source 
Summary: Right now it blocks us, because build on macox doesn't work. Fix will take some time - lots of changes. But on the other hand value of such change in tests is nearly zero. So, let's just mute it.

Reviewed By: guliashvili

Differential Revision: D14597262

fbshipit-source-id: adaacc003f49647e255001bb84cc0e71273cd486
This commit is contained in:
Alexander Kindyakov 2019-03-25 09:22:31 -07:00 committed by Facebook Github Bot
parent a9b5309418
commit 76cc3eaf66
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tools/build_defs/oss/osquery/cxx.bzl
View File

@ -148,4 +148,18 @@ def osquery_cxx_test(external = False, **kwargs):
_ignore = [external]
_osquery_set_generic_kwargs(kwargs)
_osquery_set_preprocessor_kwargs(kwargs, external)
kwargs.setdefault("platform_preprocessor_flags", [])
kwargs["platform_preprocessor_flags"].append(
(
_MACOSX,
[
# osquery tests have lots of ASSERT_/EXPECT_ to compare signed
# const with unsigned value. It requires some effort to fix it
# with small value, because it is just tests.
"-Wno-sign-compare",
],
),
)
_osquery_cxx_test(**kwargs)