valitydev/osquery-1
14
0
Fork 0
mirror of https://github.com/valitydev/osquery-1.git synced 2024-11-06 01:25:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix XattrTests failing due to unexpected attribute name (#6941)

Browse Source 
The extended attributes present on a test file
might not be only the ones set by the test itself.
If SELinux is installed for instance, an additional extended attribute
is present.
Therefore instead of requiring that the list of attribute names
is exactly the one set by the test, verify that the attribute names
we expect are present in the list.
This commit is contained in:
Stefano Bonicatti 2021-02-11 03:02:50 +01:00 committed by GitHub
parent fd742c51ac
commit 58a6a8d288
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
osquery/filesystem/tests/posix/xattrs.cpp
View File

@ -85,10 +85,12 @@ TEST_F(XattrTests, getExtendedAttributeNameList) {
test_file_path.string());
ASSERT_TRUE(status.ok());
ASSERT_EQ(kTestAttributeList.size(), attribute_name_list.size());
ASSERT_GE(attribute_name_list.size(), kTestAttributeList.size());
for (const auto& attribute_name : attribute_name_list) {
EXPECT_TRUE(kTestAttributeList.count(attribute_name) > 0U);
for (const auto& attribute_name : kTestAttributeList) {
EXPECT_TRUE(std::find(attribute_name_list.begin(),
attribute_name_list.end(),
attribute_name.first) != attribute_name_list.end());
}
}