valitydev/org-manager
14
0
Fork 0
mirror of https://github.com/valitydev/org-manager.git synced 2024-11-06 00:15:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

add controller test + fix check method

Browse Source
This commit is contained in:
ggmaleva 2021-03-05 14:43:32 +03:00
parent e177a2a275
commit a88353e54d
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/com/rbkmoney/orgmanager/controller/OrgsController.java
View File

@ -144,7 +144,7 @@ public class OrgsController implements OrgsApi {
String userId,
MemberRole body) {
log.info("Assign member role: requestId={}, orgId={}, payload={}", xRequestID, orgId, body);
resourceAccessService.checkRoleRights(orgId, body);
resourceAccessService.checkMemberRoleRights(orgId, userId, body);
return organizationService.assignMemberRole(orgId, userId, body);
}

14
src/test/java/com/rbkmoney/orgmanager/controller/OrgsControllerTest.java
View File

@ -97,6 +97,20 @@ public class OrgsControllerTest extends AbstractControllerTest {
.andExpect(status().isForbidden());
}
@Test
public void assignMemberRoleWithoutAccess() throws Exception {
MemberRole memberRole = TestData.buildMemberRole();
doThrow(new AccessDeniedException("Access denied")).when(resourceAccessService)
.checkMemberRoleRights(ORGANIZATION_ID, MEMBER_ID, memberRole);
mockMvc.perform(put(String.format("/orgs/%s/members/%s/roles", ORGANIZATION_ID, MEMBER_ID))
.contentType("application/json")
.content(objectMapper.writeValueAsString(memberRole))
.header("Authorization", "Bearer " + generateRBKadminJwt())
.header("X-Request-ID", "testRequestId"))
.andExpect(status().isForbidden());
}
@Test
public void assignMemberRoleTest() throws Exception {
MemberRole memberRole = TestData.buildMemberRole();