[Spring] Spotbugs static class and default encoding (#2609)

* add static modifier - mvn verify passes

* specify charset, mvn verify works, compiles and clean on spotbugs in my project

* update samples as per contribution guide; mvn integration-test passes

* commit rest of samples

* fix missing newline at EOF

* lots of new newlines

* needed to run mvn clean beforehand...

modules/openapi-generator/src/main/resources/JavaSpring/apiUtil.mustache

@@ -1,6 +1,7 @@
 package {{apiPackage}};
 
 {{#reactive}}
+import java.nio.charset.StandardCharsets;
 import org.springframework.core.io.buffer.DefaultDataBufferFactory;
 import org.springframework.web.server.ServerWebExchange;
 import reactor.core.publisher.Mono;
@@ -27,7 +28,7 @@ public class ApiUtil {
 {{/reactive}}
 {{#reactive}}
     public static Mono<Void> getExampleResponse(ServerWebExchange exchange, String example) {
-        return exchange.getResponse().writeWith(Mono.just(new DefaultDataBufferFactory().wrap(example.getBytes())));
+        return exchange.getResponse().writeWith(Mono.just(new DefaultDataBufferFactory().wrap(example.getBytes(StandardCharsets.UTF_8))));
     }
 {{/reactive}}
-}
+}

modules/openapi-generator/src/main/resources/JavaSpring/libraries/spring-boot/openapi2SpringBoot.mustache

@@ -41,7 +41,7 @@ public class OpenAPI2SpringBoot implements CommandLineRunner {
         new SpringApplication(OpenAPI2SpringBoot.class).run(args);
     }
 
-    class ExitException extends RuntimeException implements ExitCodeGenerator {
+    static class ExitException extends RuntimeException implements ExitCodeGenerator {
         private static final long serialVersionUID = 1L;
 
         @Override

samples/client/petstore/spring-stubs/src/main/java/org/openapitools/api/ApiUtil.java

@@ -16,4 +16,4 @@ public class ApiUtil {
             throw new RuntimeException(e);
         }
     }
-}
+}

samples/server/petstore/spring-mvc-j8-async/src/main/java/org/openapitools/api/ApiUtil.java

@@ -16,4 +16,4 @@ public class ApiUtil {
             throw new RuntimeException(e);
         }
     }
-}
+}

samples/server/petstore/spring-mvc-j8-localdatetime/src/main/java/org/openapitools/api/ApiUtil.java

@@ -16,4 +16,4 @@ public class ApiUtil {
             throw new RuntimeException(e);
         }
     }
-}
+}

samples/server/petstore/spring-mvc/src/main/java/org/openapitools/api/ApiUtil.java

@@ -16,4 +16,4 @@ public class ApiUtil {
             throw new RuntimeException(e);
         }
     }
-}
+}

samples/server/petstore/springboot-beanvalidation/src/main/java/org/openapitools/OpenAPI2SpringBoot.java

@@ -27,7 +27,7 @@ public class OpenAPI2SpringBoot implements CommandLineRunner {
         new SpringApplication(OpenAPI2SpringBoot.class).run(args);
     }
 
-    class ExitException extends RuntimeException implements ExitCodeGenerator {
+    static class ExitException extends RuntimeException implements ExitCodeGenerator {
         private static final long serialVersionUID = 1L;
 
         @Override

samples/server/petstore/springboot-beanvalidation/src/main/java/org/openapitools/api/ApiUtil.java

@@ -16,4 +16,4 @@ public class ApiUtil {
             throw new RuntimeException(e);
         }
     }
-}
+}

samples/server/petstore/springboot-delegate-j8/src/main/java/org/openapitools/OpenAPI2SpringBoot.java

@@ -26,7 +26,7 @@ public class OpenAPI2SpringBoot implements CommandLineRunner {
         new SpringApplication(OpenAPI2SpringBoot.class).run(args);
     }
 
-    class ExitException extends RuntimeException implements ExitCodeGenerator {
+    static class ExitException extends RuntimeException implements ExitCodeGenerator {
         private static final long serialVersionUID = 1L;
 
         @Override

samples/server/petstore/springboot-delegate-j8/src/main/java/org/openapitools/api/ApiUtil.java

@@ -16,4 +16,4 @@ public class ApiUtil {
             throw new RuntimeException(e);
         }
     }
-}
+}

samples/server/petstore/springboot-delegate/src/main/java/org/openapitools/OpenAPI2SpringBoot.java

@@ -27,7 +27,7 @@ public class OpenAPI2SpringBoot implements CommandLineRunner {
         new SpringApplication(OpenAPI2SpringBoot.class).run(args);
     }
 
-    class ExitException extends RuntimeException implements ExitCodeGenerator {
+    static class ExitException extends RuntimeException implements ExitCodeGenerator {
         private static final long serialVersionUID = 1L;
 
         @Override

samples/server/petstore/springboot-delegate/src/main/java/org/openapitools/api/ApiUtil.java

@@ -16,4 +16,4 @@ public class ApiUtil {
             throw new RuntimeException(e);
         }
     }
-}
+}

samples/server/petstore/springboot-implicitHeaders/src/main/java/org/openapitools/OpenAPI2SpringBoot.java

@@ -26,7 +26,7 @@ public class OpenAPI2SpringBoot implements CommandLineRunner {
         new SpringApplication(OpenAPI2SpringBoot.class).run(args);
     }
 
-    class ExitException extends RuntimeException implements ExitCodeGenerator {
+    static class ExitException extends RuntimeException implements ExitCodeGenerator {
         private static final long serialVersionUID = 1L;
 
         @Override

samples/server/petstore/springboot-implicitHeaders/src/main/java/org/openapitools/api/ApiUtil.java

@@ -16,4 +16,4 @@ public class ApiUtil {
             throw new RuntimeException(e);
         }
     }
-}
+}

samples/server/petstore/springboot-reactive/src/main/java/org/openapitools/OpenAPI2SpringBoot.java

@@ -27,7 +27,7 @@ public class OpenAPI2SpringBoot implements CommandLineRunner {
         new SpringApplication(OpenAPI2SpringBoot.class).run(args);
     }
 
-    class ExitException extends RuntimeException implements ExitCodeGenerator {
+    static class ExitException extends RuntimeException implements ExitCodeGenerator {
         private static final long serialVersionUID = 1L;
 
         @Override

samples/server/petstore/springboot-reactive/src/main/java/org/openapitools/api/ApiUtil.java

@@ -1,11 +1,12 @@
 package org.openapitools.api;
 
+import java.nio.charset.StandardCharsets;
 import org.springframework.core.io.buffer.DefaultDataBufferFactory;
 import org.springframework.web.server.ServerWebExchange;
 import reactor.core.publisher.Mono;
 
 public class ApiUtil {
     public static Mono<Void> getExampleResponse(ServerWebExchange exchange, String example) {
-        return exchange.getResponse().writeWith(Mono.just(new DefaultDataBufferFactory().wrap(example.getBytes())));
+        return exchange.getResponse().writeWith(Mono.just(new DefaultDataBufferFactory().wrap(example.getBytes(StandardCharsets.UTF_8))));
     }
-}
+}

samples/server/petstore/springboot-useoptional/src/main/java/org/openapitools/OpenAPI2SpringBoot.java

@@ -26,7 +26,7 @@ public class OpenAPI2SpringBoot implements CommandLineRunner {
         new SpringApplication(OpenAPI2SpringBoot.class).run(args);
     }
 
-    class ExitException extends RuntimeException implements ExitCodeGenerator {
+    static class ExitException extends RuntimeException implements ExitCodeGenerator {
         private static final long serialVersionUID = 1L;
 
         @Override

samples/server/petstore/springboot-useoptional/src/main/java/org/openapitools/api/ApiUtil.java

@@ -16,4 +16,4 @@ public class ApiUtil {
             throw new RuntimeException(e);
         }
     }
-}
+}

samples/server/petstore/springboot-virtualan/src/main/java/org/openapitools/OpenAPI2SpringBoot.java

@@ -26,7 +26,7 @@ public class OpenAPI2SpringBoot implements CommandLineRunner {
         new SpringApplication(OpenAPI2SpringBoot.class).run(args);
     }
 
-    class ExitException extends RuntimeException implements ExitCodeGenerator {
+    static class ExitException extends RuntimeException implements ExitCodeGenerator {
         private static final long serialVersionUID = 1L;
 
         @Override

samples/server/petstore/springboot-virtualan/src/main/java/org/openapitools/virtualan/api/ApiUtil.java

@@ -16,4 +16,4 @@ public class ApiUtil {
             throw new RuntimeException(e);
         }
     }
-}
+}

samples/server/petstore/springboot/src/main/java/org/openapitools/OpenAPI2SpringBoot.java

@@ -26,7 +26,7 @@ public class OpenAPI2SpringBoot implements CommandLineRunner {
         new SpringApplication(OpenAPI2SpringBoot.class).run(args);
     }
 
-    class ExitException extends RuntimeException implements ExitCodeGenerator {
+    static class ExitException extends RuntimeException implements ExitCodeGenerator {
         private static final long serialVersionUID = 1L;
 
         @Override

samples/server/petstore/springboot/src/main/java/org/openapitools/api/ApiUtil.java

@@ -16,4 +16,4 @@ public class ApiUtil {
             throw new RuntimeException(e);
         }
     }
-}
+}