valitydev/limiter-proto
14
0
Fork 0
mirror of https://github.com/valitydev/limiter-proto.git synced 2024-11-06 00:35:18 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

TD-304: Transform body type into turnover specific metric (#19)

Browse Source 
* Deprecate weakly defined limit body type.
* Stop accepting body type in "legacy" configurator

Co-authored-by: Артем <WWW_cool@inbox.ru>
This commit is contained in:
Andrew Mayorov 2022-06-08 17:57:49 +03:00 committed by GitHub
parent d390910cd2
commit 6723e86215
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 41 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
proto/configurator.thrift
View File

@ -9,7 +9,6 @@ typedef base.ID LimitName
typedef limiter_config.LimitConfigID LimitConfigID
typedef limiter_config.ShardSize ShardSize
typedef limiter_config.LimitConfig LimitConfig
typedef limiter_config.LimitBodyType LimitBodyType
typedef limiter_config.OperationLimitBehaviour OperationLimitBehaviour
struct LimitCreateParams {
@ -18,7 +17,6 @@ struct LimitCreateParams {
/** Идентификатор набора настроек создаваемого лимата, в будущем идентификатор заменит структура конфигурации */
3: optional LimitName name
4: optional string description
5: optional LimitBodyType body_type
6: optional OperationLimitBehaviour op_behaviour
}

55
proto/limiter_config.thrift
View File

@ -17,7 +17,6 @@ typedef base.CurrencySymbolicCode CurrencySymbolicCode
struct LimitConfigParams {
1: required LimitConfigID id
2: required LimitBodyType body_type
3: required Timestamp started_at
4: required ShardSize shard_size
5: required time_range.TimeRangeType time_range_type
@ -32,7 +31,6 @@ struct LimitConfig {
1: required LimitConfigID id
2: required string processor_type
3: required Timestamp created_at
4: required LimitBodyType body_type
5: required Timestamp started_at
6: required ShardSize shard_size
7: required time_range.TimeRangeType time_range_type
@ -41,6 +39,9 @@ struct LimitConfig {
9: optional LimitScope scope
10: optional string description
12: optional OperationLimitBehaviour op_behaviour
// deprecated
4: optional LimitBodyType body_type_deprecated
}
struct OperationLimitBehaviour {
@ -55,22 +56,38 @@ union OperationBehaviour {
struct Subtraction {}
struct Addition {}
union LimitBodyType {
1: LimitBodyTypeAmount amount
2: LimitBodyTypeCash cash
}
struct LimitBodyTypeAmount {}
struct LimitBodyTypeCash {
1: required CurrencySymbolicCode currency
}
union LimitType {
1: LimitTypeTurnover turnover
}
struct LimitTypeTurnover {}
struct LimitTypeTurnover {
/**
* Metric to account turnover with.
* If undefined, equivalent to specifying `LimitTurnoverNumber`.
*/
1: optional LimitTurnoverMetric metric
}
union LimitTurnoverMetric {
/**
* Measure turnover over number of operations.
*/
1: LimitTurnoverNumber number
/**
* Measure turnover over aggregate amount of operations denominated in a single currency.
* In the event operation's currency differs from limit's currency operation will be accounted
* with appropriate exchange rate fixed against operation's timestamp.
*/
2: LimitTurnoverAmount amount
}
struct LimitTurnoverNumber {}
struct LimitTurnoverAmount {
1: required CurrencySymbolicCode currency
}
union LimitScope {
@ -134,3 +151,13 @@ union Change {
struct CreatedChange {
1: required LimitConfig limit_config
}
/// Deprecated definitions
union LimitBodyType {
2: LimitBodyTypeCash cash
}
struct LimitBodyTypeCash {
1: required CurrencySymbolicCode currency
}