valitydev/hooker-clone
14
0
Fork 0
Code Issues Pull Requests 12 Actions Packages Projects Releases Wiki Activity

Fill parent id #26

Merged
inallyoung merged 1 commits from ft/fill_parent_id into master 2022-08-23 16:27:33 +00:00
Conversation 1 Commits 1 Files Changed 2 +2 -2
inallyoung commented 2022-08-23 16:23:50 +00:00 (Migrated from github.com)
Copy Link
No description provided.
codecov[bot] commented 2022-08-23 16:27:07 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #26 (ac3f1fc) into master (02a4309) will increase coverage by 1.97%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #26      +/-   ##
============================================
+ Coverage     61.99%   63.97%   +1.97%     
- Complexity      307      315       +8     
============================================
  Files            68       67       -1     
  Lines          1563     1560       -3     
  Branches        124      124              
============================================
+ Hits            969      998      +29     
+ Misses          529      503      -26     
+ Partials         65       59       -6
Impacted Files Coverage Δ
...java/dev/vality/hooker/utils/PaymentToolUtils.java 68.53% <ø> (+5.61%) ⬆️
...vality/hooker/converter/WebhookMessageBuilder.java 92.85% <100.00%> (ø)
...ev/vality/hooker/service/CustomerEventService.java 55.31% <100.00%> (ø)
...v/vality/hooker/service/InvoicingEventService.java 35.92% <100.00%> (+0.34%) ⬆️
...java/dev/vality/hooker/service/MessageService.java 95.23% <100.00%> (ø)
.../main/java/dev/vality/hooker/utils/ErrorUtils.java 59.32% <0.00%> (-1.70%) ⬇️
...a/dev/vality/hooker/converter/RefundConverter.java 77.77% <0.00%> (+3.70%) ⬆️
.../dev/vality/hooker/converter/PaymentConverter.java 79.06% <0.00%> (+30.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

# [Codecov](https://codecov.io/gh/valitydev/hooker/pull/26?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev) Report > Merging [#26](https://codecov.io/gh/valitydev/hooker/pull/26?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev) (ac3f1fc) into [master](https://codecov.io/gh/valitydev/hooker/commit/02a4309662e50696d48103b96310f3823bc75b85?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev) (02a4309) will **increase** coverage by `1.97%`. > The diff coverage is `100.00%`. ```diff @@ Coverage Diff @@ ## master #26 +/- ## ============================================ + Coverage 61.99% 63.97% +1.97% - Complexity 307 315 +8 ============================================ Files 68 67 -1 Lines 1563 1560 -3 Branches 124 124 ============================================ + Hits 969 998 +29 + Misses 529 503 -26 + Partials 65 59 -6 ``` | [Impacted Files](https://codecov.io/gh/valitydev/hooker/pull/26?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev) | Coverage Δ | | |---|---|---| | [...java/dev/vality/hooker/utils/PaymentToolUtils.java](https://codecov.io/gh/valitydev/hooker/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev#diff-c3JjL21haW4vamF2YS9kZXYvdmFsaXR5L2hvb2tlci91dGlscy9QYXltZW50VG9vbFV0aWxzLmphdmE=) | `68.53% <ø> (+5.61%)` | :arrow_up: | | [...vality/hooker/converter/WebhookMessageBuilder.java](https://codecov.io/gh/valitydev/hooker/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev#diff-c3JjL21haW4vamF2YS9kZXYvdmFsaXR5L2hvb2tlci9jb252ZXJ0ZXIvV2ViaG9va01lc3NhZ2VCdWlsZGVyLmphdmE=) | `92.85% <100.00%> (ø)` | | | [...ev/vality/hooker/service/CustomerEventService.java](https://codecov.io/gh/valitydev/hooker/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev#diff-c3JjL21haW4vamF2YS9kZXYvdmFsaXR5L2hvb2tlci9zZXJ2aWNlL0N1c3RvbWVyRXZlbnRTZXJ2aWNlLmphdmE=) | `55.31% <100.00%> (ø)` | | | [...v/vality/hooker/service/InvoicingEventService.java](https://codecov.io/gh/valitydev/hooker/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev#diff-c3JjL21haW4vamF2YS9kZXYvdmFsaXR5L2hvb2tlci9zZXJ2aWNlL0ludm9pY2luZ0V2ZW50U2VydmljZS5qYXZh) | `35.92% <100.00%> (+0.34%)` | :arrow_up: | | [...java/dev/vality/hooker/service/MessageService.java](https://codecov.io/gh/valitydev/hooker/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev#diff-c3JjL21haW4vamF2YS9kZXYvdmFsaXR5L2hvb2tlci9zZXJ2aWNlL01lc3NhZ2VTZXJ2aWNlLmphdmE=) | `95.23% <100.00%> (ø)` | | | [.../main/java/dev/vality/hooker/utils/ErrorUtils.java](https://codecov.io/gh/valitydev/hooker/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev#diff-c3JjL21haW4vamF2YS9kZXYvdmFsaXR5L2hvb2tlci91dGlscy9FcnJvclV0aWxzLmphdmE=) | `59.32% <0.00%> (-1.70%)` | :arrow_down: | | [...a/dev/vality/hooker/converter/RefundConverter.java](https://codecov.io/gh/valitydev/hooker/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev#diff-c3JjL21haW4vamF2YS9kZXYvdmFsaXR5L2hvb2tlci9jb252ZXJ0ZXIvUmVmdW5kQ29udmVydGVyLmphdmE=) | `77.77% <0.00%> (+3.70%)` | :arrow_up: | | [.../dev/vality/hooker/converter/PaymentConverter.java](https://codecov.io/gh/valitydev/hooker/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev#diff-c3JjL21haW4vamF2YS9kZXYvdmFsaXR5L2hvb2tlci9jb252ZXJ0ZXIvUGF5bWVudENvbnZlcnRlci5qYXZh) | `79.06% <0.00%> (+30.23%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev)
karle0wne (Migrated from github.com) approved these changes 2022-08-23 16:27:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
karle0wne
Labels
Clear labels   
allstar

   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
sync

   
wontfix

This will not be worked on

No Label
allstar
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
sync
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: valitydev/hooker-clone#26
No description provided.
Delete Branch "ft/fill_parent_id"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?