valitydev/hooker-clone
14
0
Fork 0
Code Issues Pull Requests 12 Actions Packages Projects Releases Wiki Activity

TD-278::trying to fix metrics export #20

Merged
ivnmrtk merged 1 commits from fix/TD-278 into master 2022-04-21 14:20:38 +00:00
Conversation 1 Commits 1 Files Changed 1 -5
ivnmrtk commented 2022-04-21 14:01:32 +00:00 (Migrated from github.com)
Copy Link
No description provided.
echerniak (Migrated from github.com) reviewed 2022-04-21 14:01:32 +00:00
codecov[bot] commented 2022-04-21 14:04:19 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #20 (2ab27db) into master (83accfc) will decrease coverage by 0.51%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #20      +/-   ##
============================================
- Coverage     64.61%   64.10%   -0.52%     
+ Complexity      315      312       -3     
============================================
  Files            68       68              
  Lines          1563     1563              
  Branches        124      124              
============================================
- Hits           1010     1002       -8     
- Misses          490      499       +9     
+ Partials         63       62       -1
Impacted Files Coverage Δ
.../main/java/dev/vality/hooker/utils/ErrorUtils.java 59.32% <0.00%> (-16.95%) ⬇️
...ity/hooker/converter/CustomerBindingConverter.java 93.33% <0.00%> (-6.67%) ⬇️
...java/dev/vality/hooker/utils/PaymentToolUtils.java 73.03% <0.00%> (ø)
...v/vality/hooker/service/InvoicingEventService.java 35.57% <0.00%> (+1.92%) ⬆️
.../dev/vality/hooker/converter/InvoiceConverter.java 61.53% <0.00%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83accfc...2ab27db. Read the comment docs.

# [Codecov](https://codecov.io/gh/valitydev/hooker/pull/20?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev) Report > Merging [#20](https://codecov.io/gh/valitydev/hooker/pull/20?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev) (2ab27db) into [master](https://codecov.io/gh/valitydev/hooker/commit/83accfc7586e3a56bed2811f9e0ee2defceb719a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev) (83accfc) will **decrease** coverage by `0.51%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #20 +/- ## ============================================ - Coverage 64.61% 64.10% -0.52% + Complexity 315 312 -3 ============================================ Files 68 68 Lines 1563 1563 Branches 124 124 ============================================ - Hits 1010 1002 -8 - Misses 490 499 +9 + Partials 63 62 -1 ``` | [Impacted Files](https://codecov.io/gh/valitydev/hooker/pull/20?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev) | Coverage Δ | | |---|---|---| | [.../main/java/dev/vality/hooker/utils/ErrorUtils.java](https://codecov.io/gh/valitydev/hooker/pull/20/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev#diff-c3JjL21haW4vamF2YS9kZXYvdmFsaXR5L2hvb2tlci91dGlscy9FcnJvclV0aWxzLmphdmE=) | `59.32% <0.00%> (-16.95%)` | :arrow_down: | | [...ity/hooker/converter/CustomerBindingConverter.java](https://codecov.io/gh/valitydev/hooker/pull/20/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev#diff-c3JjL21haW4vamF2YS9kZXYvdmFsaXR5L2hvb2tlci9jb252ZXJ0ZXIvQ3VzdG9tZXJCaW5kaW5nQ29udmVydGVyLmphdmE=) | `93.33% <0.00%> (-6.67%)` | :arrow_down: | | [...java/dev/vality/hooker/utils/PaymentToolUtils.java](https://codecov.io/gh/valitydev/hooker/pull/20/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev#diff-c3JjL21haW4vamF2YS9kZXYvdmFsaXR5L2hvb2tlci91dGlscy9QYXltZW50VG9vbFV0aWxzLmphdmE=) | `73.03% <0.00%> (ø)` | | | [...v/vality/hooker/service/InvoicingEventService.java](https://codecov.io/gh/valitydev/hooker/pull/20/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev#diff-c3JjL21haW4vamF2YS9kZXYvdmFsaXR5L2hvb2tlci9zZXJ2aWNlL0ludm9pY2luZ0V2ZW50U2VydmljZS5qYXZh) | `35.57% <0.00%> (+1.92%)` | :arrow_up: | | [.../dev/vality/hooker/converter/InvoiceConverter.java](https://codecov.io/gh/valitydev/hooker/pull/20/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev#diff-c3JjL21haW4vamF2YS9kZXYvdmFsaXR5L2hvb2tlci9jb252ZXJ0ZXIvSW52b2ljZUNvbnZlcnRlci5qYXZh) | `61.53% <0.00%> (+3.84%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/valitydev/hooker/pull/20?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/valitydev/hooker/pull/20?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev). Last update [83accfc...2ab27db](https://codecov.io/gh/valitydev/hooker/pull/20?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valitydev).
mr-impossibru (Migrated from github.com) approved these changes 2022-04-21 14:19:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
echerniak
mr-impossibru
Labels
Clear labels   
allstar

   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
sync

   
wontfix

This will not be worked on

No Label
allstar
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
sync
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: valitydev/hooker-clone#20
No description provided.
Delete Branch "fix/TD-278"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?