diff --git a/.github/settings.yml b/.github/settings.yml new file mode 100644 index 0000000..9267e7d --- /dev/null +++ b/.github/settings.yml @@ -0,0 +1,2 @@ +# These settings are synced to GitHub by https://probot.github.io/apps/settings/ +_extends: .github diff --git a/.github/workflows/basic-linters.yml b/.github/workflows/basic-linters.yml new file mode 100644 index 0000000..6114f14 --- /dev/null +++ b/.github/workflows/basic-linters.yml @@ -0,0 +1,10 @@ +name: Vality basic linters + +on: + pull_request: + branches: + - "*" + +jobs: + lint: + uses: valitydev/base-workflows/.github/workflows/basic-linters.yml@v1 diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7769317..424e109 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,4 +1,4 @@ -name: Maven Build Artifact +name: Build Maven Artifact on: pull_request: @@ -7,6 +7,4 @@ on: jobs: build: - uses: valitydev/java-workflow/.github/workflows/maven-service-build.yml@v1 - with: - ignore-coverage: true \ No newline at end of file + uses: valitydev/java-workflow/.github/workflows/maven-service-build.yml@v2 diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 9a86c43..a4192d7 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -4,11 +4,10 @@ on: push: branches: - 'master' - - 'main' jobs: - deploy: - uses: valitydev/java-workflow/.github/workflows/maven-service-deploy.yml@v1 + build-and-deploy: + uses: valitydev/java-workflow/.github/workflows/maven-service-deploy.yml@v2 secrets: github-token: ${{ secrets.GITHUB_TOKEN }} - mm-webhook-url: ${{ secrets.MATTERMOST_WEBHOOK_URL }} \ No newline at end of file + mm-webhook-url: ${{ secrets.MATTERMOST_WEBHOOK_URL }} diff --git a/.github/workflows/settings.yml b/.github/workflows/settings.yml new file mode 100644 index 0000000..9267e7d --- /dev/null +++ b/.github/workflows/settings.yml @@ -0,0 +1,2 @@ +# These settings are synced to GitHub by https://probot.github.io/apps/settings/ +_extends: .github diff --git a/pom.xml b/pom.xml index 85fbe78..ef8f690 100644 --- a/pom.xml +++ b/pom.xml @@ -6,7 +6,7 @@ dev.vality service-parent-pom - 1.0.18 + 2.0.4 fraudbusters-mg-connector @@ -25,8 +25,8 @@ UTF-8 1.21-e4784ab - 1.109-fa34434 - 1.143-711814e + 1.111-913e879 + 1.177-88e69a5 @@ -34,18 +34,22 @@ dev.vality.woody woody-thrift + 2.0.8 dev.vality shared-resources + 2.1.0 dev.vality.geck serializer + 1.0.2 dev.vality damsel + 1.646-7762f6c dev.vality @@ -108,6 +112,7 @@ org.projectlombok lombok + 1.18.32 org.apache.kafka @@ -206,6 +211,11 @@ + + org.apache.maven.plugins + maven-site-plugin + 3.7.1 + diff --git a/src/main/java/dev/vality/fraudbusters/mg/connector/converter/FistfulResourceToDomainResourceConverter.java b/src/main/java/dev/vality/fraudbusters/mg/connector/converter/FistfulResourceToDomainResourceConverter.java index a071408..1cfdf91 100644 --- a/src/main/java/dev/vality/fraudbusters/mg/connector/converter/FistfulResourceToDomainResourceConverter.java +++ b/src/main/java/dev/vality/fraudbusters/mg/connector/converter/FistfulResourceToDomainResourceConverter.java @@ -29,7 +29,7 @@ public class FistfulResourceToDomainResourceConverter } else if (fistfulResource.isSetCryptoWallet()) { CryptoWallet cryptoWallet = new CryptoWallet() .setId(fistfulResource.getCryptoWallet().getCryptoWallet().getId()) - .setCurrency(fistfulResource.getCryptoWallet().getCryptoWallet().getCurrency().name()); + .setCurrency(fistfulResource.getCryptoWallet().getCryptoWallet().getCurrency().id); resource.setCryptoWallet(cryptoWallet); } else if (fistfulResource.isSetDigitalWallet()) { DigitalWallet digitalWallet = new DigitalWallet() diff --git a/src/main/resources/application.yml b/src/main/resources/application.yml index 383c6c6..2f77004 100644 --- a/src/main/resources/application.yml +++ b/src/main/resources/application.yml @@ -1,11 +1,11 @@ server: - port: '@server.port@' + port: '${server.port}' management: security: flag: false server: - port: '@management.port@' + port: '${management.port}' metrics: export: statsd: @@ -27,7 +27,7 @@ management: spring: application: - name: '@project.name@' + name: '${project.name}' output: ansi: enabled: always @@ -45,7 +45,7 @@ spring: fixed.rate.timeout.ms: 60000 info: - version: '@project.version@' + version: '${project.version}' stage: dev service: diff --git a/src/test/java/dev/vality/fraudbusters/mg/connector/mapper/impl/WithdrawalBeanUtils.java b/src/test/java/dev/vality/fraudbusters/mg/connector/mapper/impl/WithdrawalBeanUtils.java index 54193a6..e8a62f6 100644 --- a/src/test/java/dev/vality/fraudbusters/mg/connector/mapper/impl/WithdrawalBeanUtils.java +++ b/src/test/java/dev/vality/fraudbusters/mg/connector/mapper/impl/WithdrawalBeanUtils.java @@ -24,7 +24,7 @@ public class WithdrawalBeanUtils { .setBin(InvoiceTestConstant.CARD_BIN) .setCategory(InvoiceTestConstant.CARD_CATEGORY) .setIssuerCountry(Residence.PAN) - .setPaymentSystem(new PaymentSystemRef(LegacyBankCardPaymentSystem.mastercard.name())) + .setPaymentSystem(new PaymentSystemRef("asd")) .setToken(InvoiceTestConstant.CARD_TOKEN_PROVIDER) .setMaskedPan(InvoiceTestConstant.CARD_MASKED_PAN) .setCardType(CardType.debit) diff --git a/src/test/java/dev/vality/fraudbusters/mg/connector/utils/BuildUtils.java b/src/test/java/dev/vality/fraudbusters/mg/connector/utils/BuildUtils.java index d9c30fa..059e8f9 100644 --- a/src/test/java/dev/vality/fraudbusters/mg/connector/utils/BuildUtils.java +++ b/src/test/java/dev/vality/fraudbusters/mg/connector/utils/BuildUtils.java @@ -30,8 +30,7 @@ public class BuildUtils { .setBin(InvoiceTestConstant.CARD_BIN) .setCategory(InvoiceTestConstant.CARD_CATEGORY) .setIssuerCountry(Residence.PAN) - .setPaymentSystem(new dev.vality.fistful.base.PaymentSystemRef( - dev.vality.fistful.base.LegacyBankCardPaymentSystem.mastercard.name())) + .setPaymentSystem(new dev.vality.fistful.base.PaymentSystemRef("mastercard")) .setToken(InvoiceTestConstant.CARD_TOKEN_PROVIDER) .setMaskedPan(InvoiceTestConstant.CARD_MASKED_PAN) .setCardType(CardType.debit) @@ -41,7 +40,7 @@ public class BuildUtils { public static dev.vality.fistful.base.CryptoWallet buildFistfulCryptoWallet() { dev.vality.fistful.base.CryptoWallet cryptoWallet = new dev.vality.fistful.base.CryptoWallet(); cryptoWallet.setId("id"); - cryptoWallet.setCurrency(dev.vality.fistful.base.CryptoCurrency.bitcoin); + cryptoWallet.setCurrency(new dev.vality.fistful.base.CryptoCurrencyRef("bitcoin")); return cryptoWallet; } @@ -342,9 +341,10 @@ public class BuildUtils { String paymentId, InvoicePaymentStatus paymentStatus, MockTBaseProcessor thriftBaseProcessor) throws IOException { - return thriftBaseProcessor.process( + dev.vality.damsel.domain.InvoicePayment process = thriftBaseProcessor.process( new dev.vality.damsel.domain.InvoicePayment(), - new TBaseHandler<>(dev.vality.damsel.domain.InvoicePayment.class)) + new TBaseHandler<>(dev.vality.damsel.domain.InvoicePayment.class)); + return process .setCreatedAt("2016-03-22T06:12:27Z") .setId(paymentId) .setOwnerId(partyId)