valitydev/dominant
14
0
Fork 0
mirror of https://github.com/valitydev/dominant.git synced 2024-11-06 02:25:17 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

CAPI-32 Fix protocol violation (#13)

Browse Source
This commit is contained in:
Artem Ocheredko 2016-10-18 23:04:09 +03:00 committed by Igor Savchuk
parent db64a67215
commit f3c72168d9
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
TODO.md
View File

@ -14,3 +14,4 @@
* Encode machine events and responses with a schema-aware protocol
* Thrift / compact protocol?
* Fix potential race when a `Repository` request getting processed earlier than the start machine request being issued.
* Don't go to the cache for getting `Head` reference

8
src/dmt_api_mg.erl
View File

@ -50,10 +50,11 @@ get_prev_commit(N) ->
get_history(Context) ->
get_history(undefined, undefined, Context).
%% TODO: change this interface to accept dmt:version only
-spec get_history(dmt:version() | undefined, pos_integer() | undefined, context()) ->
{dmt:history() | {error, version_not_found}, context()}.
get_history(After, Limit, Context) ->
Range = #'HistoryRange'{'after' = After, 'limit' = Limit},
Range = #'HistoryRange'{'after' = prepare_event_id(After), 'limit' = Limit},
try dmt_api_context:map(call('GetHistory', [?REF, Range], Context), fun read_history/1) catch
{{exception, #'EventNotFound'{}}, Context1} ->
{{error, version_not_found}, Context1}
@ -92,3 +93,8 @@ read_history([], History) ->
History;
read_history([#'Event'{id = Id, event_payload = BinaryPayload} | Rest], History) ->
read_history(Rest, History#{Id => binary_to_term(BinaryPayload)}).
prepare_event_id(ID) when is_integer(ID) andalso ID > 0 ->
ID;
prepare_event_id(_) ->
undefined.