IS-549: Bump packages (#308)

config/checkout-config.js

@@ -41,7 +41,7 @@ module.exports = {
                 { from: './src/appConfig.json', to: '..' },
                 { from: './src/locale/*.json', to: './locale', flatten: true }
             ],
-            { debug: 'warning' }
+            { logLevel: 'warn' }
         )
     ]
 };

config/samsung-pay-config.js

@@ -23,7 +23,7 @@ module.exports = {
         }),
         new CopyWebpackPlugin(
             [{ from: './src/samsung-pay-interaction/assets/js', to: './assets/samsung-pay-interaction/js' }],
-            { debug: 'warning' }
+            { logLevel: 'warn' }
         )
     ]
 };

lgtm.yml

@@ -0,0 +1,2 @@
+queries:
+    - exclude: src/app/samsung-pay-interaction/assets

package.json

@@ -50,7 +50,7 @@
     "fingerprintjs2": "~1.6.1",
     "ismobilejs": "~0.4.1",
     "libphonenumber-js": "1.1.4",
-    "lodash-es": "~4.17.5",
+    "lodash-es": "~4.17.15",
     "react": "~16.6.3",
     "react-dom": "~16.6.3",
     "react-redux": "~5.1.1",
@@ -83,8 +83,8 @@
     "babel-plugin-transform-es2015-modules-commonjs": "~6.26.2",
     "babel-preset-env": "~1.7.0",
     "cache-loader": "~2.0.1",
-    "compression-webpack-plugin": "~2.0.0",
-    "copy-webpack-plugin": "~4.6.0",
+    "compression-webpack-plugin": "~3.1.0",
+    "copy-webpack-plugin": "~5.1.1",
     "cross-origin-communicator": "git+ssh://git@github.com/rbkmoney/cross-origin-communicator.git#dc3209dab12fb5d745c21b72d10ebe567270a836",
     "css-loader": "~1.0.1",
     "file-loader": "~2.0.0",

src/app/components/app/modal-container/modal/form-container/button/button.tsx

@@ -1,5 +1,3 @@
-import * as React from 'react';
-
 import styled from 'checkout/styled-components';
 import { css } from 'checkout/styled-components';
 

src/app/components/app/modal-container/modal/form-container/card-form/fields/secure-code/secure-code.tsx

@@ -37,7 +37,7 @@ export const SecureCodeDef: React.FC<SecureCodeProps> = (props) => (
         name="secureCode"
         component={getCustomInput.bind(null, props)}
         validate={validateSecureCode}
-        normalize={(value, p, { cardNumber }) => formatCVC(value, cardNumber)}
+        normalize={(value, _p, { cardNumber }) => formatCVC(value, cardNumber)}
     />
 );
 

src/app/components/app/modal-container/modal/form-container/chevron-back/chevron-back.tsx

@@ -1,5 +1,4 @@
 import * as React from 'react';
-import { Omit } from 'react-redux';
 
 import { ChevronLeft } from 'checkout/components';
 import styled from 'checkout/styled-components';

src/app/components/app/modal-container/modal/form-container/numerable-list/list.tsx

@@ -1,5 +1,3 @@
-import * as React from 'react';
-
 import styled from 'checkout/styled-components';
 
 export const NumerableList = styled.ul`

src/app/components/app/modal-container/modal/form-container/payment-methods/payment-methods.tsx

@@ -44,21 +44,19 @@ class PaymentMethodsDef extends React.Component<PaymentMethodsProps, PaymentMeth
     componentWillMount() {
         const { methods } = this.props;
         const visibilityThreshold = 3;
-        const visibleMethods = methods.filter((m, i) => i < visibilityThreshold);
+        const visibleMethods = methods.filter((_m, i) => i < visibilityThreshold);
         this.setState({ visibleMethods });
         this.showAllMethods = this.showAllMethods.bind(this);
     }
 
-    componentDidUpdate(prevProps: PaymentMethodsProps, prevState: PaymentMethodsState) {
+    componentDidUpdate(_prevProps: PaymentMethodsProps, prevState: PaymentMethodsState) {
         if (prevState.visibleMethods !== this.state.visibleMethods) {
             this.props.setViewInfoHeight(this.formElement.clientHeight);
         }
     }
 
     showAllMethods() {
-        this.setState({
-            visibleMethods: this.props.methods
-        });
+        this.setState((_state, { methods }) => ({ visibleMethods: methods }));
     }
 
     render() {

src/app/components/app/modal-container/modal/form-container/result-form/make-content/make-from-invoice-change.tsx

@@ -1,4 +1,3 @@
-import * as React from 'react';
 import { InvoiceEvent, InvoiceStatusChanged, InvoiceStatuses, LogicError, LogicErrorCode } from 'checkout/backend';
 import { Locale } from 'checkout/locale';
 import { ResultFormContent, ResultFormType } from './result-form-content';

src/app/components/app/modal-container/modal/form-container/result-form/make-content/make-from-payment-change.tsx

@@ -1,4 +1,3 @@
-import * as React from 'react';
 import { Locale } from 'checkout/locale';
 import { InvoiceEvent, LogicError, PaymentError, PaymentStatusChanged, PaymentStatuses } from 'checkout/backend';
 import { ResultFormContent } from './result-form-content';

src/app/components/app/modal-container/modal/form-container/result-form/result-form-props.ts

@@ -1,5 +1,5 @@
 import { Locale } from 'checkout/locale';
-import { ModelState, ResultState, ResultFormInfo, FormInfo, EventsState } from 'checkout/state';
+import { ResultState, ResultFormInfo, FormInfo, EventsState } from 'checkout/state';
 import { LogicError } from 'checkout/backend';
 import { IntegrationType } from 'checkout/config';
 

src/app/components/ui/link/link.tsx

@@ -1,5 +1,3 @@
-import * as React from 'react';
-
 import styled from 'checkout/styled-components';
 
 export const Link = styled.a`

src/app/sagas/amount-info/get-amount-from-single-line.spec.ts

@@ -1,4 +1,3 @@
-import { InvoiceTemplateLineCostFixed } from 'checkout/backend';
 import { getAmountFromSingleLine } from './get-amount-from-single-line';
 import { AmountInfoStatus } from 'checkout/state';
 

src/app/sagas/initialize-app/check-init-config/check-bank-card.ts

@@ -15,9 +15,6 @@ const checkForInvoiceAndTemplate = (paymentMethods: PaymentMethod[]): CheckResul
 
 export const checkBankCard = (initConfig: InitConfig, paymentMethods: PaymentMethod[]): CheckResult => {
     const { bankCard, googlePay, applePay, samsungPay, wallets, terminals, integrationType } = initConfig;
-    if (bankCard) {
-        return { available: true };
-    }
     if (!(bankCard || wallets || terminals || googlePay || samsungPay || applePay)) {
         return {
             available: false,
@@ -25,6 +22,9 @@ export const checkBankCard = (initConfig: InitConfig, paymentMethods: PaymentMet
             message: 'You can not disable all payment methods.'
         };
     }
+    if (bankCard) {
+        return { available: true };
+    }
     switch (integrationType) {
         case IntegrationType.invoiceTemplate:
         case IntegrationType.invoice:

src/app/sagas/initialize-app/initialize-available-payment-methods/bank-card-to-methods/is-ready-to-google-pay.ts

@@ -18,7 +18,7 @@ async function isReadyToPay(): Promise<boolean> {
          */
         const { result } = (await Promise.race([
             paymentsClient.isReadyToPay({ allowedPaymentMethods }),
-            new Promise((res, rej) => setTimeout(() => rej(new Error('timeout')), 3000))
+            new Promise((_res, rej) => setTimeout(() => rej(new Error('timeout')), 3000))
         ])) as ReadyToPayResponse;
         return result;
     } catch (e) {
@@ -27,7 +27,7 @@ async function isReadyToPay(): Promise<boolean> {
     }
 }
 
-export function* isReadyToGooglePay(amountInfo: AmountInfoState): Iterator<CallEffect | boolean> {
+export function* isReadyToGooglePay(_amountInfo: AmountInfoState): Iterator<CallEffect | boolean> {
     if (yield call(loadThirdPartLib, 'https://pay.google.com/gp/p/js/pay.js')) {
         return yield call(isReadyToPay);
     }

src/app/sagas/initialize-app/initialize-modal/initialize-modal.ts

@@ -1,5 +1,5 @@
 import { call, CallEffect, put, PutEffect } from 'redux-saga/effects';
-import { PaymentMethod, ModelState, EventsState } from 'checkout/state';
+import { PaymentMethod, EventsState } from 'checkout/state';
 import { InitializeModalCompleted, TypeKeys } from 'checkout/actions';
 import { InitConfig, IntegrationType } from 'checkout/config';
 import { toInitialState } from './to-initial-state';

src/app/stub-transport.ts

@@ -1,7 +1,7 @@
 import { Transport } from 'cross-origin-communicator';
 
 export class StubTransport implements Transport {
-    emit(eventName: string, data?: object) {
+    emit(_eventName: string, data?: object) {
         console.info('transport stub emit: ', name, data);
     }
 

src/initializer/html-integration.ts

@@ -7,7 +7,7 @@ const getOuterForm = (element: HTMLScriptElement) => {
 };
 
 const prepareUserConfig = (element: HTMLScriptElement): object => ({
-    ...mapKeys(element.dataset, (value, key) => key.replace('Id', 'ID')),
+    ...mapKeys(element.dataset, (_value, key) => key.replace('Id', 'ID')),
     finished: () => {
         const outerForm = getOuterForm(element);
         if (outerForm) {

src/locale/is-ie.ts

@@ -1 +1,2 @@
+// lgtm[js/conditional-comment]
 export const isIE: boolean = /*@cc_on!@*/ false || (!!document as any).documentMode;

tsconfig.json

@@ -12,7 +12,9 @@
         "paths": {
             "checkout/*": ["./src/app/*", "./src/locale/*"]
         },
-        "pretty": true
+        "pretty": true,
+        "noUnusedLocals": true,
+        "noUnusedParameters": true
     },
     "include": ["./src/**/*", "./types/**/*"]
 }

tslint.json

@@ -11,6 +11,15 @@
         "no-namespace": false,
         "jsx-alignment": false,
         "jsx-no-multiline-js": false,
-        "jsx-no-lambda": false
+        "jsx-no-lambda": false,
+        "variable-name": {
+            "options": [
+                "ban-keywords",
+                "check-format",
+                "allow-leading-underscore",
+                "allow-pascal-case",
+                "require-const-for-all-caps"
+            ]
+        }
     }
 }