valitydev/bouncer
14
0
Fork 0
mirror of https://github.com/valitydev/bouncer.git synced 2024-11-06 02:15:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't audit-log 'undefined' when no restrictions (#17)

Browse Source
This commit is contained in:
Andrew Mayorov 2021-02-04 15:47:19 +03:00 committed by GitHub
parent 85c7edeb6e
commit db9721bf71
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/bouncer_audit_log.erl
View File

@ -214,12 +214,11 @@ get_beat_metadata({judgement, Event}) ->
event => started
};
{completed, {Resolution, Assertions}} ->
#{
encode_restrictions(Resolution, #{
event => completed,
resolution => encode_resolution(Resolution),
assertions => lists:map(fun encode_assertion/1, Assertions),
restrictions => encode_restrictions(Resolution)
};
assertions => lists:map(fun encode_assertion/1, Assertions)
});
{failed, Error} ->
#{
event => failed,
@ -234,10 +233,10 @@ encode_resolution({restricted, _Restrictions}) -> <<"restricted">>.
%% NOTE
%% I judged adding restrictions parsing to be not worth it for audit log
encode_restrictions({restricted, Restrictions}) ->
Restrictions;
encode_restrictions(_) ->
undefined.
encode_restrictions({restricted, Restrictions}, Acc) ->
Acc#{restrictions => Restrictions};
encode_restrictions(_, Acc) ->
Acc.
encode_assertion({Code, Details}) ->
#{code => Code, details => Details}.