##### ISSUE TYPE
- Feature Pull Request
##### SUMMARY
Allow to set deployment annotations in helm chart.
Fixes#536
##### Remarks
I hesitated to use `extraAnnotations`, but when I look at other official helm charts most of the time they use different values for pods and deployments annotations.
Imho we should also rename `extraAnnotations` to `podAnnotations` but would be a breaking change so I left it as it was.
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Docs Pull Request
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Updated the participation to hacktoberfest 2021 in the Readme.
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
PR comment; and describe briefly what the change does.
-->
<!--- Please list dependencies added with your change also -->
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
##### ISSUE TYPE
- Bug fix Pull Request
##### SUMMARY
New goreleaser versions don't allow builds with "latest" tags. This PR pins the goreleaser version in CI to prevent it from failure.
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
##### ISSUE TYPE
- Bug fix Pull Request
##### SUMMARY
CI is failing due to go mod issues related to golang.org/x pkg. Update the dep to fix the build errors
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug fix Pull Request
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
This fetches the current latest stable kubectl directly from the upstream.
An alternate approach would be to copy from `rancher/kubectl` but that requires explicit versioning.
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
PR comment; and describe briefly what the change does.
-->
<!--- Please list dependencies added with your change also -->
Fixes#516
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug fix Pull Request
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
This fixes a panic when running a command with an allowed verb but without a resource. For example: `@Botkube get`.
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
PR comment; and describe briefly what the change does.
-->
<!--- Please list dependencies added with your change also -->
##### ISSUE TYPE
- Feature Pull Request
##### SUMMARY
This pull request is for changing registry from Docker hub to Github container registry. After acceptance of this PR all the new images will be pushed to github container registry as well as helm chart and other deployment chart will point to same github registry.
Fixes#432
* Allow skipping certs validation of Elastic
Allow user to skip certificate validation when connecting to the
Elasticsearch cluster (opt-in). It permits to use botkube with clusters
that don't have certificates signed by a CA that is trusted by the
botkube image, it often happens with clusters that are for internal use
only.
See #485
Co-Authored-By: Carmine Di Monaco <carmine.dimonaco@computer.org>
* Update go.sum
* Add the default value of skipTLSVerify in deploy manifests
Co-authored-by: David Costa <david@zarel.net>
* Add skipTLSVerify elasticsearch option to helm chart
Co-authored-by: David Costa <david@zarel.net>
* Bool instead of boolean in helm chart docs for skipTLSVerify elastic
Co-authored-by: David Costa <david@zarel.net>
Co-authored-by: Carmine Di Monaco <carmine.dimonaco@computer.org>
Co-authored-by: Carmine Di Monaco <carmine.dimonaco@gmail.com>
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Docs Pull Request
##### SUMMARY
We wanted to add `updateSetting` for an annotation from the Kubernetes Apps SIG. This annotation contains dots and slashes. I wasn't sure which field to use, so I've updated the test to make it very clear that it requires the syntax of number 1:
1. `metadata.annotations.app\.kubernetes\.io\/version`
2. `metadata.annotations["app.kubernetes.io/version"]`
<!--- Please list dependencies added with your change also -->
Fixes #XXX
##### ISSUE TYPE
- Feature Pull Request
##### SUMMARY
Change add CodeQL workflow which scans and reports vulnerabilities in Go source code. It would be reported under the Security tab of the repository.
##### ISSUE TYPE
- Feature Pull Request
##### SUMMARY
I have implemented in the helm chart the possibility to pass the communication config as a k8s secret and configure in the value files via an existingSecret. It can be configured in the values file via these:
```yaml
communications:
existingSecret: false
existingSecretName: ""
```
Fixes#319#211#226#233
##### ISSUE TYPE
- Bug fix Pull Request
##### SUMMARY
Allow Configuration of Mattermost user and fixes BUG with getUser() if its not the "BotKube" default user.
Fixes#245
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug fix Pull Request
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
The software notifies on the channel if you are using the updated version of BotKube or not. To do this, use the BOTKUBE_VERSION variable which is set up with the `.Chart.Version` value which does not necessarily correspond to the version of the software running on the cluster. The actual version of the software that runs is the one that comes from `.Values.image.tag`.
<img width="616" alt="Screenshot 2021-05-11 at 09 51 39" src="https://user-images.githubusercontent.com/36044817/117780091-96588700-b23f-11eb-984c-b6555b1f3629.png">
Adding privileged, allowPrivilegedEscalation and readOnlyRootFilesystem to container security context, also adjusting deployment.yaml
##### ISSUE TYPE
- Feature Pull Request
##### SUMMARY
Need to add more granular control to the container's security context. I'd need to add these extra attributes as well as liveness and readiness probes. Is this is something that can be included in the code?
thank you !
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Feature Pull Request
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Added code block in helmcharts to support imagepullsecrets
as a best practise changed the imagePullPolicy to "IfNotPresent"
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
PR comment; and describe briefly what the change does.
-->
<!--- Please list dependencies added with your change also -->
Fixes#471
This PR holds the step to check if you are running Kubernetes with support to the new ingress apiVersion.
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Feature Pull Request
- Bug fix Pull Request
- Docs Pull Request
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
PR comment; and describe briefly what the change does.
-->
<!--- Please list dependencies added with your change also -->
Fixes #XXX
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Feature Pull Request
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Capability to fetch AWS credentials from the EKS OIDC provider
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
PR comment; and describe briefly what the change does.
-->
<!--- Please list dependencies added with your change also -->
Fixes#462
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug fix Pull Request
##### SUMMARY
When clustername is passed to botkube from command and if that clustername contains valid domain then slack automatically adds <http:// to the url
eg.
if command is `@BotKube get pods --cluster-name xyz.alpha-sense.org` then in botkube we get cluster name as `<http://xyz.alpha-sense.org|xyz.alpha-sense.org>`
#### Solution:
Added small logic in executor code to remove the unwanted string
Fixes https://github.com/infracloudio/botkube/issues/460
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug fix Pull Request
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Resolved issue of DefaultNamespace value is not getting populated in config and appending default namespace if another namespace is already passed
##### ISSUE TYPE
- Bug fix Pull Request
##### SUMMARY
Apparently the wrong member was used to check the resource name. I don't
know how resillient this patch is, but it works for most of the part.
<!--- Please list dependencies added with your change also -->
Fixes#419
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Feature Pull Request
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Elasticsearch Indices will be created with timestamp suffix
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
PR comment; and describe briefly what the change does.
-->
<!--- Please list dependencies added with your change also -->
##### ISSUE TYPE
- Bug fix Pull Request
##### SUMMARY
The empty command `@BotKube` is managed in the executor.go file for having a identic behaviour on all intergrations but the Slack bot is handling it differently.
So I proposed a cleanup in this PR.
##### ISSUE TYPE
- Feature Pull Request
##### SUMMARY
adding support for botkube to interact in slack threads
I did update the test bash script that would not run on my zsh shell on my mac.
I Also wanted to add some unit tests but the Slack test server does not support thread messages.
Fixes#422
