valitydev/botkube
14
0
Fork 0
mirror of https://github.com/valitydev/botkube.git synced 2024-11-06 08:25:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Validate error events are skipped when error event is not configured in test_config (#418)

Browse Source 
Fixes part of #340
This commit is contained in:
Divya Rani 2020-10-30 15:51:10 +05:30 committed by GitHub
parent d5b3d6c2cd
commit d8d86604a4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
test/e2e/notifier/error/error.go
View File

@ -19,12 +19,19 @@ type context struct {
}
func (c *context) testSKipErrorEvent(t *testing.T) {
// Modifying AllowedEventKindsMap to remove error event for pod resource
delete(utils.AllowedEventKindsMap, utils.EventKind{Resource: "v1/pods", Namespace: "all", EventType: "error"})
// Modifying AllowedEventKindsMap to add error event for only dummy namespace and ignore everything
utils.AllowedEventKindsMap[utils.EventKind{Resource: "v1/pods", Namespace: "dummy", EventType: "error"}] = true
serviceEvent := utils.AllowedEventKindsMap[utils.EventKind{Resource: "v1/services", Namespace: "all", EventType: "error"}]
podEvent := utils.AllowedEventKindsMap[utils.EventKind{Resource: "v1/pods", Namespace: "all", EventType: "error"}]
// Modifying AllowedEventKindsMap to remove error event for pod resource
delete(utils.AllowedEventKindsMap, utils.EventKind{Resource: "v1/pods", Namespace: "all", EventType: "error"})
// Modifying AllowedEventKindsMap to remove error event for service resource
delete(utils.AllowedEventKindsMap, utils.EventKind{Resource: "v1/services", Namespace: "all", EventType: "error"})
tests := map[string]testutils.ErrorEvent{
"skip error event for resources not configured": {
// error event not allowed for Pod resources so event should be skipped
@ -40,6 +47,13 @@ func (c *context) testSKipErrorEvent(t *testing.T) {
Namespace: "test",
Specs: &v1.Pod{ObjectMeta: metav1.ObjectMeta{Name: "test-pod"}, Spec: v1.PodSpec{Containers: []v1.Container{{Name: "test-pod-container", Image: "tomcat:9.0.34"}}}},
},
"skip error event for resources not added in test_config": {
// error event should not be allowed for service resource so event should be skipped
GVR: schema.GroupVersionResource{Group: "", Version: "v1", Resource: "services"},
Kind: "Service",
Namespace: "test",
Specs: &v1.Service{ObjectMeta: metav1.ObjectMeta{Name: "test-service-error"}},
},
}
for name, test := range tests {
@ -51,8 +65,11 @@ func (c *context) testSKipErrorEvent(t *testing.T) {
})
}
// Resetting original configuration as per test_config
defer delete(utils.AllowedEventKindsMap, utils.EventKind{Resource: "v1/pods", Namespace: "dummy", EventType: "error"})
utils.AllowedEventKindsMap[utils.EventKind{Resource: "v1/pods", Namespace: "all", EventType: "error"}] = true
defer func() {
utils.AllowedEventKindsMap[utils.EventKind{Resource: "v1/services", Namespace: "all", EventType: "error"}] = serviceEvent
utils.AllowedEventKindsMap[utils.EventKind{Resource: "v1/pods", Namespace: "all", EventType: "error"}] = podEvent
delete(utils.AllowedEventKindsMap, utils.EventKind{Resource: "v1/pods", Namespace: "dummy", EventType: "error"})
}()
}
// Run tests