mirror of
https://github.com/empayre/fleet.git
synced 2024-11-06 08:55:24 +00:00
b65739f035
This should fix #16006. On Windows when a process is killed by the Task Manager, it is killed without any signaling, thus the osqueryd processes are left orphaned. Executing osqueryd (which we do to get host information) was failing because the lingering processes had a lock on the database file. The solution implemented in this PR is to kill any pre-existing osqueryd processes before running osqueryd. - [X] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. - [X] Manual QA for all new/changed functionality - For Orbit and Fleet Desktop changes: - [X] Manual QA must be performed in the three main OSs, macOS, Windows and Linux. - [X] Auto-update manual QA, from released version of component to new version (see [tools/tuf/test](../tools/tuf/test/README.md)). PS: I added a log of the stdout+stderr of osqueryd execution when such command fails to execute. (This helped me find the root cause.) ``` 2024-01-25T11:57:56-08:00 ERR getHostInfo via osquery output= stderr="E0125 11:57:56.744843 7860 shutdown.cpp:79] IO error: Failed to create lock file: C:\\Program Files\\Orbit\\osquery.db/LOCK: The process cannot access the file because it is being used by another process.\r\r\n" ``` PPS: I removed some unused exported methods in the `orbit/pkg/platform` package. |
||
|---|---|---|
| .. | ||
| .keep | ||
| 15689-add-mta-mode | ||
| 15963-fleetd-agent | ||
| 16006-kill-pre-existing-osqueryd-processes-at-startup | ||
| update-go | ||