mirror of
https://github.com/empayre/fleet.git
synced 2024-11-06 17:05:18 +00:00
cecb96e828
## Addresses #11856 Improve performance of the rendering of live query results by: - rendering the table on a set interval instead of with each new result - preventing redundant rerenders of various sorts Partial run, with memory leak: <img width="2552" alt="partial run with memory leak, after smaller optimizations, before debouncing queryResults" src="https://github.com/fleetdm/fleet/assets/61553566/5288bffb-6940-43da-9083-59adb4a25916"> Full run after debounce, no memory leak (10x improvement of max JS heap size): <img width="2559" alt="full run after debounce, no memory leak" src="https://github.com/fleetdm/fleet/assets/61553566/be056610-e7a5-4289-a433-1070cf016e83"> **NOTE** - there are further optimizations to try on this page, and the debounce interval can potentially be shortened to improve UX. In experimenting with that, it's not immediately clear what a good balance of UX / performance is. Since the customer seems keen to solve this, I think we should merge as-is and send them a demo build to confirm this fixes their problem, then iterate once they've confirmed it does. # Checklist for submitter If some of the following don't apply, delete the relevant line. - [x] Changes file added for user-visible changes in `changes/` - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Lucas Rodriguez <lucas@fleetdm.com> Co-authored-by: Jacob Shandling <jacob@fleetdm.com> Co-authored-by: Sarah Gillespie <sarah@fleetdm.com> |
||
|---|---|---|
| .. | ||
| ManageQueriesPage | ||
| QueryPage | ||