fleet/issue-15050-pluralize-query-deletion-activity-log at 4194c44131dafcf7a74f2a562b48ee3f6f960260 - fleet - example

empayre/fleet

mirror of https://github.com/empayre/fleet.git synced 2024-11-06 08:55:24 +00:00

Jordan Wright 04a572f542

Fix pluralization in the "delete multiple queries" activity log (#15099 )

### Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality

### Summary 

This PR creates a pluralized activity log in the case where a user
deletes multiple saved queries.

I had considered updating the default template to better support
pluralization, but when reviewing the various activity log types, I
think queries are the only type that would benefit from this. So I chose
the easier option here which felt less risky.

cc @sharon-fdm as the currently assigned person on the issue (just
trying to save y'all some cycles by contributing and slowly ramping up
on the codebase 😄)

ref: #15050 

### Test Plan

I added a unit test for this.

Additionally, I deleted multiple saved queries in my local installation.
Here's the resulting log, showing the proper pluralization:

<img width="1381" alt="Screenshot 2023-11-10 at 9 54 40 PM"
src="https://github.com/fleetdm/fleet/assets/1317288/f40414e2-7a9b-4478-b6cf-bb9d4ab6d8f0">

2023-11-17 12:22:47 -08:00

2 lines

75 B

Plaintext

Raw Blame History

- * Pluralize the activity log rendered when multiple queries were deleted