mirror of
https://github.com/empayre/fleet.git
synced 2024-11-06 08:55:24 +00:00
305392e7bb
related to #10441, inspired by the prior work done in https://github.com/kolide/fleet/pull/1360, this PR: 1. Adds a migration to use `utf8mb4_general_ci` as the default collation for the database and all the tables. From [MySQL's documentation][1]: > To change the table default character set and all character columns > (CHAR, VARCHAR, TEXT) to a new character set, use a statement like > this: > > ``` > ALTER TABLE tbl_name CONVERT TO CHARACTER SET charset_name; > ``` > The statement also changes the collation of all character columns. If > you specify no COLLATE clause to indicate which collation to use, the > statement uses default collation for the character set. 2. Changes the connection settings to use `utf8mb4_general_ci` as the default collation, from the [driver docs][2]: > Sets the collation used for client-server interaction on connection. In contrast to charset, collation does not issue additional queries. If the specified collation is unavailable on the target server, the connection will fail. [1]: https://dev.mysql.com/doc/refman/5.7/en/alter-table.html [2]: https://github.com/go-sql-driver/mysql **TODO:** discuss how we can enforce this, is setting the database default collation enough? should we add some kind of custom lint rule to all migrations? # Checklist for submitter If some of the following don't apply, delete the relevant line. - [x] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. See [Changes files](https://fleetdm.com/docs/contributing/committing-changes#changes-files) for more information. - [x] Added/updated tests - [x] Manual QA for all new/changed functionality |
||
|---|---|---|
| .. | ||
| .keep | ||
| 8129-fleet-errors-uuid-and-internal | ||
| 8186-fix-bug-with-docker-false-positive | ||
| 8411-jit-provisioning-roles | ||
| 9106-critical-icon-policy-table | ||
| 9132-orbit-enroll-set-osquery-db-to-retrieve-uuid | ||
| 9406-disk-encryption-activity-items | ||
| 9414-disk-encryption-banners | ||
| 9415-aggregate-mac-settings-indicators | ||
| 9486-pending-jobs-not-clearing-after-outage | ||
| 9515-log-instance-id | ||
| 9567-macos_settings-hosts-filter | ||
| 9753-fix-bug-software-link-tooltip | ||
| 9921-cis-win-10-2.3.10.x | ||
| 9924-cis-win-10-2.3.17.x | ||
| 9984-global-and-team-observers-can-view-team | ||
| 10104-policy-tab-click-bug | ||
| 10137-show-query-policy-results | ||
| 10138-cis-win10-9-3-x | ||
| 10147-cis-win-10-18.x.x | ||
| 10228-okta-config-values | ||
| 10271-dep-okta | ||
| 10299-mdm-no-abm | ||
| 10324-upsell-state | ||
| 10378-remove-attach-check | ||
| 10441-collations | ||
| 10456-add-more-distros-to-hostlinuxoss | ||
| bugfix-mdm-settings-documentation | ||
| bugfix-trigger-release-lock | ||
| fleetd-chrome | ||
| issue-9124-orbit-enroll-match-by-serial | ||
| issue-9400-add-disk-encryption-fleetctl-apply | ||
| issue-9402-9409-implement-UI-for-disk-encryption-on-mdm | ||
| issue-9433-support-modify-team-disk-encryption | ||
| issue-9435-disk-encryption-activities | ||
| issue-9437-add-host-disk-encryption-status | ||
| issue-9591-mdm-profiles-summary | ||
| issue-9596-mdm-profile-filter | ||
| issue-10126-mdm-info | ||
| issue-10136-cis-win-10-9-2-x | ||
| issue-10409-no-team-filter | ||
| issue-10409-support-no-teams-in-aggregated-stats | ||
| pin-dockerfiles | ||