fleet/server/datastore/mysql/software_test.go
Tomas Touceda c781058617
Fix build, add missing tests for cpe translations (#1631)
* Fix build, add missing tests for cpe translations

Also dont fail alltogether if there's one issue translating CPEs, log it and continue

* Make it once every hour again

* Use MATCH but escape strings
2021-08-11 14:52:09 -03:00

290 lines
8.3 KiB
Go

package mysql
import (
"strings"
"testing"
"time"
"github.com/fleetdm/fleet/v4/server/fleet"
"github.com/fleetdm/fleet/v4/server/test"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestSaveHostSoftware(t *testing.T) {
ds := CreateMySQLDS(t)
defer ds.Close()
host1 := test.NewHost(t, ds, "host1", "", "host1key", "host1uuid", time.Now())
host2 := test.NewHost(t, ds, "host2", "", "host2key", "host2uuid", time.Now())
soft1 := fleet.HostSoftware{
Modified: true,
Software: []fleet.Software{
{Name: "foo", Version: "0.0.1", Source: "chrome_extensions"},
{Name: "foo", Version: "0.0.3", Source: "chrome_extensions"},
},
}
host1.HostSoftware = soft1
soft2 := fleet.HostSoftware{
Modified: true,
Software: []fleet.Software{
{Name: "foo", Version: "0.0.2", Source: "chrome_extensions"},
{Name: "foo", Version: "0.0.3", Source: "chrome_extensions"},
{Name: "bar", Version: "0.0.3", Source: "deb_packages"},
},
}
host2.HostSoftware = soft2
err := ds.SaveHostSoftware(host1)
require.NoError(t, err)
err = ds.SaveHostSoftware(host2)
require.NoError(t, err)
err = ds.LoadHostSoftware(host1)
require.NoError(t, err)
assert.False(t, host1.HostSoftware.Modified)
test.ElementsMatchSkipID(t, soft1.Software, host1.HostSoftware.Software)
err = ds.LoadHostSoftware(host2)
require.NoError(t, err)
assert.False(t, host2.HostSoftware.Modified)
test.ElementsMatchSkipID(t, soft2.Software, host2.HostSoftware.Software)
soft1 = fleet.HostSoftware{
Modified: true,
Software: []fleet.Software{
{Name: "foo", Version: "0.0.1", Source: "chrome_extensions"},
{Name: "foo", Version: "0.0.3", Source: "chrome_extensions"},
{Name: "towel", Version: "42.0.0", Source: "apps"},
},
}
host1.HostSoftware = soft1
soft2 = fleet.HostSoftware{
Modified: true,
Software: []fleet.Software{},
}
host2.HostSoftware = soft2
err = ds.SaveHostSoftware(host1)
require.NoError(t, err)
err = ds.SaveHostSoftware(host2)
require.NoError(t, err)
err = ds.LoadHostSoftware(host1)
require.NoError(t, err)
assert.False(t, host1.HostSoftware.Modified)
test.ElementsMatchSkipID(t, soft1.Software, host1.HostSoftware.Software)
err = ds.LoadHostSoftware(host2)
require.NoError(t, err)
assert.False(t, host2.HostSoftware.Modified)
test.ElementsMatchSkipID(t, soft2.Software, host2.HostSoftware.Software)
soft1 = fleet.HostSoftware{
Modified: true,
Software: []fleet.Software{
{Name: "foo", Version: "0.0.3", Source: "chrome_extensions"},
{Name: "towel", Version: "42.0.0", Source: "apps"},
},
}
host1.HostSoftware = soft1
err = ds.SaveHostSoftware(host1)
require.NoError(t, err)
err = ds.LoadHostSoftware(host1)
require.NoError(t, err)
assert.False(t, host1.HostSoftware.Modified)
test.ElementsMatchSkipID(t, soft1.Software, host1.HostSoftware.Software)
}
func TestSoftwareCPE(t *testing.T) {
ds := CreateMySQLDS(t)
defer ds.Close()
host1 := test.NewHost(t, ds, "host1", "", "host1key", "host1uuid", time.Now())
soft1 := fleet.HostSoftware{
Modified: true,
Software: []fleet.Software{
{Name: "foo", Version: "0.0.1", Source: "chrome_extensions"},
{Name: "foo", Version: "0.0.3", Source: "chrome_extensions"},
},
}
host1.HostSoftware = soft1
err := ds.SaveHostSoftware(host1)
require.NoError(t, err)
iterator, err := ds.AllSoftwareWithoutCPEIterator()
require.NoError(t, err)
loops := 0
id := uint(0)
for iterator.Next() {
software, err := iterator.Value()
require.NoError(t, err)
require.NoError(t, iterator.Err())
require.NotEmpty(t, software.ID)
id = software.ID
require.NotEmpty(t, software.Name)
require.NotEmpty(t, software.Version)
require.NotEmpty(t, software.Source)
if loops > 2 {
t.Error("Looping through more software than we have")
}
loops++
}
assert.Equal(t, len(host1.Software), loops)
err = ds.AddCPEForSoftware(fleet.Software{ID: id}, "some:cpe")
require.NoError(t, err)
iterator, err = ds.AllSoftwareWithoutCPEIterator()
require.NoError(t, err)
loops = 0
for iterator.Next() {
software, err := iterator.Value()
require.NoError(t, err)
require.NoError(t, iterator.Err())
require.NotEmpty(t, software.ID)
require.NotEqual(t, id, software.ID)
require.NotEmpty(t, software.Name)
require.NotEmpty(t, software.Version)
require.NotEmpty(t, software.Source)
if loops > 1 {
t.Error("Looping through more software than we have")
}
loops++
}
assert.Equal(t, len(host1.Software)-1, loops)
}
func TestInsertCVEs(t *testing.T) {
ds := CreateMySQLDS(t)
defer ds.Close()
host := test.NewHost(t, ds, "host1", "", "host1key", "host1uuid", time.Now())
soft := fleet.HostSoftware{
Modified: true,
Software: []fleet.Software{
{Name: "foo", Version: "0.0.1", Source: "chrome_extensions"},
{Name: "foo", Version: "0.0.3", Source: "chrome_extensions"},
},
}
host.HostSoftware = soft
require.NoError(t, ds.SaveHostSoftware(host))
require.NoError(t, ds.LoadHostSoftware(host))
require.NoError(t, ds.AddCPEForSoftware(host.Software[0], "somecpe"))
require.NoError(t, ds.InsertCVEForCPE("cve-123-123-132", []string{"somecpe"}))
}
func TestHostSoftwareDuplicates(t *testing.T) {
ds := CreateMySQLDS(t)
defer ds.Close()
host1 := test.NewHost(t, ds, "host1", "", "host1key", "host1uuid", time.Now())
longName := strings.Repeat("a", 260)
incoming := make(map[string]bool)
soft2Key := softwareToUniqueString(fleet.Software{
Name: longName + "b",
Version: "0.0.1",
Source: "chrome_extension",
})
incoming[soft2Key] = true
tx, err := ds.db.Beginx()
require.NoError(t, err)
require.NoError(t, ds.insertNewInstalledHostSoftware(tx, host1.ID, make(map[string]uint), incoming))
require.NoError(t, tx.Commit())
incoming = make(map[string]bool)
soft3Key := softwareToUniqueString(fleet.Software{
Name: longName + "c",
Version: "0.0.1",
Source: "chrome_extension",
})
incoming[soft3Key] = true
tx, err = ds.db.Beginx()
require.NoError(t, err)
require.NoError(t, ds.insertNewInstalledHostSoftware(tx, host1.ID, make(map[string]uint), incoming))
require.NoError(t, tx.Commit())
}
func TestLoadSoftwareVulnerabilities(t *testing.T) {
ds := CreateMySQLDS(t)
defer ds.Close()
host := test.NewHost(t, ds, "host1", "", "host1key", "host1uuid", time.Now())
soft := fleet.HostSoftware{
Modified: true,
Software: []fleet.Software{
{Name: "foo", Version: "0.0.1", Source: "chrome_extensions"},
{Name: "bar", Version: "0.0.3", Source: "apps"},
{Name: "blah", Version: "1.0", Source: "apps"},
},
}
host.HostSoftware = soft
require.NoError(t, ds.SaveHostSoftware(host))
require.NoError(t, ds.LoadHostSoftware(host))
require.NoError(t, ds.AddCPEForSoftware(host.Software[0], "somecpe"))
require.NoError(t, ds.AddCPEForSoftware(host.Software[1], "someothercpewithoutvulns"))
require.NoError(t, ds.InsertCVEForCPE("cve-123-123-132", []string{"somecpe"}))
require.NoError(t, ds.InsertCVEForCPE("cve-321-321-321", []string{"somecpe"}))
require.NoError(t, ds.LoadHostSoftware(host))
assert.Equal(t, "somecpe", host.Software[0].GenerateCPE)
require.Len(t, host.Software[0].Vulnerabilities, 2)
assert.Equal(t, "cve-123-123-132", host.Software[0].Vulnerabilities[0].CVE)
assert.Equal(t,
"https://nvd.nist.gov/vuln/detail/cve-123-123-132", host.Software[0].Vulnerabilities[0].DetailsLink)
assert.Equal(t, "cve-321-321-321", host.Software[0].Vulnerabilities[1].CVE)
assert.Equal(t,
"https://nvd.nist.gov/vuln/detail/cve-321-321-321", host.Software[0].Vulnerabilities[1].DetailsLink)
assert.Equal(t, "someothercpewithoutvulns", host.Software[1].GenerateCPE)
require.Len(t, host.Software[1].Vulnerabilities, 0)
}
func TestAllCPEs(t *testing.T) {
ds := CreateMySQLDS(t)
defer ds.Close()
host := test.NewHost(t, ds, "host1", "", "host1key", "host1uuid", time.Now())
soft := fleet.HostSoftware{
Modified: true,
Software: []fleet.Software{
{Name: "foo", Version: "0.0.1", Source: "chrome_extensions"},
{Name: "bar", Version: "0.0.3", Source: "apps"},
{Name: "blah", Version: "1.0", Source: "apps"},
},
}
host.HostSoftware = soft
require.NoError(t, ds.SaveHostSoftware(host))
require.NoError(t, ds.LoadHostSoftware(host))
require.NoError(t, ds.AddCPEForSoftware(host.Software[0], "somecpe"))
require.NoError(t, ds.AddCPEForSoftware(host.Software[1], "someothercpewithoutvulns"))
cpes, err := ds.AllCPEs()
require.NoError(t, err)
assert.ElementsMatch(t, cpes, []string{"somecpe", "someothercpewithoutvulns"})
}