Commit Graph

2262 Commits

Author SHA1 Message Date
Luke Heath
c1f961ec30
Fix loading spinner not appearing when running a script (#15936) 2024-01-05 12:48:07 -06:00
Jacob Shandling
89e687545e
UI – Specify rendering condition for host > software > munki card (#15921)
## Addresses #15577 

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2024-01-04 13:31:02 -08:00
Jacob Shandling
87196f43c3
UI – sort case-insensitively and update default sort (#15808)
## Addresses #15253 

- sort case-insensitively in the query results (live), query report, and
host query report tables
- default to sorting by the host display name in the query results and
by `last_fetched` for the query report tables
- (unchanged) host query reports sort by the first column of the
results, since all `last_fetched` are the same

<img width="383" alt="Screenshot 2023-12-21 at 9 49 31 AM"
src="https://github.com/fleetdm/fleet/assets/61553566/2bb5ede1-c40e-4974-9079-4851650163cb">


## Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2024-01-04 11:26:01 -08:00
Jahziel Villasana-Espinoza
6dc9d2f6f0
fix: return better error when password is too long (#15875)
> Relevant issue: #15625

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
2024-01-03 17:24:28 -05:00
Victor Lyuboslavsky
0d74181757
On Host Details Policies page, removed callout box with a broken link. (#15854)
On Host Details Policies page, removed callout box with a broken link.
#15802

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
2024-01-03 15:12:57 -06:00
Jacob Shandling
3cc6556c4a
Handle edge case when parsing SQL abstract syntax tree to determine platform compatibility (#15806)
## Addresses #15035 

<img width="1455" alt="Screenshot 2023-12-21 at 8 11 27 AM"
src="https://github.com/fleetdm/fleet/assets/61553566/f1b17bf9-0c68-4119-9b45-559391b48293">

The bug stemmed from the presence of nodes of the following structure in
the SQL abstract syntax tree generated by the `sqlite-parser` package,
whos `.name` was incorrectly being assumed to be a `string` and included
as a table to check compatibility of. Since it is not actually a table,
this was disqualifying the entire query from compatibility with any OS:
<img width="253" alt="Screenshot 2023-12-21 at 8 31 38 AM"
src="https://github.com/fleetdm/fleet/assets/61553566/df4cb874-6edd-44f5-a516-cd538d04cc1a">

## Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2024-01-03 12:40:33 -08:00
Jacob Shandling
740bd69eed
15631 checkbox indents (#15874)
## Addresses #15631 
<img width="881" alt="Screenshot 2024-01-02 at 2 01 13 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/45145f10-cf32-4840-8b71-d8ec9d6fd04d">

- Fix undesired indentation by using clear naming of styles and files to
avoid unintended style collisions

- [x] Changes file added for user-visible changes in `changes/` 
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2024-01-03 12:35:02 -08:00
Martin Angers
d943fbbf8e
Extend script execution timeout (#15779)
#15196 This is the work of @ghernandez345 except for adding the
`ResponseController` thing in Go to override the server timeout for that
specific sync endpoint so that the calls don't timeout waiting for a
script response (the default HTTP server timeout was 90s for our
server).

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
  - For Orbit and Fleet Desktop changes:
- [x] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [x] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).

---------

Co-authored-by: Gabriel Hernandez <ghernandez345@gmail.com>
Co-authored-by: Roberto Dip <me@roperzh.com>
Co-authored-by: Roberto Dip <dip.jesusr@gmail.com>
2024-01-03 16:39:53 -03:00
Jahziel Villasana-Espinoza
2833c80cfe
feat: add option to disable scripts (#15815)
> 📜 Related issue: https://github.com/fleetdm/fleet/issues/14500

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
2024-01-03 10:42:08 -05:00
Victor Lyuboslavsky
348bcd4263
Added tooltip to Policies page stating when policy counts were last updated. (#15784)
Added tooltip to Policies page stating when policy counts were last
updated.
#15323

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
2024-01-03 07:47:43 -06:00
Jacob Shandling
7e18a3f9a9
Frontend - Update test to be more flexible (#15879)
Fixes a test that started failing when its "time ago" changed to "month"
from "days"

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2024-01-02 15:28:39 -08:00
Victor Lyuboslavsky
fc32c2c44b
Fixing failing JS ReportUpdatedCell.tests.tsx on main (#15880)
Fixing failing JS ReportUpdatedCell.tests.tsx on main
2024-01-02 17:25:07 -06:00
Victor Lyuboslavsky
cde104dbd2
On Software page, CVE tooltip no longer has bullets. (#15856)
On Software page, CVE tooltip no longer has bullets.
#15724 

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
2024-01-02 14:04:34 -06:00
Gabriel Hernandez
7e974970bb
fix for tooltip wrapper text alignment (#15755)
relates to #15435

fix for tooltip text alignment across multiple browsers. Firefox needs
additional styles to make the tooltip text appear correct.

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
- [x] Manual QA for all new/changed functionality
2023-12-21 14:43:18 -06:00
Sarah Gillespie
50550092c3
Update UI to display custom device mapping email (#15792) 2023-12-21 14:25:07 -06:00
Jacob Shandling
65d64b67a6
Document props pattern (#15497)
Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-12-21 09:24:18 -08:00
Jacob Shandling
e58f1bbc22
Adjust paginated button icon alignment (#15795)
## Addresses #15032 

<img width="431" alt="Screenshot 2023-12-20 at 4 58 51 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/89b856f8-f2bb-4c00-a8b7-7a115eb1de23">

- [x] Manual QA for all new/changed functionality

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-12-21 09:23:45 -08:00
Jacob Shandling
cce6875787
UI – Render Query Report 'No Results' state when discard_data is enabled, regardless of contents/presence of results; cleanup tooltip content (#15777)
## Addresses #15778 and part of #15608 

## Checklist for submitter
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-12-21 09:23:34 -08:00
Jacob Shandling
d49255dfdb
UI - clip live query results (#15760)
## Addresses #14874 
- once 250,000 (results + errors) return, end the query campaign and
display the "clipped" banner
- Format host counts with commas
- misc. cleanup

<img width="1796" alt="Screenshot 2023-12-19 at 4 37 28 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/353ae5a0-24f0-49c5-b48c-555ff83567e9">

<img width="1796" alt="Screenshot 2023-12-19 at 4 37 02 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/e5722dc5-07b4-4173-8eb3-8d00b3f327ab">


## Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-12-21 09:23:07 -08:00
Gabriel Hernandez
6a3b7b8315
add bold styling to profile name in activities (#15787)
relates to #15762

Add bold styling to the profiles names on adding and deleting profiles
activities.

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
- [x] Manual QA for all new/changed functionality
2023-12-21 11:17:40 -06:00
Gabriel Hernandez
1d6ed55205
Fix UI os updates styles (#15780)
relates to #15733

small style tweaks to nudge preview on os updates page.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
- [x] Manual QA for all new/changed functionality
2023-12-21 11:17:29 -06:00
Gabriel Hernandez
72b0db50b6
add pointer cursor to accordion button on os updates page (#15773)
relates to #15718

Updates the accordion buttons on OS updates to show a pointer cursor on
hover

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
- [x] Manual QA for all new/changed functionality
2023-12-21 11:17:19 -06:00
Gabriel Hernandez
d35879944a
fix formatting of script output (#15757)
relates to #15515

fix the formatting of the script output by replacing the `\r` characters
with `\n` characters.

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
- [x] Manual QA for all new/changed functionality
2023-12-21 11:17:03 -06:00
Gabriel Hernandez
5bdb74c717
fix site nav software item to link to software/titles (#15734)
relates to #15717

Fixes software navigation link to always navigate to /software/titles
page.
2023-12-18 16:52:58 -06:00
Gabriel Hernandez
a10a951827
Fix UI support old software urls (#15727)
relates to #15704

Support old software/:id urls and forward them to software/versions/:id

Also some small UI state improvements
2023-12-18 15:12:00 -06:00
Jacob Shandling
96fc52b1a1
Various document title fixes (#15699)
## Addresses #15692 


https://github.com/fleetdm/fleet/assets/61553566/373df35f-0de5-4c71-84fc-c181a0a5dd07

- Also addresses title not being updated by the Software page due to new
routes and hard-coded paths that no longer matched the new routes
- Also make this area more flexible to avoid these kinds of bugs in the
future

- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-12-18 10:35:29 -08:00
Jacob Shandling
aa64c1cf34
UI – set textarea columns based on placeholder length (#15700)
## Addresses #13095 

<img width="501" alt="Screenshot 2023-12-15 at 1 52 05 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/37fa6d41-e7d0-4324-93c8-d3d7ce4e0d33">


- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-12-18 09:37:40 -08:00
Jacob Shandling
369b3feb35
UI - Update host-specific performance impact calculations (#15706)
## Fixes an existing bug in calculating performance impact for
host-specifc query stats

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
Co-authored-by: Sarah Gillespie <73313222+gillespi314@users.noreply.github.com>
2023-12-18 09:36:47 -08:00
Roberto Dip
4bf1549edf
fix background color of OS updates inputs (#15695)
Unreleased bug for software updates, this sets the background color to
white to match [the
design](https://www.figma.com/file/47NY3lf808YJG3O72l7pEC/%2311951-Windows-OS-updates?type=design&node-id=140-2790&mode=design&t=B8cw9JqeT9t8arW2-0)

<img width="693" alt="image"
src="https://github.com/fleetdm/fleet/assets/4419992/b5727179-1150-4ca1-84e8-e05b3c1744e3">
2023-12-15 16:14:35 -03:00
Sarah Gillespie
b03b8329b0
Adjust icon styles for new software titles UI (#15675) 2023-12-14 16:23:34 -06:00
Jacob Shandling
648e292769
UI – Allow selecting label while search input is focused (#15664)
## Addresses #15649 

https://www.loom.com/share/83e82bba3dfe4cd3a155fbb82b100831?sid=75d796ef-00d2-456b-a7a9-e0386e40c0c9

## Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-12-14 12:06:05 -08:00
Jacob Shandling
1fa5004428
UI – Add and update performance impact features to uitilize metrics that include live query runs (#15642)
Merging during freeze with approval from all stakeholders, including verbal approval from @sharon-fdm 

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-12-14 11:49:56 -08:00
Jacob Shandling
b045b462c5
UI – Redirect from old route as intended (#15660)
## Addresses #15656 


- [x] Manual QA for all new/changed functionality

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-12-14 11:20:12 -08:00
Jacob Shandling
6ecdb770d5
UI – render all global queries on queries page (#15627)
## Addresses [this
clarification](https://github.com/fleetdm/fleet/issues/14415#issuecomment-1854432825)

- For Observers and Observers+ (that is, all global users), render _all_
global queries, which are returned from the API, instead of filtering
out those without "Observer can run"
<img width="998" alt="Screenshot 2023-12-13 at 11 09 02 AM"
src="https://github.com/fleetdm/fleet/assets/61553566/e3fd19ba-5907-43c6-a67e-c4f1310b27c5">

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-12-14 10:26:20 -08:00
Sarah Gillespie
a59699d207
Add no team option to automatic enrollment modal (#15616) 2023-12-13 12:27:14 -06:00
Luke Heath
66e1852ab5
Add left padding to link in ABM expired message (#15603) 2023-12-13 10:51:45 -06:00
George Karr
f1159172df
Update NudgePreview.tsx (#15470) 2023-12-13 09:06:58 -06:00
Sarah Gillespie
7155d83b6f
Adjust tooltip style for query page side panel (#15614) 2023-12-12 20:48:31 -06:00
Jacob Shandling
7938f70adf
UI – Fix 2 small unreleased bugs (#15613)
Fix bugs where:
- global queries cache would be set unfiltered and then overridden
filtered as desired – filtered them in the same way whether fetched as
inherited or current team
- avoid blindly adding the `host_display_name` column to query report
exports if not desired

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-12-12 18:44:08 -08:00
Sarah Gillespie
1681603bae
Fetch host count for software version detail page (#15610) 2023-12-12 17:28:41 -06:00
Luke Heath
6ee5d87d48
Add loading spinner to host details' scripts tab (#15607) 2023-12-12 16:34:53 -06:00
Jacob Shandling
0967256cce
Per Host Query Reports (#15591)
## Addresses #14415 
<img width="1281" alt="image"
src="https://github.com/fleetdm/fleet/assets/61553566/568f367b-abaa-4c27-b68d-763af9c6a104">
<img width="1277" alt="image"
src="https://github.com/fleetdm/fleet/assets/61553566/07043268-d68a-46c7-94cf-47adb2b86ae3">

- [X] Changes file added for user-visible changes in `changes/` 
- [X] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [X] Added/updated tests
- [X] Manual QA for all new/changed functionality

co-authored by @mostlikelee and @jacobshandling
2023-12-12 14:32:41 -08:00
Sarah Gillespie
6b4f85fd92
Add browser type to software titles UI and API (#15604) 2023-12-12 16:21:44 -06:00
Jacob Shandling
076f286c86 update prop name to sync new code from main 2023-12-12 13:27:41 -08:00
Jacob Shandling
df1d279a92 Merge branch 'main' into 14415 2023-12-12 13:13:56 -08:00
Noah Talerman
b60c91cb19
Fix link on Organization settings > SSO page (#15581)
- Add redirect so that we can change the link later w/o breaking it in
the UI
2023-12-12 16:13:35 -05:00
Gabriel Hernandez
9d65a2dc8c
Implement UI for new software pages (#15579) 2023-12-12 15:03:33 -06:00
Noah Talerman
053582fd88
Update disk encryption docs (#15496)
- Associated w/ this story: #15600 
- Update docs now that disk encryption enforcement is cross platform
(Windows story here: #12577)
- Remove section about resetting a password w/ disk encryption key to
reduce doc content. Remove this link from the UI
2023-12-12 15:58:26 -05:00
Luke Heath
7a1797f621
Linux and Windows MDM scripts (#15501) 2023-12-12 14:52:27 -06:00
Jacob Shandling
fd1b1c50b5
14415 - Loose ends 2 (#15595)
## Addresses #15011 

- Sort host details > queries list by query name
- Update shape of expected response from HQR call to schedulable query
API
- Shorten the 'clipped' banner's message for Observers and Observers+
- Update tooltips in RevealButton

- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-12-12 11:32:16 -08:00