Everyone can contribute to the handbook, and page DRIs are expected to
keep their pages up to date. To shape and absorb changes, and learn from
how GitLab evolved its handbook as that company grew, CEO will ALSO
review all PRs that change the handbook before they are merged.
(Background: As of mid-2023, there are only ≤3 handbook PRs per weekday
on the busiest of weeks. If this increases dramatically, or when time
allows the company to prioritize writing down the content design,
structure, and vision for the evolution of the handbook, we'll change )
---------
Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
- Deduplicate config for DRI vs CODEOWNERS (this eliminates extra
notifications folks were receiving)
- auto-remove #g-ceo and #handbook labels when appropriate
- improve comments
https://github.com/fleetdm/confidential/issues/3146
To test this works:
- sam should be able to change ceo handbook and be autoapproved
- mike submitting a PR to the ceo handbook should request review from
Sam but auto-approve for mike
- Jarod's use case of creating an article should now work, even if his
PR contains images
.
---------
Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
Related to #11185 this adds a Puppet module that provides:
1. A custom type named `fleetdm::profile` that can be used to define
profiles to a device
2. A function named `fleetdm::release_device` that can be used to
release a device from await device configuration.
Instructions/usage can be found in the `README.md` file.
---------
Co-authored-by: Martin Angers <martin.n.angers@gmail.com>
+ Added myself to `/docs/` as discussed with @mikermcneil
+ Also to the specific doc sections for the REST API and API for
contributors because they were separated out (let me know if you'd
rather I remove myself from those, don't mean to get grabby!)
+ Fixed a typo ✨
.
---------
Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
Changes:
- Changed the version of osquery schema we merge with Fleet's overrides
from `5.7.0` to `5.8.1`
- Rand the `generate-merged-schema` script to regenerate
`osquery_fleet_schema.json` .
## EDIT
Mike: Hi Eric, if my changes look good to you, and if it's passing CI,
would you merge?
.
---------
Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
# Checklist for submitter
If some of the following don't apply, delete the relevant line.
- [ ] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [ ] Documented any API changes (docs/Using-Fleet/REST-API.md or
docs/Contributing/API-for-contributors.md)
- [ ] Documented any permissions changes
- [ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for
new osquery data ingestion features.
- [ ] Added/updated tests
- [ ] Manual QA for all new/changed functionality
- For Orbit and Fleet Desktop changes:
- [ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
Reverse a previous change I made that was a mistake, and temporarily remove automated requests for review.
As it was, it wasn't working, and was just creating noise for more folks e.g. extra reviewers in https://github.com/fleetdm/fleet/pull/9001
* Codeowners
Before we changed to Nate being the code owner for the page, I received notifications for reviewing changes to the ceo-handbook subpage. Now that defaults to Nate.
Not sure if this is the fix for that or not. But wanted to put it on someone's radar.
* Update CODEOWNERS
Co-authored-by: Roberto Dip <me@roperzh.com>
Co-authored-by: Roberto Dip <me@roperzh.com>
* Mo == DRI of status of features table on pricing page
- CEO is DRI of pricing
- Mo is DRI of features table correctness
Input of many other contributors is important to both.
* Update CODEOWNERS
* Update CODEOWNERS
* Update custom.js
* Codeowners: Reduce # of pings for reviews of docs
To avoid duplicative pings in Slack, reduce the number of folks who get automatically pinged about review requests when documentation, handbook, and website routes are changed.
I left Mike T and Chris both on the digital experience handbook so that PRs can be merged quickly there in many cases, regardless of timezone.
Also @chris-mcgillicuddy I made you responsible for either (a) approving and merging or (b) if there changes to meaning or code samples, requesting review from the on-call engineer.
* Update to reflect routing doc changes through Chris, and add sub-headings
* Pull the most relevant sentences to the top of each responsibility
* Use more peaceful language
* Reorganized infrastructure, updated for frontend's loadtesting
* Add changes suggested by @chiiph
* Moved files per suggestion by Ben
* Update docs with new links
* Add config for multi account assume role
